Title: [122728] trunk/Tools
- Revision
- 122728
- Author
- [email protected]
- Date
- 2012-07-16 07:56:19 -0700 (Mon, 16 Jul 2012)
Log Message
run-webkit-test returns 254 at exit even when it succeeds
https://bugs.webkit.org/show_bug.cgi?id=91370
Patch by Thiago Marcos P. Santos <[email protected]> on 2012-07-16
Reviewed by Simon Hausmann.
sys.exit() is implemented by raising SystemExit which inherits from
BaseException. Since we are catching BaseException, run_webkit_tests.py
was always returning an error code.
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (122727 => 122728)
--- trunk/Tools/ChangeLog 2012-07-16 14:56:08 UTC (rev 122727)
+++ trunk/Tools/ChangeLog 2012-07-16 14:56:19 UTC (rev 122728)
@@ -1,3 +1,16 @@
+2012-07-16 Thiago Marcos P. Santos <[email protected]>
+
+ run-webkit-test returns 254 at exit even when it succeeds
+ https://bugs.webkit.org/show_bug.cgi?id=91370
+
+ Reviewed by Simon Hausmann.
+
+ sys.exit() is implemented by raising SystemExit which inherits from
+ BaseException. Since we are catching BaseException, run_webkit_tests.py
+ was always returning an error code.
+
+ * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
+
2012-07-15 Carlos Garcia Campos <[email protected]>
Unreviewed. Fix make distcheck.
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py (122727 => 122728)
--- trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py 2012-07-16 14:56:08 UTC (rev 122727)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py 2012-07-16 14:56:19 UTC (rev 122728)
@@ -482,8 +482,10 @@
if '__main__' == __name__:
try:
- sys.exit(main())
+ return_code = main()
except BaseException, e:
if e.__class__ in (KeyboardInterrupt, TestRunInterruptedException):
sys.exit(INTERRUPTED_EXIT_STATUS)
sys.exit(EXCEPTIONAL_EXIT_STATUS)
+
+ sys.exit(return_code)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
