Title: [122781] trunk/Source/WebKit/chromium
- Revision
- 122781
- Author
- [email protected]
- Date
- 2012-07-16 17:31:09 -0700 (Mon, 16 Jul 2012)
Log Message
[chromium] Fix WebFrameTest flakiness due to synthetic mouse events
https://bugs.webkit.org/show_bug.cgi?id=91428
Patch by Alexandre Elias <[email protected]> on 2012-07-16
Reviewed by Adam Barth.
Synthetic mouse move events on scrolling can cause segfaults in
WebFrameTest due to delayed callbacks on the message loop after
state destruction. This is currently only affecting
the Android port, but has the potential to affect other platforms in the
future.
We can avoid the issue by disabling the deviceSupportsMouse
setting, which shouldn't be needed by any WebFrameTest.
* tests/FrameTestHelpers.cpp:
(WebKit::FrameTestHelpers::createWebViewAndLoad):
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (122780 => 122781)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-07-17 00:03:48 UTC (rev 122780)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-07-17 00:31:09 UTC (rev 122781)
@@ -1,3 +1,22 @@
+2012-07-16 Alexandre Elias <[email protected]>
+
+ [chromium] Fix WebFrameTest flakiness due to synthetic mouse events
+ https://bugs.webkit.org/show_bug.cgi?id=91428
+
+ Reviewed by Adam Barth.
+
+ Synthetic mouse move events on scrolling can cause segfaults in
+ WebFrameTest due to delayed callbacks on the message loop after
+ state destruction. This is currently only affecting
+ the Android port, but has the potential to affect other platforms in the
+ future.
+
+ We can avoid the issue by disabling the deviceSupportsMouse
+ setting, which shouldn't be needed by any WebFrameTest.
+
+ * tests/FrameTestHelpers.cpp:
+ (WebKit::FrameTestHelpers::createWebViewAndLoad):
+
2012-07-16 Alec Flett <[email protected]>
IndexedDB: Introduce putWithIndexKeys and calculate them in the renderer
Modified: trunk/Source/WebKit/chromium/tests/FrameTestHelpers.cpp (122780 => 122781)
--- trunk/Source/WebKit/chromium/tests/FrameTestHelpers.cpp 2012-07-17 00:03:48 UTC (rev 122780)
+++ trunk/Source/WebKit/chromium/tests/FrameTestHelpers.cpp 2012-07-17 00:31:09 UTC (rev 122781)
@@ -80,6 +80,7 @@
webViewClient = defaultWebViewClient();
WebView* webView = WebView::create(webViewClient);
webView->settings()->setJavaScriptEnabled(enableJavascript);
+ webView->settings()->setDeviceSupportsMouse(false);
webView->initializeMainFrame(webFrameClient);
loadFrame(webView->mainFrame(), url);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
