Title: [122786] trunk/Source/WebCore
- Revision
- 122786
- Author
- [email protected]
- Date
- 2012-07-16 17:48:54 -0700 (Mon, 16 Jul 2012)
Log Message
Comment on WebCore::HTMLMediaElement::childShouldCreateRenderer() should explain why
https://bugs.webkit.org/show_bug.cgi?id=91174
Reviewed by Kent Tamura.
Clarified the explanation.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::childShouldCreateRenderer):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (122785 => 122786)
--- trunk/Source/WebCore/ChangeLog 2012-07-17 00:46:13 UTC (rev 122785)
+++ trunk/Source/WebCore/ChangeLog 2012-07-17 00:48:54 UTC (rev 122786)
@@ -1,3 +1,15 @@
+2012-07-16 MORITA Hajime <[email protected]>
+
+ Comment on WebCore::HTMLMediaElement::childShouldCreateRenderer() should explain why
+ https://bugs.webkit.org/show_bug.cgi?id=91174
+
+ Reviewed by Kent Tamura.
+
+ Clarified the explanation.
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::childShouldCreateRenderer):
+
2012-07-16 Sheriff Bot <[email protected]>
Unreviewed, rolling out r120033.
@@ -40,6 +52,37 @@
(IDBTransaction):
* Modules/indexeddb/IDBTransaction.idl: The error attribute no longer throws.
+2012-07-16 Joshua Bell <[email protected]>
+
+ IndexedDB: Implement spec updates to IDBTransaction.error
+ https://bugs.webkit.org/show_bug.cgi?id=91409
+
+ Reviewed by Tony Chang.
+
+ The Indexed DB spec was updated to resolve some edge cases around the
+ IDBTransaction.error attribute. It was agreed that accessing error should
+ never throw, error should be null if the transaction is not finished or
+ abort() was explicitly called, an appropriate error should be returned if
+ a commit failed, and a generic AbortError should be used if a request
+ callback throws. These cases are now handled per spec, except that a reason
+ is not provided for the commit failure (it's always UnknownError).
+
+ Test: storage/indexeddb/transaction-error.html
+ storage/indexeddb/transaction-abort.html
+
+ * Modules/indexeddb/IDBRequest.cpp:
+ (WebCore::IDBRequest::dispatchEvent): Refactor some nested if() blocks; don't
+ re-abort the transaction if dispatching in response to an abort.
+ (WebCore::IDBRequest::uncaughtExceptionInEventHandler): Abort transaction
+ only if not already aborting, and set it's error to AbortError.
+ * Modules/indexeddb/IDBTransaction.cpp:
+ (WebCore::IDBTransaction::onAbort): Set error if abort triggered by back end.
+ * Modules/indexeddb/IDBTransaction.h:
+ (WebCore::IDBTransaction::db): Move impl to header file.
+ (WebCore::IDBTransaction::error): Move impl to header file, simplify.
+ (IDBTransaction):
+ * Modules/indexeddb/IDBTransaction.idl: The error attribute no longer throws.
+
2012-07-16 Alec Flett <[email protected]>
IndexedDB: Introduce putWithIndexKeys and calculate them in the renderer
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (122785 => 122786)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2012-07-17 00:46:13 UTC (rev 122785)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2012-07-17 00:48:54 UTC (rev 122786)
@@ -490,7 +490,10 @@
{
if (!hasMediaControls())
return false;
- // Only allows nodes from the controls shadow subtree.
+ // <media> doesn't allow its content, including shadow subtree, to
+ // be rendered. So this should return false for most of the children.
+ // One exception is a shadow tree built for rendering controls which should be visible.
+ // So we let them go here by comparing its subtree root with one of the controls.
return (mediaControls()->treeScope() == childContext.node()->treeScope()
&& childContext.isOnUpperEncapsulationBoundary() && HTMLElement::childShouldCreateRenderer(childContext));
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
