Title: [122791] trunk/Source/WebCore
- Revision
- 122791
- Author
- [email protected]
- Date
- 2012-07-16 18:24:45 -0700 (Mon, 16 Jul 2012)
Log Message
[chromium] Turn off ScrollbarLayerChromium for Windows due to bad alpha values
https://bugs.webkit.org/show_bug.cgi?id=91438
Reviewed by Kenneth Russell.
r120509 turned on blending for scrollbar thumbs. Unfortunately for
Windows XP scrollbar thumbs, their alpha channel is bogus and so the
thumb ends up being completely transparent. This should ultimately be
fixed in Chromium theme code, but in the meantime this patch turns
off the use of ScrollbarLayerChromium.
This change makes Windows scrollbars fall back to using normal
ContentLayerChromiums and being painted all in one layer on the main
thread rather than being painted separately and composited on the
compositor thread.
* page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::createScrollbarLayer):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (122790 => 122791)
--- trunk/Source/WebCore/ChangeLog 2012-07-17 01:14:18 UTC (rev 122790)
+++ trunk/Source/WebCore/ChangeLog 2012-07-17 01:24:45 UTC (rev 122791)
@@ -1,3 +1,24 @@
+2012-07-16 Adrienne Walker <[email protected]>
+
+ [chromium] Turn off ScrollbarLayerChromium for Windows due to bad alpha values
+ https://bugs.webkit.org/show_bug.cgi?id=91438
+
+ Reviewed by Kenneth Russell.
+
+ r120509 turned on blending for scrollbar thumbs. Unfortunately for
+ Windows XP scrollbar thumbs, their alpha channel is bogus and so the
+ thumb ends up being completely transparent. This should ultimately be
+ fixed in Chromium theme code, but in the meantime this patch turns
+ off the use of ScrollbarLayerChromium.
+
+ This change makes Windows scrollbars fall back to using normal
+ ContentLayerChromiums and being painted all in one layer on the main
+ thread rather than being painted separately and composited on the
+ compositor thread.
+
+ * page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
+ (WebCore::createScrollbarLayer):
+
2012-07-16 Koji Ishii <[email protected]>
Vertical alternate glyph (GSUB) support for OpenTypeVerticalData
Modified: trunk/Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp (122790 => 122791)
--- trunk/Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp 2012-07-17 01:14:18 UTC (rev 122790)
+++ trunk/Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp 2012-07-17 01:24:45 UTC (rev 122791)
@@ -125,9 +125,12 @@
if (!scrollbarGraphicsLayer->contentsOpaque())
scrollbarGraphicsLayer->setContentsOpaque(isOpaqueRootScrollbar);
- // FIXME: Mac scrollbar themes are not thread-safe.
+ // FIXME: Mac scrollbar themes are not thread-safe to paint.
+ // FIXME: Win scrollbars on XP Classic themes do not paint valid alpha
+ // values due to GDI. This needs to be fixed in theme code before it
+ // can be turned on here.
bool platformSupported = true;
-#if OS(DARWIN)
+#if OS(DARWIN) || OS(WINDOWS)
platformSupported = false;
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
