[webkit-changes] [122807] trunk/Source/WebKit/chromium

[yosin]

Title: [122807] trunk/Source/WebKit/chromium

Revision

122807

Author

yo...@chromium.org

Date

2012-07-16 22:11:16 -0700 (Mon, 16 Jul 2012)

Log Message

REGRESSION(r122552): DecimalTest tests (CeilingSmallExponent and FloorSmallExponent) started failing.
https://bugs.webkit.org/show_bug.cgi?id=91244

Reviewed by Kent Tamura.

This patch enables and updates disabled test cases of DecimalTest
caused by fixes in r122552 of Decimal::ceiling() and Decimal::floor()
for small fraction numbers and added test cases. Fixes in r122552
itself is correct however, it didn't update existing tests for very small
fraction numbers.

* tests/DecimalTest.cpp:
(TEST_F): CeilingSmallExponent: Change expected value to 1 for ceiling(1e-1000),
ceiling rounds number toward positive infinity.
(TEST_F): FloorSmallExponent: Change expected value to -1 for floor(-1e-1000),
floor rounds number toward negative infinity.

Modified Paths

• trunk/Source/WebKit/chromium/ChangeLog
• trunk/Source/WebKit/chromium/tests/DecimalTest.cpp

Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (122806 => 122807)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-07-17 04:37:29 UTC (rev 122806)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-07-17 05:11:16 UTC (rev 122807)
@@ -1,3 +1,22 @@
+2012-07-16  Yoshifumi Inoue  <yo...@chromium.org>
+
+        REGRESSION(r122552): DecimalTest tests (CeilingSmallExponent and FloorSmallExponent) started failing.
+        https://bugs.webkit.org/show_bug.cgi?id=91244
+
+        Reviewed by Kent Tamura.
+
+        This patch enables and updates disabled test cases of DecimalTest
+        caused by fixes in r122552 of Decimal::ceiling() and Decimal::floor()
+        for small fraction numbers and added test cases. Fixes in r122552
+        itself is correct however, it didn't update existing tests for very small
+        fraction numbers.
+
+        * tests/DecimalTest.cpp:
+        (TEST_F): CeilingSmallExponent: Change expected value to 1 for ceiling(1e-1000),
+        ceiling rounds number toward positive infinity.
+        (TEST_F): FloorSmallExponent: Change expected value to -1 for floor(-1e-1000),
+        floor rounds number toward negative infinity.
+
 2012-07-16  Koji Ishii  <kojii...@gmail.com>
 
         Vertical alternate glyph (GSUB) support for OpenTypeVerticalData

Modified: trunk/Source/WebKit/chromium/tests/DecimalTest.cpp (122806 => 122807)

--- trunk/Source/WebKit/chromium/tests/DecimalTest.cpp	2012-07-17 04:37:29 UTC (rev 122806)
+++ trunk/Source/WebKit/chromium/tests/DecimalTest.cpp	2012-07-17 05:11:16 UTC (rev 122807)
@@ -231,9 +231,9 @@
     EXPECT_EQ(encode(1, 1000, Negative), encode(1, 1000, Negative).ceiling());
 }
 
-TEST_F(DecimalTest, DISABLED_CeilingSmallExponent)
+TEST_F(DecimalTest, CeilingSmallExponent)
 {
-    EXPECT_EQ(encode(0, 0, Positive), encode(1, -1000, Positive).ceiling());
+    EXPECT_EQ(encode(1, 0, Positive), encode(1, -1000, Positive).ceiling());
     EXPECT_EQ(encode(0, 0, Negative), encode(1, -1000, Negative).ceiling());
 }
 
@@ -547,10 +547,10 @@
     EXPECT_EQ(encode(1, 1000, Negative), encode(1, 1000, Negative).floor());
 }
 
-TEST_F(DecimalTest, DISABLED_FloorSmallExponent)
+TEST_F(DecimalTest, FloorSmallExponent)
 {
     EXPECT_EQ(encode(0, 0, Positive), encode(1, -1000, Positive).floor());
-    EXPECT_EQ(encode(0, 0, Negative), encode(1, -1000, Negative).floor());
+    EXPECT_EQ(encode(1, 0, Negative), encode(1, -1000, Negative).floor());
 }
 
 TEST_F(DecimalTest, FloorSpecialValues)

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes