Title: [122841] trunk
- Revision
- 122841
- Author
- [email protected]
- Date
- 2012-07-17 06:23:04 -0700 (Tue, 17 Jul 2012)
Log Message
[QT] REGRESSION (r122720): svg/filters/feSpecularLight-premultiplied.svg
https://bugs.webkit.org/show_bug.cgi?id=91390
Reviewed by Zoltan Herczeg.
Fix the regression by using the proper imagetype conversion in ImageBuffer::platformTransformColorSpace.
The test is unskipped.
Source/WebCore:
* platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::ImageBuffer::platformTransformColorSpace):
LayoutTests:
* platform/qt/Skipped:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (122840 => 122841)
--- trunk/LayoutTests/ChangeLog 2012-07-17 12:30:03 UTC (rev 122840)
+++ trunk/LayoutTests/ChangeLog 2012-07-17 13:23:04 UTC (rev 122841)
@@ -1,3 +1,16 @@
+2012-07-17 Zoltan Horvath <[email protected]>
+
+ [QT] REGRESSION (r122720): svg/filters/feSpecularLight-premultiplied.svg
+ https://bugs.webkit.org/show_bug.cgi?id=91390
+
+ Reviewed by Zoltan Herczeg.
+
+ Fix the regression by using the proper imagetype conversion in ImageBuffer::platformTransformColorSpace.
+
+ The test is unskipped.
+
+ * platform/qt/Skipped:
+
2012-07-17 János Badics <[email protected]>
[Qt] Unreviewed gardening after r122824.
Modified: trunk/LayoutTests/platform/qt/Skipped (122840 => 122841)
--- trunk/LayoutTests/platform/qt/Skipped 2012-07-17 12:30:03 UTC (rev 122840)
+++ trunk/LayoutTests/platform/qt/Skipped 2012-07-17 13:23:04 UTC (rev 122841)
@@ -2584,10 +2584,6 @@
# https://bugs.webkit.org/show_bug.cgi?id=91063
compositing/columns/geometry-map-paginated-assert.html
-# [QT] REGRESSION (r122720): svg/filters/feSpecularLight-premultiplied.svg
-# https://bugs.webkit.org/show_bug.cgi?id=91390
-svg/filters/feSpecularLight-premultiplied.svg
-
# [Qt] REGRESSION(r122768, r122771): They broke jquery/data.html and inspector/elements/edit-dom-actions.html
# https://bugs.webkit.org/show_bug.cgi?id=91476
inspector/elements/edit-dom-actions.html
Modified: trunk/Source/WebCore/ChangeLog (122840 => 122841)
--- trunk/Source/WebCore/ChangeLog 2012-07-17 12:30:03 UTC (rev 122840)
+++ trunk/Source/WebCore/ChangeLog 2012-07-17 13:23:04 UTC (rev 122841)
@@ -1,3 +1,17 @@
+2012-07-17 Zoltan Horvath <[email protected]>
+
+ [QT] REGRESSION (r122720): svg/filters/feSpecularLight-premultiplied.svg
+ https://bugs.webkit.org/show_bug.cgi?id=91390
+
+ Reviewed by Zoltan Herczeg.
+
+ Fix the regression by using the proper imagetype conversion in ImageBuffer::platformTransformColorSpace.
+
+ The test is unskipped.
+
+ * platform/graphics/qt/ImageBufferQt.cpp:
+ (WebCore::ImageBuffer::platformTransformColorSpace):
+
2012-07-17 Vivek Galatage <[email protected]>
Web Inspector: refactor InspectorController::connectFrontend() to accept InspectorFrontendChannel.
Modified: trunk/Source/WebCore/platform/graphics/qt/ImageBufferQt.cpp (122840 => 122841)
--- trunk/Source/WebCore/platform/graphics/qt/ImageBufferQt.cpp 2012-07-17 12:30:03 UTC (rev 122840)
+++ trunk/Source/WebCore/platform/graphics/qt/ImageBufferQt.cpp 2012-07-17 13:23:04 UTC (rev 122841)
@@ -150,7 +150,7 @@
if (isPainting)
m_data.m_painter->end();
- QImage image = m_data.m_nativeImage;
+ QImage image = m_data.m_nativeImage.convertToFormat(QImage::Format_ARGB32);
ASSERT(!image.isNull());
uchar* bits = image.bits();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
