Title: [122854] branches/chromium/1180/Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp
- Revision
- 122854
- Author
- [email protected]
- Date
- 2012-07-17 10:40:56 -0700 (Tue, 17 Jul 2012)
Log Message
Merge 122791 - [chromium] Turn off ScrollbarLayerChromium for Windows due to bad alpha values
https://bugs.webkit.org/show_bug.cgi?id=91438
Reviewed by Kenneth Russell.
r120509 turned on blending for scrollbar thumbs. Unfortunately for
Windows XP scrollbar thumbs, their alpha channel is bogus and so the
thumb ends up being completely transparent. This should ultimately be
fixed in Chromium theme code, but in the meantime this patch turns
off the use of ScrollbarLayerChromium.
This change makes Windows scrollbars fall back to using normal
ContentLayerChromiums and being painted all in one layer on the main
thread rather than being painted separately and composited on the
compositor thread.
* page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::createScrollbarLayer):
[email protected]
Review URL: https://chromiumcodereview.appspot.com/10704248
Modified Paths
Diff
Modified: branches/chromium/1180/Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp (122853 => 122854)
--- branches/chromium/1180/Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp 2012-07-17 17:35:25 UTC (rev 122853)
+++ branches/chromium/1180/Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp 2012-07-17 17:40:56 UTC (rev 122854)
@@ -120,9 +120,12 @@
if (!scrollbarGraphicsLayer->contentsOpaque())
scrollbarGraphicsLayer->setContentsOpaque(isOpaqueRootScrollbar);
- // FIXME: Mac scrollbar themes are not thread-safe.
+ // FIXME: Mac scrollbar themes are not thread-safe to paint.
+ // FIXME: Win scrollbars on XP Classic themes do not paint valid alpha
+ // values due to GDI. This needs to be fixed in theme code before it
+ // can be turned on here.
bool platformSupported = true;
-#if OS(DARWIN)
+#if OS(DARWIN) || OS(WINDOWS)
platformSupported = false;
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
