Title: [122884] trunk/Source/WebKit/chromium
Revision
122884
Author
[email protected]
Date
2012-07-17 16:04:45 -0700 (Tue, 17 Jul 2012)

Log Message

IndexedDB: Add intVersion to chromium/public/WebIDBMetadata.h
https://bugs.webkit.org/show_bug.cgi?id=91408

Reviewed by Adam Barth.

This is in support of the new upgradeneeded versioning api.
intVersion will eventually replace the WebString version member.

* public/WebIDBMetadata.h:
(WebIDBMetadata): The spec uses unsigned long long for version
numbers but we use int64_t here so that we can use -1 as a sentinel.
It indicates that a database still uses a string version.

Modified Paths

Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (122883 => 122884)


--- trunk/Source/WebKit/chromium/ChangeLog	2012-07-17 22:51:46 UTC (rev 122883)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-07-17 23:04:45 UTC (rev 122884)
@@ -1,3 +1,18 @@
+2012-07-17  David Grogan  <[email protected]>
+
+        IndexedDB: Add intVersion to chromium/public/WebIDBMetadata.h
+        https://bugs.webkit.org/show_bug.cgi?id=91408
+
+        Reviewed by Adam Barth.
+
+        This is in support of the new upgradeneeded versioning api.
+        intVersion will eventually replace the WebString version member.
+
+        * public/WebIDBMetadata.h:
+        (WebIDBMetadata): The spec uses unsigned long long for version
+        numbers but we use int64_t here so that we can use -1 as a sentinel.
+        It indicates that a database still uses a string version.
+
 2012-07-17  Tony Chang  <[email protected]>
 
         Unreviewed.  Rolled DEPS.

Modified: trunk/Source/WebKit/chromium/public/WebIDBMetadata.h (122883 => 122884)


--- trunk/Source/WebKit/chromium/public/WebIDBMetadata.h	2012-07-17 22:51:46 UTC (rev 122883)
+++ trunk/Source/WebKit/chromium/public/WebIDBMetadata.h	2012-07-17 23:04:45 UTC (rev 122884)
@@ -38,13 +38,21 @@
 namespace WebKit {
 
 struct WebIDBMetadata {
+    enum {
+        NoIntVersion = -1
+    };
     struct Index;
     struct ObjectStore;
 
     WebString name;
+    // FIXME: Both version members need to be present while we support both the
+    // old setVersion and new upgradeneeded API. Once we no longer support
+    // setVersion, WebString version can be removed.
     WebString version;
+    int64_t intVersion;
     WebVector<ObjectStore> objectStores;
-    WebIDBMetadata() { }
+    WebIDBMetadata()
+        : intVersion(NoIntVersion) { }
 
     struct ObjectStore {
         WebString name;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to