Title: [122972] trunk/Source/WebCore
- Revision
- 122972
- Author
- [email protected]
- Date
- 2012-07-18 08:04:17 -0700 (Wed, 18 Jul 2012)
Log Message
[BlackBerry] We should update the status in NetworkJob if there is a new one from libcurl.
https://bugs.webkit.org/show_bug.cgi?id=91475
Reviewed by Yong Li.
Libcurl sometimes sends multiple status messages, we need to keep the last
one in NetworkJob.
We originally had the m_statusReceived check, then we found out that libcurl
sometimes sent additional 401 codes and added the 401 exception to the check,
and now we're removing the whole check(so we don't need the exception either).
RIM PR# 163172
Reviewed internally by Joe Mason.
No new tests. This is caused by libcurl's multiple status messages.
So we don't need to write a test case for webkit.
* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::handleNotifyStatusReceived):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (122971 => 122972)
--- trunk/Source/WebCore/ChangeLog 2012-07-18 14:52:05 UTC (rev 122971)
+++ trunk/Source/WebCore/ChangeLog 2012-07-18 15:04:17 UTC (rev 122972)
@@ -1,3 +1,25 @@
+2012-07-18 Jason Liu <[email protected]>
+
+ [BlackBerry] We should update the status in NetworkJob if there is a new one from libcurl.
+ https://bugs.webkit.org/show_bug.cgi?id=91475
+
+ Reviewed by Yong Li.
+
+ Libcurl sometimes sends multiple status messages, we need to keep the last
+ one in NetworkJob.
+ We originally had the m_statusReceived check, then we found out that libcurl
+ sometimes sent additional 401 codes and added the 401 exception to the check,
+ and now we're removing the whole check(so we don't need the exception either).
+
+ RIM PR# 163172
+ Reviewed internally by Joe Mason.
+
+ No new tests. This is caused by libcurl's multiple status messages.
+ So we don't need to write a test case for webkit.
+
+ * platform/network/blackberry/NetworkJob.cpp:
+ (WebCore::NetworkJob::handleNotifyStatusReceived):
+
2012-07-18 Kevin Ellis <[email protected]>
TOUCH_ADJUSTMENT is too aggressive when snapping to large elements.
Modified: trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp (122971 => 122972)
--- trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp 2012-07-18 14:52:05 UTC (rev 122971)
+++ trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp 2012-07-18 15:04:17 UTC (rev 122972)
@@ -192,7 +192,7 @@
void NetworkJob::handleNotifyStatusReceived(int status, const String& message)
{
// Check for messages out of order or after cancel.
- if ((m_statusReceived && m_extendedStatusCode != 401) || m_responseSent || m_cancelled)
+ if (m_responseSent || m_cancelled)
return;
if (isInfo(status))
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
