Title: [122979] trunk/Source/WebCore
Revision
122979
Author
[email protected]
Date
2012-07-18 09:10:35 -0700 (Wed, 18 Jul 2012)

Log Message

Web Inspector: [Regression] Save as file is missing in Network panel preview/response tabs.
https://bugs.webkit.org/show_bug.cgi?id=91625

Reviewed by Vsevolod Vlasov.

* inspector/front-end/HandlerRegistry.js:
* inspector/front-end/NetworkPanel.js:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (122978 => 122979)


--- trunk/Source/WebCore/ChangeLog	2012-07-18 15:42:40 UTC (rev 122978)
+++ trunk/Source/WebCore/ChangeLog	2012-07-18 16:10:35 UTC (rev 122979)
@@ -1,3 +1,13 @@
+2012-07-18  Pavel Feldman  <[email protected]>
+
+        Web Inspector: [Regression] Save as file is missing in Network panel preview/response tabs.
+        https://bugs.webkit.org/show_bug.cgi?id=91625
+
+        Reviewed by Vsevolod Vlasov.
+
+        * inspector/front-end/HandlerRegistry.js:
+        * inspector/front-end/NetworkPanel.js:
+
 2012-07-18  Dirk Schulze  <[email protected]>
 
         SVG CSS property types with <number> don't support exponents

Modified: trunk/Source/WebCore/inspector/front-end/HandlerRegistry.js (122978 => 122979)


--- trunk/Source/WebCore/inspector/front-end/HandlerRegistry.js	2012-07-18 15:42:40 UTC (rev 122978)
+++ trunk/Source/WebCore/inspector/front-end/HandlerRegistry.js	2012-07-18 16:10:35 UTC (rev 122979)
@@ -96,7 +96,7 @@
      */
     appendApplicableItems: function(contextMenu, target)
     {
-        if (!(target instanceof WebInspector.UISourceCode || target instanceof WebInspector.Resource))
+        if (!(target instanceof WebInspector.UISourceCode || target instanceof WebInspector.Resource || target instanceof WebInspector.NetworkRequest))
             return;
         var contentProvider = /** @type {WebInspector.ContentProvider} */ target;
         if (!contentProvider.contentURL())

Modified: trunk/Source/WebCore/inspector/front-end/NetworkItemView.js (122978 => 122979)


--- trunk/Source/WebCore/inspector/front-end/NetworkItemView.js	2012-07-18 15:42:40 UTC (rev 122978)
+++ trunk/Source/WebCore/inspector/front-end/NetworkItemView.js	2012-07-18 16:10:35 UTC (rev 122979)
@@ -63,7 +63,7 @@
         var timingView = new WebInspector.RequestTimingView(request);
         this.appendTab("timing", WebInspector.UIString("Timing"), timingView);
     }
-
+    this._request = request;
 }
 
 WebInspector.NetworkItemView.prototype = {
@@ -92,6 +92,14 @@
     {
         if (event.data.isUserGesture)
             WebInspector.settings.resourceViewTab.set(event.data.tabId);
+    },
+
+    /**
+      * @return {WebInspector.NetworkRequest}
+      */
+    request: function()
+    {
+        return this._request;
     }
 }
 

Modified: trunk/Source/WebCore/inspector/front-end/NetworkPanel.js (122978 => 122979)


--- trunk/Source/WebCore/inspector/front-end/NetworkPanel.js	2012-07-18 15:42:40 UTC (rev 122978)
+++ trunk/Source/WebCore/inspector/front-end/NetworkPanel.js	2012-07-18 16:10:35 UTC (rev 122979)
@@ -1447,6 +1447,8 @@
     {
         if (!(target instanceof WebInspector.NetworkRequest))
             return;
+        if (this.visibleView && this.visibleView.isShowing() && this.visibleView.request() === target)
+            return;
 
         function reveal()
         {
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to