Title: [123160] trunk/Source/WebKit/chromium
- Revision
- 123160
- Author
- [email protected]
- Date
- 2012-07-19 16:27:36 -0700 (Thu, 19 Jul 2012)
Log Message
[Chromium] Support external autofill popups
https://bugs.webkit.org/show_bug.cgi?id=91651
Reviewed by Darin Fisher.
This looks like the last piece needed to support external autofill
popups. This function just lets the embedder select an index
(presumably because the user picked an index from the external autofill
popup).
* public/WebView.h:
(WebView):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::selectAutofillSuggestionAtIndex):
(WebKit):
* src/WebViewImpl.h:
(WebViewImpl):
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (123159 => 123160)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-07-19 23:10:50 UTC (rev 123159)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-07-19 23:27:36 UTC (rev 123160)
@@ -1,3 +1,23 @@
+2012-07-19 Adam Barth <[email protected]>
+
+ [Chromium] Support external autofill popups
+ https://bugs.webkit.org/show_bug.cgi?id=91651
+
+ Reviewed by Darin Fisher.
+
+ This looks like the last piece needed to support external autofill
+ popups. This function just lets the embedder select an index
+ (presumably because the user picked an index from the external autofill
+ popup).
+
+ * public/WebView.h:
+ (WebView):
+ * src/WebViewImpl.cpp:
+ (WebKit::WebViewImpl::selectAutofillSuggestionAtIndex):
+ (WebKit):
+ * src/WebViewImpl.h:
+ (WebViewImpl):
+
2012-07-19 Zeev Lieber <[email protected]>
[Chromium] Textures drawn during occlusion are incorrectly re-used when unoccluded.
Modified: trunk/Source/WebKit/chromium/public/WebView.h (123159 => 123160)
--- trunk/Source/WebKit/chromium/public/WebView.h 2012-07-19 23:10:50 UTC (rev 123159)
+++ trunk/Source/WebKit/chromium/public/WebView.h 2012-07-19 23:27:36 UTC (rev 123160)
@@ -382,7 +382,9 @@
// Hides any popup (suggestions, selects...) that might be showing.
virtual void hidePopups() = 0;
+ virtual void selectAutofillSuggestionAtIndex(unsigned listIndex) = 0;
+
// Context menu --------------------------------------------------------
virtual void performCustomContextMenuAction(unsigned action) = 0;
Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (123159 => 123160)
--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2012-07-19 23:10:50 UTC (rev 123159)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2012-07-19 23:27:36 UTC (rev 123160)
@@ -3716,6 +3716,12 @@
return GraphicsContext3DPrivate::extractWebGraphicsContext3D(SharedGraphicsContext3D::get().get());
}
+void WebViewImpl::selectAutofillSuggestionAtIndex(unsigned listIndex)
+{
+ if (m_autofillPopupClient && listIndex < m_autofillPopupClient->getSuggestionsCount())
+ m_autofillPopupClient->valueChanged(listIndex);
+}
+
void WebViewImpl::setVisibilityState(WebPageVisibilityState visibilityState,
bool isInitialState) {
if (!page())
Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.h (123159 => 123160)
--- trunk/Source/WebKit/chromium/src/WebViewImpl.h 2012-07-19 23:10:50 UTC (rev 123159)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.h 2012-07-19 23:27:36 UTC (rev 123160)
@@ -278,6 +278,7 @@
const WebVector<int>& itemIDs,
int separatorIndex);
virtual void hidePopups();
+ virtual void selectAutofillSuggestionAtIndex(unsigned listIndex);
virtual void setScrollbarColors(unsigned inactiveColor,
unsigned activeColor,
unsigned trackColor);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
