Title: [123179] trunk/Source/WebKit/blackberry
Revision
123179
Author
[email protected]
Date
2012-07-19 22:33:33 -0700 (Thu, 19 Jul 2012)

Log Message

[BlackBerry] Make sure to send favicon when go back/forward
https://bugs.webkit.org/show_bug.cgi?id=91808

Reviewed by George Staikos.

When go back/forward, if the page was in page cache, it would have no chance
to send favicon. So we'll send it in commitLoad right after send the blank
icon.
RIM PR# 177495

* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDidCommitLoad):

Modified Paths

Diff

Modified: trunk/Source/WebKit/blackberry/ChangeLog (123178 => 123179)


--- trunk/Source/WebKit/blackberry/ChangeLog	2012-07-20 04:48:17 UTC (rev 123178)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2012-07-20 05:33:33 UTC (rev 123179)
@@ -1,3 +1,18 @@
+2012-07-19  Mary Wu  <[email protected]>
+
+        [BlackBerry] Make sure to send favicon when go back/forward
+        https://bugs.webkit.org/show_bug.cgi?id=91808
+
+        Reviewed by George Staikos.
+
+        When go back/forward, if the page was in page cache, it would have no chance
+        to send favicon. So we'll send it in commitLoad right after send the blank
+        icon.
+        RIM PR# 177495
+
+        * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
+        (WebCore::FrameLoaderClientBlackBerry::dispatchDidCommitLoad):
+
 2012-07-19  Jakob Petsovits  <[email protected]>
 
         [BlackBerry] Suspend when there's no target buffer until an external compositor is set

Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp (123178 => 123179)


--- trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp	2012-07-20 04:48:17 UTC (rev 123178)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp	2012-07-20 05:33:33 UTC (rev 123179)
@@ -530,6 +530,9 @@
             m_webPagePrivate->m_client->notifyLoadCommitted(
                 originalUrl.characters(), originalUrl.length(),
                     url.characters(), url.length(), token.characters(), token.length());
+            HistoryItem* currentItem = m_frame->loader()->history()->currentItem();
+            if (currentItem && currentItem->isInPageCache())
+                dispatchDidReceiveIcon();
         }
     }
 
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to