Diff
Modified: trunk/Source/WebCore/ChangeLog (123238 => 123239)
--- trunk/Source/WebCore/ChangeLog 2012-07-20 18:10:42 UTC (rev 123238)
+++ trunk/Source/WebCore/ChangeLog 2012-07-20 18:11:10 UTC (rev 123239)
@@ -1,3 +1,40 @@
+2012-07-20 Nico Weber <[email protected]>
+
+ Fix more -Wunused-private-field violations
+ https://bugs.webkit.org/show_bug.cgi?id=91876
+
+ Reviewed by Adam Barth.
+
+ As of http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20120716/061102.html
+ the warning finds more bugs. Fix them.
+
+ * html/FTPDirectoryDocument.cpp:
+ (FTPDirectoryDocumentParser):
+ (WebCore::FTPDirectoryDocumentParser::FTPDirectoryDocumentParser):
+ * html/parser/HTMLTreeBuilder.cpp:
+ (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
+ * html/parser/HTMLTreeBuilder.h:
+ (HTMLTreeBuilder):
+ * html/shadow/MediaControlRootElementChromium.cpp:
+ (WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
+ * html/shadow/MediaControlRootElementChromium.h:
+ (MediaControlRootElementChromium):
+ * inspector/InspectorDOMStorageResource.cpp:
+ (WebCore::InspectorDOMStorageResource::InspectorDOMStorageResource):
+ * inspector/InspectorDOMStorageResource.h:
+ (InspectorDOMStorageResource):
+ * page/Settings.cpp:
+ (WebCore::Settings::Settings):
+ * page/Settings.h:
+ (Settings):
+ * platform/graphics/chromium/cc/CCThreadProxy.cpp:
+ (WebCore::CCThreadProxy::CCThreadProxy):
+ * platform/graphics/chromium/cc/CCThreadProxy.h:
+ (CCThreadProxy):
+ * rendering/svg/RenderSVGTextPath.cpp:
+ (WebCore::RenderSVGTextPath::RenderSVGTextPath):
+ * rendering/svg/RenderSVGTextPath.h:
+
2012-07-20 Adam Klein <[email protected]>
CodeGeneratorInspector.py is unnecessarily chatty
Modified: trunk/Source/WebCore/html/FTPDirectoryDocument.cpp (123238 => 123239)
--- trunk/Source/WebCore/html/FTPDirectoryDocument.cpp 2012-07-20 18:10:42 UTC (rev 123238)
+++ trunk/Source/WebCore/html/FTPDirectoryDocument.cpp 2012-07-20 18:11:10 UTC (rev 123239)
@@ -88,7 +88,6 @@
RefPtr<HTMLTableElement> m_tableElement;
bool m_skipLF;
- bool m_parsedTemplate;
int m_size;
UChar* m_buffer;
@@ -101,7 +100,6 @@
FTPDirectoryDocumentParser::FTPDirectoryDocumentParser(HTMLDocument* document)
: HTMLDocumentParser(document, false)
, m_skipLF(false)
- , m_parsedTemplate(false)
, m_size(254)
, m_buffer(static_cast<UChar*>(fastMalloc(sizeof(UChar) * m_size)))
, m_dest(m_buffer)
Modified: trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp (123238 => 123239)
--- trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp 2012-07-20 18:10:42 UTC (rev 123238)
+++ trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp 2012-07-20 18:11:10 UTC (rev 123239)
@@ -346,11 +346,10 @@
};
-HTMLTreeBuilder::HTMLTreeBuilder(HTMLDocumentParser* parser, HTMLDocument* document, bool reportErrors, bool usePreHTML5ParserQuirks, unsigned maximumDOMTreeDepth)
+HTMLTreeBuilder::HTMLTreeBuilder(HTMLDocumentParser* parser, HTMLDocument* document, bool, bool usePreHTML5ParserQuirks, unsigned maximumDOMTreeDepth)
: m_framesetOk(true)
, m_document(document)
, m_tree(document, maximumDOMTreeDepth)
- , m_reportErrors(reportErrors)
, m_insertionMode(InitialMode)
, m_originalInsertionMode(InitialMode)
, m_shouldSkipLeadingNewline(false)
@@ -367,7 +366,6 @@
, m_fragmentContext(fragment, contextElement, scriptingPermission)
, m_document(fragment->document())
, m_tree(fragment, scriptingPermission, maximumDOMTreeDepth)
- , m_reportErrors(false) // FIXME: Why not report errors in fragments?
, m_insertionMode(InitialMode)
, m_originalInsertionMode(InitialMode)
, m_shouldSkipLeadingNewline(false)
Modified: trunk/Source/WebCore/html/parser/HTMLTreeBuilder.h (123238 => 123239)
--- trunk/Source/WebCore/html/parser/HTMLTreeBuilder.h 2012-07-20 18:10:42 UTC (rev 123238)
+++ trunk/Source/WebCore/html/parser/HTMLTreeBuilder.h 2012-07-20 18:11:10 UTC (rev 123239)
@@ -213,8 +213,6 @@
Document* m_document;
HTMLConstructionSite m_tree;
- bool m_reportErrors;
-
// http://www.whatwg.org/specs/web-apps/current-work/multipage/parsing.html#insertion-mode
InsertionMode m_insertionMode;
Modified: trunk/Source/WebCore/html/shadow/MediaControlRootElementChromium.cpp (123238 => 123239)
--- trunk/Source/WebCore/html/shadow/MediaControlRootElementChromium.cpp 2012-07-20 18:10:42 UTC (rev 123238)
+++ trunk/Source/WebCore/html/shadow/MediaControlRootElementChromium.cpp 2012-07-20 18:11:10 UTC (rev 123239)
@@ -80,7 +80,6 @@
#if ENABLE(VIDEO_TRACK)
, m_textDisplayContainer(0)
#endif
- , m_opaque(true)
, m_hideFullscreenControlsTimer(this, &MediaControlRootElementChromium::hideFullscreenControlsTimerFired)
, m_isMouseOverControls(false)
, m_isFullscreen(false)
Modified: trunk/Source/WebCore/html/shadow/MediaControlRootElementChromium.h (123238 => 123239)
--- trunk/Source/WebCore/html/shadow/MediaControlRootElementChromium.h 2012-07-20 18:10:42 UTC (rev 123238)
+++ trunk/Source/WebCore/html/shadow/MediaControlRootElementChromium.h 2012-07-20 18:11:10 UTC (rev 123239)
@@ -149,7 +149,6 @@
MediaControlTextTrackContainerElement* m_textDisplayContainer;
#endif
- bool m_opaque;
Timer<MediaControlRootElementChromium> m_hideFullscreenControlsTimer;
bool m_isMouseOverControls;
bool m_isFullscreen;
Modified: trunk/Source/WebCore/inspector/InspectorDOMStorageResource.cpp (123238 => 123239)
--- trunk/Source/WebCore/inspector/InspectorDOMStorageResource.cpp 2012-07-20 18:10:42 UTC (rev 123238)
+++ trunk/Source/WebCore/inspector/InspectorDOMStorageResource.cpp 2012-07-20 18:11:10 UTC (rev 123239)
@@ -57,7 +57,6 @@
, m_frame(frame)
, m_frontend(0)
, m_id(String::number(s_nextUnusedId++))
- , m_reportingChangesToFrontend(false)
{
}
Modified: trunk/Source/WebCore/inspector/InspectorDOMStorageResource.h (123238 => 123239)
--- trunk/Source/WebCore/inspector/InspectorDOMStorageResource.h 2012-07-20 18:10:42 UTC (rev 123238)
+++ trunk/Source/WebCore/inspector/InspectorDOMStorageResource.h 2012-07-20 18:11:10 UTC (rev 123239)
@@ -66,7 +66,6 @@
RefPtr<Frame> m_frame;
InspectorFrontend::DOMStorage* m_frontend;
String m_id;
- bool m_reportingChangesToFrontend;
static int s_nextUnusedId;
};
Modified: trunk/Source/WebCore/page/Settings.cpp (123238 => 123239)
--- trunk/Source/WebCore/page/Settings.cpp 2012-07-20 18:10:42 UTC (rev 123238)
+++ trunk/Source/WebCore/page/Settings.cpp 2012-07-20 18:11:10 UTC (rev 123239)
@@ -185,7 +185,9 @@
, m_needsSiteSpecificQuirks(false)
, m_fontRenderingMode(0)
, m_frameFlatteningEnabled(false)
+#if ENABLE(WEB_ARCHIVE)
, m_webArchiveDebugModeEnabled(false)
+#endif
, m_localFileContentSniffingEnabled(false)
, m_inApplicationChromeMode(false)
, m_offlineWebApplicationCacheEnabled(false)
Modified: trunk/Source/WebCore/page/Settings.h (123238 => 123239)
--- trunk/Source/WebCore/page/Settings.h 2012-07-20 18:10:42 UTC (rev 123238)
+++ trunk/Source/WebCore/page/Settings.h 2012-07-20 18:11:10 UTC (rev 123239)
@@ -680,7 +680,9 @@
bool m_needsSiteSpecificQuirks : 1;
unsigned m_fontRenderingMode : 1;
bool m_frameFlatteningEnabled : 1;
+#if ENABLE(WEB_ARCHIVE)
bool m_webArchiveDebugModeEnabled : 1;
+#endif
bool m_localFileContentSniffingEnabled : 1;
bool m_inApplicationChromeMode : 1;
bool m_offlineWebApplicationCacheEnabled : 1;
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp (123238 => 123239)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp 2012-07-20 18:10:42 UTC (rev 123238)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp 2012-07-20 18:11:10 UTC (rev 123239)
@@ -75,7 +75,6 @@
: m_animateRequested(false)
, m_commitRequested(false)
, m_forcedCommitRequested(false)
- , m_contextLost(false)
, m_layerTreeHost(layerTreeHost)
, m_compositorIdentifier(-1)
, m_layerRendererInitialized(false)
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.h (123238 => 123239)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.h 2012-07-20 18:10:42 UTC (rev 123238)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.h 2012-07-20 18:11:10 UTC (rev 123239)
@@ -152,7 +152,6 @@
bool m_animateRequested;
bool m_commitRequested;
bool m_forcedCommitRequested;
- bool m_contextLost;
OwnPtr<CCThreadProxyContextRecreationTimer> m_contextRecreationTimer;
CCLayerTreeHost* m_layerTreeHost;
int m_compositorIdentifier;
Modified: trunk/Source/WebCore/rendering/svg/RenderSVGTextPath.cpp (123238 => 123239)
--- trunk/Source/WebCore/rendering/svg/RenderSVGTextPath.cpp 2012-07-20 18:10:42 UTC (rev 123238)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGTextPath.cpp 2012-07-20 18:11:10 UTC (rev 123239)
@@ -36,8 +36,6 @@
RenderSVGTextPath::RenderSVGTextPath(Node* n)
: RenderSVGInline(n)
- , m_exactAlignment(true)
- , m_stretchMethod(false)
{
}
Modified: trunk/Source/WebCore/rendering/svg/RenderSVGTextPath.h (123238 => 123239)
--- trunk/Source/WebCore/rendering/svg/RenderSVGTextPath.h 2012-07-20 18:10:42 UTC (rev 123238)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGTextPath.h 2012-07-20 18:11:10 UTC (rev 123239)
@@ -40,9 +40,6 @@
private:
virtual const char* renderName() const { return "RenderSVGTextPath"; }
- bool m_exactAlignment : 1;
- bool m_stretchMethod : 1;
-
Path m_layoutPath;
};
