Title: [123265] trunk/Source/WebCore
- Revision
- 123265
- Author
- [email protected]
- Date
- 2012-07-20 14:41:14 -0700 (Fri, 20 Jul 2012)
Log Message
[Soup] Unnecessary RefPtr usage and null check
https://bugs.webkit.org/show_bug.cgi?id=91636
Patch by Gustavo Noronha Silva <[email protected]> on 2012-07-18
Reviewed by Martin Robinson.
Small clean up of code that is not necessary; no change in functionality.
* platform/network/soup/SocketStreamHandleSoup.cpp:
(WebCore::SocketStreamHandle::connected):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (123264 => 123265)
--- trunk/Source/WebCore/ChangeLog 2012-07-20 21:40:24 UTC (rev 123264)
+++ trunk/Source/WebCore/ChangeLog 2012-07-20 21:41:14 UTC (rev 123265)
@@ -1,3 +1,15 @@
+2012-07-18 Gustavo Noronha Silva <[email protected]>
+
+ [Soup] Unnecessary RefPtr usage and null check
+ https://bugs.webkit.org/show_bug.cgi?id=91636
+
+ Reviewed by Martin Robinson.
+
+ Small clean up of code that is not necessary; no change in functionality.
+
+ * platform/network/soup/SocketStreamHandleSoup.cpp:
+ (WebCore::SocketStreamHandle::connected):
+
2012-07-20 Mark Salisbury <[email protected]>
Typo in FontCacheWin.cpp causes return value from getCachedFontData() in getLastResortFallbackFont() to be ignored
Modified: trunk/Source/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp (123264 => 123265)
--- trunk/Source/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp 2012-07-20 21:40:24 UTC (rev 123264)
+++ trunk/Source/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp 2012-07-20 21:41:14 UTC (rev 123265)
@@ -116,12 +116,8 @@
g_input_stream_read_async(m_inputStream.get(), m_readBuffer, READ_BUFFER_SIZE, G_PRIORITY_DEFAULT, 0,
reinterpret_cast<GAsyncReadyCallback>(readReadyCallback), m_id);
- // The client can close the handle, potentially removing the last reference.
- RefPtr<SocketStreamHandle> protect(this);
m_state = Open;
m_client->didOpenSocketStream(this);
- if (!m_socketConnection) // Client closed the connection.
- return;
}
void SocketStreamHandle::readBytes(signed long bytesRead, GError* error)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes