Title: [123328] trunk/Source/WebCore
- Revision
- 123328
- Author
- [email protected]
- Date
- 2012-07-23 04:18:20 -0700 (Mon, 23 Jul 2012)
Log Message
[WK2] REGRESSION r122966: Crash when closing tab with Web Inspector open in WebKit::PageOverlay
https://bugs.webkit.org/show_bug.cgi?id=91782
Reviewed by Yury Semikhatsky.
hideHighlight was never called once user hovered over a node.
* inspector/DOMNodeHighlighter.cpp:
(WebCore::InspectorOverlay::update):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (123327 => 123328)
--- trunk/Source/WebCore/ChangeLog 2012-07-23 11:07:58 UTC (rev 123327)
+++ trunk/Source/WebCore/ChangeLog 2012-07-23 11:18:20 UTC (rev 123328)
@@ -1,3 +1,15 @@
+2012-07-23 Pavel Feldman <[email protected]>
+
+ [WK2] REGRESSION r122966: Crash when closing tab with Web Inspector open in WebKit::PageOverlay
+ https://bugs.webkit.org/show_bug.cgi?id=91782
+
+ Reviewed by Yury Semikhatsky.
+
+ hideHighlight was never called once user hovered over a node.
+
+ * inspector/DOMNodeHighlighter.cpp:
+ (WebCore::InspectorOverlay::update):
+
2012-07-23 Peter Beverloo <[email protected]>
[Chromium] Build fix for the Windows builder following r123311
Modified: trunk/Source/WebCore/inspector/DOMNodeHighlighter.cpp (123327 => 123328)
--- trunk/Source/WebCore/inspector/DOMNodeHighlighter.cpp 2012-07-23 11:07:58 UTC (rev 123327)
+++ trunk/Source/WebCore/inspector/DOMNodeHighlighter.cpp 2012-07-23 11:18:20 UTC (rev 123328)
@@ -563,7 +563,8 @@
void InspectorOverlay::update()
{
- if (m_highlightData || !m_pausedInDebuggerMessage.isNull())
+ // FIXME(91926) Refactor highlightNode to pass highlight data along with the call.
+ if ((m_highlightData && (m_highlightData->rect || m_highlightData->node)) || !m_pausedInDebuggerMessage.isNull())
m_client->highlight();
else
m_client->hideHighlight();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
