Title: [123357] branches/chromium/1180/Source/WebCore/inspector/front-end
- Revision
- 123357
- Author
- [email protected]
- Date
- 2012-07-23 11:54:18 -0700 (Mon, 23 Jul 2012)
Log Message
Merge 122979 - Web Inspector: [Regression] Save as file is missing in Network panel preview/response tabs.
https://bugs.webkit.org/show_bug.cgi?id=91625
Reviewed by Vsevolod Vlasov.
* inspector/front-end/HandlerRegistry.js:
* inspector/front-end/NetworkPanel.js:
[email protected]
BUG=137863
Review URL: https://chromiumcodereview.appspot.com/10796093
Modified Paths
Diff
Modified: branches/chromium/1180/Source/WebCore/inspector/front-end/HandlerRegistry.js (123356 => 123357)
--- branches/chromium/1180/Source/WebCore/inspector/front-end/HandlerRegistry.js 2012-07-23 18:48:42 UTC (rev 123356)
+++ branches/chromium/1180/Source/WebCore/inspector/front-end/HandlerRegistry.js 2012-07-23 18:54:18 UTC (rev 123357)
@@ -96,7 +96,7 @@
*/
appendApplicableItems: function(contextMenu, target)
{
- if (!(target instanceof WebInspector.UISourceCode || target instanceof WebInspector.Resource))
+ if (!(target instanceof WebInspector.UISourceCode || target instanceof WebInspector.Resource || target instanceof WebInspector.NetworkRequest))
return;
var contentProvider = /** @type {WebInspector.ContentProvider} */ target;
if (!contentProvider.contentURL())
Modified: branches/chromium/1180/Source/WebCore/inspector/front-end/NetworkItemView.js (123356 => 123357)
--- branches/chromium/1180/Source/WebCore/inspector/front-end/NetworkItemView.js 2012-07-23 18:48:42 UTC (rev 123356)
+++ branches/chromium/1180/Source/WebCore/inspector/front-end/NetworkItemView.js 2012-07-23 18:54:18 UTC (rev 123357)
@@ -56,7 +56,7 @@
var timingView = new WebInspector.RequestTimingView(request);
this.appendTab("timing", WebInspector.UIString("Timing"), timingView);
}
-
+ this._request = request;
if (request.frames().length > 0) {
var frameView = new WebInspector.ResourceWebSocketFrameView(request);
this.appendTab("webSocketFrames", WebInspector.UIString("WebSocket Frames"), frameView);
@@ -91,6 +91,14 @@
{
if (event.data.isUserGesture)
WebInspector.settings.resourceViewTab.set(event.data.tabId);
+ },
+
+ /**
+ * @return {WebInspector.NetworkRequest}
+ */
+ request: function()
+ {
+ return this._request;
}
}
Modified: branches/chromium/1180/Source/WebCore/inspector/front-end/NetworkPanel.js (123356 => 123357)
--- branches/chromium/1180/Source/WebCore/inspector/front-end/NetworkPanel.js 2012-07-23 18:48:42 UTC (rev 123356)
+++ branches/chromium/1180/Source/WebCore/inspector/front-end/NetworkPanel.js 2012-07-23 18:54:18 UTC (rev 123357)
@@ -1449,6 +1449,8 @@
{
if (!(target instanceof WebInspector.NetworkRequest))
return;
+ if (this.visibleView && this.visibleView.isShowing() && this.visibleView.request() === target)
+ return;
function reveal()
{
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
