Title: [123501] branches/chromium/1180/Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzFaceCoreText.cpp
Revision
123501
Author
kar...@chromium.org
Date
2012-07-24 11:43:05 -0700 (Tue, 24 Jul 2012)

Log Message

Merge 121510 - [Chromium] CTFontCopyTable of MacOSX10.5 SDK doesn't work for layout tables
https://bugs.webkit.org/show_bug.cgi?id=90235

Reviewed by Kent Tamura.

Use CGFontCopyTableForTag instead.

No new tests. css3/font-feature-settings-rendering.html should pass. I'll rebase expectations once bots get the result.

* platform/graphics/harfbuzz/ng/HarfBuzzFaceCoreText.cpp:
(WebCore::harfbuzzCoreTextGetTable):


TBR=ba...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10815078

Modified Paths

Diff

Modified: branches/chromium/1180/Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzFaceCoreText.cpp (123500 => 123501)


--- branches/chromium/1180/Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzFaceCoreText.cpp	2012-07-24 18:42:54 UTC (rev 123500)
+++ branches/chromium/1180/Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzFaceCoreText.cpp	2012-07-24 18:43:05 UTC (rev 123501)
@@ -109,8 +109,10 @@
 static hb_blob_t* harfbuzzCoreTextGetTable(hb_face_t* face, hb_tag_t tag, void* userData)
 {
     FontPlatformData* platformData = reinterpret_cast<FontPlatformData*>(userData);
-    CTFontRef ctFont = platformData->ctFont();
-    CFDataRef cfData = CTFontCopyTable(ctFont, tag, kCTFontTableOptionNoOptions);
+    // It seems that CTFontCopyTable of MacOSX10.5 sdk doesn't work for
+    // OpenType layout tables(GDEF, GSUB, GPOS). Use CGFontCopyTableForTag instead.
+    CGFontRef cgFont = platformData->cgFont();
+    CFDataRef cfData = CGFontCopyTableForTag(cgFont, tag);
     if (!cfData)
         return 0;
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to