Title: [123507] trunk/Tools
- Revision
- 123507
- Author
- pe...@chromium.org
- Date
- 2012-07-24 12:40:26 -0700 (Tue, 24 Jul 2012)
Log Message
Android-chromium layout tests failing with GPU related crash
https://bugs.webkit.org/show_bug.cgi?id=92126
Reviewed by Adam Barth.
Remove support for the "--enable-hardware-gpu" flag from run_webkit_tests,
as it's not being used by any port anymore, and neither is being passed
on to the test runner. Instead, append the flag directly to DRT for the
Chromium Android port, which does rely on this functionality.
The ChromiumAndroidUnitTest tests didn't catch this as the property was
set to True, but it's unable to detect whether they'll actually be used.
No occurrances of "--enable-hardware-gpu" exist in either Tools/Scripts/
or Tools/BuildSlaveSupport/, so nothing upstream seems to rely on the flag.
* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.__init__):
* Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
(ChromiumAndroidPortTest.test_attributes):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (123506 => 123507)
--- trunk/Tools/ChangeLog 2012-07-24 19:32:52 UTC (rev 123506)
+++ trunk/Tools/ChangeLog 2012-07-24 19:40:26 UTC (rev 123507)
@@ -1,3 +1,27 @@
+2012-07-24 Peter Beverloo <pe...@chromium.org>
+
+ Android-chromium layout tests failing with GPU related crash
+ https://bugs.webkit.org/show_bug.cgi?id=92126
+
+ Reviewed by Adam Barth.
+
+ Remove support for the "--enable-hardware-gpu" flag from run_webkit_tests,
+ as it's not being used by any port anymore, and neither is being passed
+ on to the test runner. Instead, append the flag directly to DRT for the
+ Chromium Android port, which does rely on this functionality.
+
+ The ChromiumAndroidUnitTest tests didn't catch this as the property was
+ set to True, but it's unable to detect whether they'll actually be used.
+ No occurrances of "--enable-hardware-gpu" exist in either Tools/Scripts/
+ or Tools/BuildSlaveSupport/, so nothing upstream seems to rely on the flag.
+
+ * Scripts/webkitpy/layout_tests/port/chromium_android.py:
+ (ChromiumAndroidPort.__init__):
+ * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
+ (ChromiumAndroidPortTest.test_attributes):
+ * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
+ (parse_args):
+
2012-07-24 Alexander Shalamov <alexander.shala...@intel.com>
[WTR][EFL] Multiple mouse clicks are not emitted in EventSenderProxyEfl
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py (123506 => 123507)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py 2012-07-24 19:32:52 UTC (rev 123506)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py 2012-07-24 19:40:26 UTC (rev 123507)
@@ -161,7 +161,7 @@
self._options.additional_drt_flag.append('--encode-binary')
# The Chromium port for Android always uses the hardware GPU path.
- self._options.enable_hardware_gpu = True
+ self._options.additional_drt_flag.append('--enable-hardware-gpu')
# Shard ref tests so that they run together to avoid repeatedly driver restarts.
self._options.shard_ref_tests = True
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py (123506 => 123507)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py 2012-07-24 19:32:52 UTC (rev 123506)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py 2012-07-24 19:40:26 UTC (rev 123507)
@@ -48,7 +48,6 @@
def test_attributes(self):
port = self.make_port()
- self.assertTrue(port.get_option('enable_hardware_gpu'))
self.assertEquals(port.baseline_path(), port._webkit_baseline_path('chromium-android'))
def test_default_timeout_ms(self):
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py (123506 => 123507)
--- trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py 2012-07-24 19:32:52 UTC (rev 123506)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py 2012-07-24 19:40:26 UTC (rev 123507)
@@ -246,10 +246,6 @@
action=""
default=False,
help="Use hardware accelerated painting of composited pages"),
- optparse.make_option("--enable-hardware-gpu",
- action=""
- default=False,
- help="Run graphics tests on real GPU hardware vs software"),
optparse.make_option("--per-tile-painting",
action=""
help="Use per-tile painting of composited pages"),
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
