Title: [123565] trunk/Source/WebCore
Revision
123565
Author
[email protected]
Date
2012-07-24 19:08:38 -0700 (Tue, 24 Jul 2012)

Log Message

Rename FocusScope to FocusNavigationScope.
https://bugs.webkit.org/show_bug.cgi?id=92062

Reviewed by Dimitri Glazkov.

FocusNavagationScope is better name than FocusScope since the
class is only used for controlling focus navigation.

No new tests - no functional changes.

* page/FocusController.cpp:
(WebCore::FocusNavigationScope::FocusNavigationScope):
(WebCore::FocusNavigationScope::rootNode):
(WebCore::FocusNavigationScope::owner):
(WebCore::FocusNavigationScope::focusNavigationScopeOf):
(WebCore::FocusNavigationScope::focusNavigationScopeOwnedByShadowHost):
(WebCore::FocusNavigationScope::focusNavigationScopeOwnedByIFrame):
(WebCore::FocusController::findFocusableNodeDecendingDownIntoFrameDocument):
(WebCore::FocusController::advanceFocusInDocumentOrder):
(WebCore::FocusController::findFocusableNodeAcrossFocusScope):
(WebCore::FocusController::findFocusableNodeRecursively):
(WebCore::FocusController::findFocusableNode):
(WebCore::FocusController::nextFocusableNode):
(WebCore::FocusController::previousFocusableNode):
* page/FocusController.h:
(FocusNavigationScope):
(FocusController):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (123564 => 123565)


--- trunk/Source/WebCore/ChangeLog	2012-07-25 01:57:08 UTC (rev 123564)
+++ trunk/Source/WebCore/ChangeLog	2012-07-25 02:08:38 UTC (rev 123565)
@@ -1,3 +1,33 @@
+2012-07-24  Hayato Ito  <[email protected]>
+
+        Rename FocusScope to FocusNavigationScope.
+        https://bugs.webkit.org/show_bug.cgi?id=92062
+
+        Reviewed by Dimitri Glazkov.
+
+        FocusNavagationScope is better name than FocusScope since the
+        class is only used for controlling focus navigation.
+
+        No new tests - no functional changes.
+
+        * page/FocusController.cpp:
+        (WebCore::FocusNavigationScope::FocusNavigationScope):
+        (WebCore::FocusNavigationScope::rootNode):
+        (WebCore::FocusNavigationScope::owner):
+        (WebCore::FocusNavigationScope::focusNavigationScopeOf):
+        (WebCore::FocusNavigationScope::focusNavigationScopeOwnedByShadowHost):
+        (WebCore::FocusNavigationScope::focusNavigationScopeOwnedByIFrame):
+        (WebCore::FocusController::findFocusableNodeDecendingDownIntoFrameDocument):
+        (WebCore::FocusController::advanceFocusInDocumentOrder):
+        (WebCore::FocusController::findFocusableNodeAcrossFocusScope):
+        (WebCore::FocusController::findFocusableNodeRecursively):
+        (WebCore::FocusController::findFocusableNode):
+        (WebCore::FocusController::nextFocusableNode):
+        (WebCore::FocusController::previousFocusableNode):
+        * page/FocusController.h:
+        (FocusNavigationScope):
+        (FocusController):
+
 2012-07-24  Michael Saboff  <[email protected]>
 
         Convert HTML parser to handle 8-bit resources without converting to UChar*

Modified: trunk/Source/WebCore/page/FocusController.cpp (123564 => 123565)


--- trunk/Source/WebCore/page/FocusController.cpp	2012-07-25 01:57:08 UTC (rev 123564)
+++ trunk/Source/WebCore/page/FocusController.cpp	2012-07-25 02:08:38 UTC (rev 123565)
@@ -94,19 +94,19 @@
     return walkerFromPrevious(node).get();
 }
 
-FocusScope::FocusScope(TreeScope* treeScope)
+FocusNavigationScope::FocusNavigationScope(TreeScope* treeScope)
     : m_rootTreeScope(treeScope)
 {
     ASSERT(treeScope);
     ASSERT(!treeScope->rootNode()->isShadowRoot() || toShadowRoot(treeScope->rootNode())->isYoungest());
 }
 
-Node* FocusScope::rootNode() const
+Node* FocusNavigationScope::rootNode() const
 {
     return m_rootTreeScope->rootNode();
 }
 
-Element* FocusScope::owner() const
+Element* FocusNavigationScope::owner() const
 {
     Node* root = rootNode();
     if (root->isShadowRoot())
@@ -116,7 +116,7 @@
     return 0;
 }
 
-FocusScope FocusScope::focusScopeOf(Node* node)
+FocusNavigationScope FocusNavigationScope::focusNavigationScopeOf(Node* node)
 {
     ASSERT(node);
     ComposedShadowTreeWalker walker(node, ComposedShadowTreeWalker::DoNotCrossUpperBoundary);
@@ -127,19 +127,19 @@
     }
     // The result is not always a ShadowRoot nor a DocumentNode since
     // a starting node is in an orphaned tree in composed shadow tree.
-    return FocusScope(root->treeScope());
+    return FocusNavigationScope(root->treeScope());
 }
 
-FocusScope FocusScope::focusScopeOwnedByShadowHost(Node* node)
+FocusNavigationScope FocusNavigationScope::focusNavigationScopeOwnedByShadowHost(Node* node)
 {
     ASSERT(isShadowHost(node));
-    return FocusScope(toElement(node)->shadow()->youngestShadowRoot());
+    return FocusNavigationScope(toElement(node)->shadow()->youngestShadowRoot());
 }
 
-FocusScope FocusScope::focusScopeOwnedByIFrame(HTMLFrameOwnerElement* frame)
+FocusNavigationScope FocusNavigationScope::focusNavigationScopeOwnedByIFrame(HTMLFrameOwnerElement* frame)
 {
     ASSERT(frame && frame->contentFrame());
-    return FocusScope(frame->contentFrame()->document());
+    return FocusNavigationScope(frame->contentFrame()->document());
 }
 
 static inline void dispatchEventsOnWindowAndFocusedNode(Document* document, bool focused)
@@ -268,7 +268,7 @@
         HTMLFrameOwnerElement* owner = static_cast<HTMLFrameOwnerElement*>(node);
         if (!owner->contentFrame())
             break;
-        Node* foundNode = findFocusableNode(direction, FocusScope::focusScopeOwnedByIFrame(owner), 0, event);
+        Node* foundNode = findFocusableNode(direction, FocusNavigationScope::focusNavigationScopeOwnedByIFrame(owner), 0, event);
         if (!foundNode)
             break;
         ASSERT(node != foundNode);
@@ -323,7 +323,7 @@
 
     document->updateLayoutIgnorePendingStylesheets();
 
-    RefPtr<Node> node = findFocusableNodeAcrossFocusScope(direction, FocusScope::focusScopeOf(currentNode ? currentNode : document), currentNode, event);
+    RefPtr<Node> node = findFocusableNodeAcrossFocusScope(direction, FocusNavigationScope::focusNavigationScopeOf(currentNode ? currentNode : document), currentNode, event);
 
     if (!node) {
         // We didn't find a node to focus, so we should try to pass focus to Chrome.
@@ -335,7 +335,7 @@
         }
 
         // Chrome doesn't want focus, so we should wrap focus.
-        node = findFocusableNodeRecursively(direction, FocusScope::focusScopeOf(m_page->mainFrame()->document()), 0, event);
+        node = findFocusableNodeRecursively(direction, FocusNavigationScope::focusNavigationScopeOf(m_page->mainFrame()->document()), 0, event);
         node = findFocusableNodeDecendingDownIntoFrameDocument(direction, node.get(), event);
 
         if (!node)
@@ -388,12 +388,12 @@
     return true;
 }
 
-Node* FocusController::findFocusableNodeAcrossFocusScope(FocusDirection direction, FocusScope scope, Node* currentNode, KeyboardEvent* event)
+Node* FocusController::findFocusableNodeAcrossFocusScope(FocusDirection direction, FocusNavigationScope scope, Node* currentNode, KeyboardEvent* event)
 {
     ASSERT(!currentNode || !isNonFocusableShadowHost(currentNode, event));
     Node* found;
     if (currentNode && direction == FocusDirectionForward && isFocusableShadowHost(currentNode, event)) {
-        Node* foundInInnerFocusScope = findFocusableNodeRecursively(direction, FocusScope::focusScopeOwnedByShadowHost(currentNode), 0, event);
+        Node* foundInInnerFocusScope = findFocusableNodeRecursively(direction, FocusNavigationScope::focusNavigationScopeOwnedByShadowHost(currentNode), 0, event);
         found = foundInInnerFocusScope ? foundInInnerFocusScope : findFocusableNodeRecursively(direction, scope, currentNode, event);
     } else
         found = findFocusableNodeRecursively(direction, scope, currentNode, event);
@@ -403,7 +403,7 @@
         Node* owner = scope.owner();
         if (!owner)
             break;
-        scope = FocusScope::focusScopeOf(owner);
+        scope = FocusNavigationScope::focusNavigationScopeOf(owner);
         if (direction == FocusDirectionBackward && isFocusableShadowHost(owner, event)) {
             found = owner;
             break;
@@ -414,7 +414,7 @@
     return found;
 }
 
-Node* FocusController::findFocusableNodeRecursively(FocusDirection direction, FocusScope scope, Node* start, KeyboardEvent* event)
+Node* FocusController::findFocusableNodeRecursively(FocusDirection direction, FocusNavigationScope scope, Node* start, KeyboardEvent* event)
 {
     // Starting node is exclusive.
     Node* found = findFocusableNode(direction, scope, start, event);
@@ -423,22 +423,22 @@
     if (direction == FocusDirectionForward) {
         if (!isNonFocusableShadowHost(found, event))
             return found;
-        Node* foundInInnerFocusScope = findFocusableNodeRecursively(direction, FocusScope::focusScopeOwnedByShadowHost(found), 0, event);
+        Node* foundInInnerFocusScope = findFocusableNodeRecursively(direction, FocusNavigationScope::focusNavigationScopeOwnedByShadowHost(found), 0, event);
         return foundInInnerFocusScope ? foundInInnerFocusScope : findFocusableNodeRecursively(direction, scope, found, event);
     }
     ASSERT(direction == FocusDirectionBackward);
     if (isFocusableShadowHost(found, event)) {
-        Node* foundInInnerFocusScope = findFocusableNodeRecursively(direction, FocusScope::focusScopeOwnedByShadowHost(found), 0, event);
+        Node* foundInInnerFocusScope = findFocusableNodeRecursively(direction, FocusNavigationScope::focusNavigationScopeOwnedByShadowHost(found), 0, event);
         return foundInInnerFocusScope ? foundInInnerFocusScope : found;
     }
     if (isNonFocusableShadowHost(found, event)) {
-        Node* foundInInnerFocusScope = findFocusableNodeRecursively(direction, FocusScope::focusScopeOwnedByShadowHost(found), 0, event);
+        Node* foundInInnerFocusScope = findFocusableNodeRecursively(direction, FocusNavigationScope::focusNavigationScopeOwnedByShadowHost(found), 0, event);
         return foundInInnerFocusScope ? foundInInnerFocusScope :findFocusableNodeRecursively(direction, scope, found, event);
     }
     return found;
 }
 
-Node* FocusController::findFocusableNode(FocusDirection direction, FocusScope scope, Node* node, KeyboardEvent* event)
+Node* FocusController::findFocusableNode(FocusDirection direction, FocusNavigationScope scope, Node* node, KeyboardEvent* event)
 {
     return (direction == FocusDirectionForward)
         ? nextFocusableNode(scope, node, event)
@@ -487,7 +487,7 @@
     return winner;
 }
 
-Node* FocusController::nextFocusableNode(FocusScope scope, Node* start, KeyboardEvent* event)
+Node* FocusController::nextFocusableNode(FocusNavigationScope scope, Node* start, KeyboardEvent* event)
 {
     if (start) {
         int tabIndex = adjustedTabIndex(start, event);
@@ -519,7 +519,7 @@
     return findNodeWithExactTabIndex(scope.rootNode(), 0, event, FocusDirectionForward);
 }
 
-Node* FocusController::previousFocusableNode(FocusScope scope, Node* start, KeyboardEvent* event)
+Node* FocusController::previousFocusableNode(FocusNavigationScope scope, Node* start, KeyboardEvent* event)
 {
     Node* last = 0;
     for (ComposedShadowTreeWalker walker = walkerFrom(scope.rootNode()); walker.get(); walker.lastChild())

Modified: trunk/Source/WebCore/page/FocusController.h (123564 => 123565)


--- trunk/Source/WebCore/page/FocusController.h	2012-07-25 01:57:08 UTC (rev 123564)
+++ trunk/Source/WebCore/page/FocusController.h	2012-07-25 02:08:38 UTC (rev 123565)
@@ -45,16 +45,16 @@
 class Page;
 class TreeScope;
 
-class FocusScope {
+class FocusNavigationScope {
 public:
     Node* rootNode() const;
     Element* owner() const;
-    static FocusScope focusScopeOf(Node*);
-    static FocusScope focusScopeOwnedByShadowHost(Node*);
-    static FocusScope focusScopeOwnedByIFrame(HTMLFrameOwnerElement*);
+    static FocusNavigationScope focusNavigationScopeOf(Node*);
+    static FocusNavigationScope focusNavigationScopeOwnedByShadowHost(Node*);
+    static FocusNavigationScope focusNavigationScopeOwnedByIFrame(HTMLFrameOwnerElement*);
 
 private:
-    explicit FocusScope(TreeScope*);
+    explicit FocusNavigationScope(TreeScope*);
     TreeScope* m_rootTreeScope;
 };
 
@@ -87,8 +87,8 @@
     bool advanceFocusDirectionally(FocusDirection, KeyboardEvent*);
     bool advanceFocusInDocumentOrder(FocusDirection, KeyboardEvent*, bool initialFocus);
 
-    Node* findFocusableNodeAcrossFocusScope(FocusDirection, FocusScope startScope, Node* start, KeyboardEvent*);
-    Node* findFocusableNodeRecursively(FocusDirection, FocusScope, Node* start, KeyboardEvent*);
+    Node* findFocusableNodeAcrossFocusScope(FocusDirection, FocusNavigationScope startScope, Node* start, KeyboardEvent*);
+    Node* findFocusableNodeRecursively(FocusDirection, FocusNavigationScope, Node* start, KeyboardEvent*);
     Node* findFocusableNodeDecendingDownIntoFrameDocument(FocusDirection, Node*, KeyboardEvent*);
 
     // Searches through the given tree scope, starting from start node, for the next/previous selectable element that comes after/before start node.
@@ -100,10 +100,10 @@
     // @return The focus node that comes after/before start node.
     //
     // See http://www.w3.org/TR/html4/interact/forms.html#h-17.11.1
-    inline Node* findFocusableNode(FocusDirection, FocusScope, Node* start, KeyboardEvent*);
+    inline Node* findFocusableNode(FocusDirection, FocusNavigationScope, Node* start, KeyboardEvent*);
 
-    Node* nextFocusableNode(FocusScope, Node* start, KeyboardEvent*);
-    Node* previousFocusableNode(FocusScope, Node* start, KeyboardEvent*);
+    Node* nextFocusableNode(FocusNavigationScope, Node* start, KeyboardEvent*);
+    Node* previousFocusableNode(FocusNavigationScope, Node* start, KeyboardEvent*);
 
     Node* findNodeWithExactTabIndex(Node* start, int tabIndex, KeyboardEvent*, FocusDirection);
 
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to