Title: [123569] trunk/Source
Revision
123569
Author
[email protected]
Date
2012-07-24 20:25:58 -0700 (Tue, 24 Jul 2012)

Log Message

IndexedDB: fix #include dependencies so IDBRequest isn't an include root
https://bugs.webkit.org/show_bug.cgi?id=92167

Patch by Alec Flett <[email protected]> on 2012-07-24
Reviewed by Tony Chang.

Source/WebCore:

Remove implicit dependencies due to using IDBRequest.h, and fix all
places that break as a result.

* Modules/indexeddb/IDBCallbacks.h:
(WebCore):
* Modules/indexeddb/IDBObjectStore.cpp:
* Modules/indexeddb/IDBRequest.h:
* inspector/InspectorIndexedDBAgent.cpp:

Source/WebKit/chromium:

Remove implicit dependencies due to using IDBRequest.h, and fix all
places that break as a result.

* src/IDBCallbacksProxy.cpp:
* src/WebIDBDatabaseImpl.cpp:
* src/WebIDBTransactionImpl.cpp:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (123568 => 123569)


--- trunk/Source/WebCore/ChangeLog	2012-07-25 02:35:01 UTC (rev 123568)
+++ trunk/Source/WebCore/ChangeLog	2012-07-25 03:25:58 UTC (rev 123569)
@@ -1,3 +1,19 @@
+2012-07-24  Alec Flett  <[email protected]>
+
+        IndexedDB: fix #include dependencies so IDBRequest isn't an include root
+        https://bugs.webkit.org/show_bug.cgi?id=92167
+
+        Reviewed by Tony Chang.
+
+        Remove implicit dependencies due to using IDBRequest.h, and fix all
+        places that break as a result.
+
+        * Modules/indexeddb/IDBCallbacks.h:
+        (WebCore):
+        * Modules/indexeddb/IDBObjectStore.cpp:
+        * Modules/indexeddb/IDBRequest.h:
+        * inspector/InspectorIndexedDBAgent.cpp:
+
 2012-07-24  Keishi Hattori  <[email protected]>
 
         Move PagePopupClient helper functions so they can be shared

Modified: trunk/Source/WebCore/Modules/indexeddb/IDBCallbacks.h (123568 => 123569)


--- trunk/Source/WebCore/Modules/indexeddb/IDBCallbacks.h	2012-07-25 02:35:01 UTC (rev 123568)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBCallbacks.h	2012-07-25 03:25:58 UTC (rev 123569)
@@ -30,19 +30,19 @@
 #define IDBCallbacks_h
 
 #include "DOMStringList.h"
-#include "IDBCursorBackendInterface.h"
-#include "IDBDatabaseBackendInterface.h"
 #include "IDBDatabaseError.h"
 #include "IDBKey.h"
 #include "IDBKeyPath.h"
-#include "IDBObjectStoreBackendInterface.h"
-#include "IDBTransactionBackendInterface.h"
 #include "SerializedScriptValue.h"
 #include <wtf/Threading.h>
 
 #if ENABLE(INDEXED_DATABASE)
 
 namespace WebCore {
+class IDBCursorBackendInterface;
+class IDBDatabaseBackendInterface;
+class IDBObjectStoreBackendInterface;
+class IDBTransactionBackendInterface;
 
 // FIXME: All child classes need to be made threadsafe.
 class IDBCallbacks : public ThreadSafeRefCounted<IDBCallbacks> {

Modified: trunk/Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp (123568 => 123569)


--- trunk/Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp	2012-07-25 02:35:01 UTC (rev 123568)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp	2012-07-25 03:25:58 UTC (rev 123569)
@@ -31,6 +31,7 @@
 #include "DOMStringList.h"
 #include "IDBAny.h"
 #include "IDBBindingUtilities.h"
+#include "IDBCursorBackendInterface.h"
 #include "IDBDatabase.h"
 #include "IDBDatabaseException.h"
 #include "IDBIndex.h"

Modified: trunk/Source/WebCore/Modules/indexeddb/IDBRequest.h (123568 => 123569)


--- trunk/Source/WebCore/Modules/indexeddb/IDBRequest.h	2012-07-25 02:35:01 UTC (rev 123568)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBRequest.h	2012-07-25 03:25:58 UTC (rev 123569)
@@ -41,6 +41,7 @@
 #include "IDBAny.h"
 #include "IDBCallbacks.h"
 #include "IDBCursor.h"
+#include "IDBCursorBackendInterface.h"
 
 namespace WebCore {
 

Modified: trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.cpp (123568 => 123569)


--- trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.cpp	2012-07-25 02:35:01 UTC (rev 123568)
+++ trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.cpp	2012-07-25 03:25:58 UTC (rev 123569)
@@ -42,6 +42,7 @@
 #include "GroupSettings.h"
 #include "IDBCallbacks.h"
 #include "IDBCursor.h"
+#include "IDBCursorBackendInterface.h"
 #include "IDBDatabaseBackendInterface.h"
 #include "IDBDatabaseCallbacks.h"
 #include "IDBFactoryBackendInterface.h"

Modified: trunk/Source/WebKit/chromium/ChangeLog (123568 => 123569)


--- trunk/Source/WebKit/chromium/ChangeLog	2012-07-25 02:35:01 UTC (rev 123568)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-07-25 03:25:58 UTC (rev 123569)
@@ -1,3 +1,17 @@
+2012-07-24  Alec Flett  <[email protected]>
+
+        IndexedDB: fix #include dependencies so IDBRequest isn't an include root
+        https://bugs.webkit.org/show_bug.cgi?id=92167
+
+        Reviewed by Tony Chang.
+
+        Remove implicit dependencies due to using IDBRequest.h, and fix all 
+        places that break as a result.
+
+        * src/IDBCallbacksProxy.cpp:
+        * src/WebIDBDatabaseImpl.cpp:
+        * src/WebIDBTransactionImpl.cpp:
+
 2012-07-24  Adam Barth  <[email protected]>
 
         [Chromium] Support scrolling and zooming to focused input elements

Modified: trunk/Source/WebKit/chromium/src/IDBCallbacksProxy.cpp (123568 => 123569)


--- trunk/Source/WebKit/chromium/src/IDBCallbacksProxy.cpp	2012-07-25 02:35:01 UTC (rev 123568)
+++ trunk/Source/WebKit/chromium/src/IDBCallbacksProxy.cpp	2012-07-25 03:25:58 UTC (rev 123569)
@@ -31,8 +31,12 @@
 
 #if ENABLE(INDEXED_DATABASE)
 
+#include "IDBCursorBackendInterface.h"
+#include "IDBDatabaseBackendInterface.h"
 #include "IDBDatabaseBackendProxy.h"
 #include "IDBDatabaseError.h"
+#include "IDBObjectStoreBackendInterface.h"
+#include "IDBTransactionBackendInterface.h"
 #include "WebIDBCallbacks.h"
 #include "WebIDBCursorImpl.h"
 #include "WebIDBDatabaseImpl.h"

Modified: trunk/Source/WebKit/chromium/src/WebIDBDatabaseImpl.cpp (123568 => 123569)


--- trunk/Source/WebKit/chromium/src/WebIDBDatabaseImpl.cpp	2012-07-25 02:35:01 UTC (rev 123568)
+++ trunk/Source/WebKit/chromium/src/WebIDBDatabaseImpl.cpp	2012-07-25 03:25:58 UTC (rev 123569)
@@ -33,6 +33,7 @@
 #include "IDBDatabaseBackendInterface.h"
 #include "IDBDatabaseCallbacksProxy.h"
 #include "IDBMetadata.h"
+#include "IDBObjectStoreBackendInterface.h"
 #include "IDBTransactionBackendInterface.h"
 #include "WebIDBCallbacks.h"
 #include "WebIDBDatabaseCallbacks.h"

Modified: trunk/Source/WebKit/chromium/src/WebIDBTransactionImpl.cpp (123568 => 123569)


--- trunk/Source/WebKit/chromium/src/WebIDBTransactionImpl.cpp	2012-07-25 02:35:01 UTC (rev 123568)
+++ trunk/Source/WebKit/chromium/src/WebIDBTransactionImpl.cpp	2012-07-25 03:25:58 UTC (rev 123569)
@@ -28,6 +28,7 @@
 
 #if ENABLE(INDEXED_DATABASE)
 
+#include "IDBObjectStoreBackendInterface.h"
 #include "IDBTransaction.h"
 #include "IDBTransactionCallbacksProxy.h"
 #include "WebIDBObjectStoreImpl.h"
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to