Title: [123619] trunk/Source/WebKit/chromium
- Revision
- 123619
- Author
- [email protected]
- Date
- 2012-07-25 08:09:22 -0700 (Wed, 25 Jul 2012)
Log Message
[chromium] Calendar picker popup displays at wrong scale when deviceScaleFactor != 1.
https://bugs.webkit.org/show_bug.cgi?id=92177
Manually tested at deviceScaleFactor = 1 and 2.
Patch by Kevin Ellis <[email protected]> on 2012-07-25
Reviewed by Kent Tamura.
The device scale factor was not being set for the calendar popup.
As a result, the popup was rendered too small on hidpi displays.
This patch sets the device scale factor for any page popup.
* src/WebPagePopupImpl.cpp:
(WebKit::WebPagePopupImpl::initPage):
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (123618 => 123619)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-07-25 15:05:40 UTC (rev 123618)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-07-25 15:09:22 UTC (rev 123619)
@@ -1,3 +1,19 @@
+2012-07-25 Kevin Ellis <[email protected]>
+
+ [chromium] Calendar picker popup displays at wrong scale when deviceScaleFactor != 1.
+ https://bugs.webkit.org/show_bug.cgi?id=92177
+
+ Manually tested at deviceScaleFactor = 1 and 2.
+
+ Reviewed by Kent Tamura.
+
+ The device scale factor was not being set for the calendar popup.
+ As a result, the popup was rendered too small on hidpi displays.
+ This patch sets the device scale factor for any page popup.
+
+ * src/WebPagePopupImpl.cpp:
+ (WebKit::WebPagePopupImpl::initPage):
+
2012-07-25 MORITA Hajime <[email protected]>
Another unreviewed win build fix against r123569.
Modified: trunk/Source/WebKit/chromium/src/WebPagePopupImpl.cpp (123618 => 123619)
--- trunk/Source/WebKit/chromium/src/WebPagePopupImpl.cpp 2012-07-25 15:05:40 UTC (rev 123618)
+++ trunk/Source/WebKit/chromium/src/WebPagePopupImpl.cpp 2012-07-25 15:09:22 UTC (rev 123619)
@@ -190,6 +190,7 @@
m_page = adoptPtr(new Page(pageClients));
m_page->settings()->setScriptEnabled(true);
m_page->settings()->setAllowScriptsToCloseWindows(true);
+ m_page->setDeviceScaleFactor(m_webView->deviceScaleFactor());
static ContextFeaturesClient* pagePopupFeaturesClient = new PagePopupFeaturesClient();
provideContextFeaturesTo(m_page.get(), pagePopupFeaturesClient);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
