Title: [123641] trunk/Source/WebCore
Revision
123641
Author
[email protected]
Date
2012-07-25 11:49:29 -0700 (Wed, 25 Jul 2012)

Log Message

Web Inspector: follow up to r123612, fixing CSS value suggest.

Not reviewed, minor JS fix.

* inspector/front-end/CSSCompletions.js:
(WebInspector.CSSCompletions):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (123640 => 123641)


--- trunk/Source/WebCore/ChangeLog	2012-07-25 18:48:57 UTC (rev 123640)
+++ trunk/Source/WebCore/ChangeLog	2012-07-25 18:49:29 UTC (rev 123641)
@@ -1,3 +1,14 @@
+2012-07-25  'Pavel Feldman'  <[email protected]>
+
+        Web Inspector: follow up to r123612, fixing CSS value suggest.
+
+        Not reviewed, minor JS fix.
+
+        * inspector/front-end/CSSCompletions.js:
+        (WebInspector.CSSCompletions):
+        * inspector/front-end/StylesSidebarPane.js:
+        (WebInspector.StylePropertyTreeElement.prototype):
+
 2012-07-25  Michael Saboff  <[email protected]>
 
         Unreviewed build fix after r123624.

Modified: trunk/Source/WebCore/inspector/front-end/CSSCompletions.js (123640 => 123641)


--- trunk/Source/WebCore/inspector/front-end/CSSCompletions.js	2012-07-25 18:48:57 UTC (rev 123640)
+++ trunk/Source/WebCore/inspector/front-end/CSSCompletions.js	2012-07-25 18:49:29 UTC (rev 123641)
@@ -32,7 +32,7 @@
 
 /**
  * @constructor
- * @param {Array.<CSSAgent.CSSPropertyInfo>} properties
+ * @param {Array.<CSSAgent.CSSPropertyInfo|string>} properties
  */
 WebInspector.CSSCompletions = function(properties, acceptEmptyPrefix)
 {
@@ -40,7 +40,13 @@
     this._longhands = {};
     this._shorthands = {};
     for (var i = 0; i < properties.length; ++i) {
-        var propertyName = properties[i].name;
+        var property = properties[i];
+        if (typeof property === "string") {
+            this._values.push(property);
+            continue;
+        }
+
+        var propertyName = property.name;
         this._values.push(propertyName);
 
         var longhands = properties[i].longhands;

Modified: trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js (123640 => 123641)


--- trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js	2012-07-25 18:48:57 UTC (rev 123640)
+++ trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js	2012-07-25 18:49:29 UTC (rev 123641)
@@ -2006,6 +2006,9 @@
             }
 
             var liveProperty = this.style.getLiveProperty(name);
+            if (!liveProperty)
+                continue;
+
             var item = new WebInspector.StylePropertyTreeElement(this.section, this._parentPane, this._styleRule, this.style, liveProperty, false, inherited, overloaded);
             this.appendChild(item);
         }
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to