Title: [123700] trunk/Source/WebCore
- Revision
- 123700
- Author
- [email protected]
- Date
- 2012-07-25 19:36:25 -0700 (Wed, 25 Jul 2012)
Log Message
[BlackBerry] readPixels should set alpha to 255 instead of 0 when alpha is disabled
https://bugs.webkit.org/show_bug.cgi?id=92303
Patch by Joshua Netterfield <[email protected]> on 2012-07-25
Reviewed by Rob Buis.
No new tests, because it corrects existing functionality, but it makes BlackBerry
pass context-attributes-alpha-depth-stencil-antialias.html.
* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::readPixels):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (123699 => 123700)
--- trunk/Source/WebCore/ChangeLog 2012-07-26 02:32:13 UTC (rev 123699)
+++ trunk/Source/WebCore/ChangeLog 2012-07-26 02:36:25 UTC (rev 123700)
@@ -1,5 +1,19 @@
2012-07-25 Joshua Netterfield <[email protected]>
+ [BlackBerry] readPixels should set alpha to 255 instead of 0 when alpha is disabled
+ https://bugs.webkit.org/show_bug.cgi?id=92303
+
+ Reviewed by Rob Buis.
+
+ No new tests, because it corrects existing functionality, but it makes BlackBerry
+ pass context-attributes-alpha-depth-stencil-antialias.html.
+
+ * html/canvas/WebGLRenderingContext.cpp:
+ (WebCore):
+ (WebCore::WebGLRenderingContext::readPixels):
+
+2012-07-25 Joshua Netterfield <[email protected]>
+
[WebGL] fast/canvas/webgl/framebuffer-object-attachment.html fails on certain platforms
https://bugs.webkit.org/show_bug.cgi?id=92296
Modified: trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp (123699 => 123700)
--- trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp 2012-07-26 02:32:13 UTC (rev 123699)
+++ trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp 2012-07-26 02:36:25 UTC (rev 123700)
@@ -3307,9 +3307,10 @@
m_context->readPixels(x, y, width, height, format, type, data);
}
-#if OS(DARWIN)
- // FIXME: remove this section when GL driver bug on Mac is fixed, i.e.,
- // when alpha is off, readPixels should set alpha to 255 instead of 0.
+#if OS(DARWIN) || OS(QNX)
+ // FIXME: remove this section when GL driver bug on Mac AND the GLES driver bug
+ // on QC & Imagination QNX is fixed, i.e., when alpha is off, readPixels should
+ // set alpha to 255 instead of 0.
if (!m_framebufferBinding && !m_context->getContextAttributes().alpha) {
unsigned char* pixels = reinterpret_cast<unsigned char*>(data);
for (GC3Dsizei iy = 0; iy < height; ++iy) {
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
