Title: [123723] trunk/Tools
- Revision
- 123723
- Author
- [email protected]
- Date
- 2012-07-26 03:07:41 -0700 (Thu, 26 Jul 2012)
Log Message
[EFL] Regression(r123604): webintents/web-intents-obj-constructor.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=92349
Patch by Christophe Dumez <[email protected]> on 2012-07-26
Reviewed by Kentaro Hara.
Fix crash occurring after r123604, which replaced strdup()
usage with eina_stringshare_add(). Unfortunately, the DRT
was not updated accordingly to use eina_stringshare_del()
instead of free() on the values returned by Ewk_Intent
getters and it was causing
webintents/web-intents-obj-constructor.html to crash.
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::onFrameIntentNew):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (123722 => 123723)
--- trunk/Tools/ChangeLog 2012-07-26 09:49:52 UTC (rev 123722)
+++ trunk/Tools/ChangeLog 2012-07-26 10:07:41 UTC (rev 123723)
@@ -1,3 +1,20 @@
+2012-07-26 Christophe Dumez <[email protected]>
+
+ [EFL] Regression(r123604): webintents/web-intents-obj-constructor.html is crashing
+ https://bugs.webkit.org/show_bug.cgi?id=92349
+
+ Reviewed by Kentaro Hara.
+
+ Fix crash occurring after r123604, which replaced strdup()
+ usage with eina_stringshare_add(). Unfortunately, the DRT
+ was not updated accordingly to use eina_stringshare_del()
+ instead of free() on the values returned by Ewk_Intent
+ getters and it was causing
+ webintents/web-intents-obj-constructor.html to crash.
+
+ * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
+ (DumpRenderTreeChrome::onFrameIntentNew):
+
2012-07-26 Adam Barth <[email protected]>
Unreviewed attempt to fix the chromium-win build.
Modified: trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp (123722 => 123723)
--- trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp 2012-07-26 09:49:52 UTC (rev 123722)
+++ trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp 2012-07-26 10:07:41 UTC (rev 123723)
@@ -856,19 +856,20 @@
void* data = ""
Eina_List* extraNames = ewk_intent_extra_names_get(intent);
EINA_LIST_FREE(extraNames, data) {
- char* name = static_cast<char*>(data);
+ const char* name = static_cast<char*>(data);
const char* value = ewk_intent_extra_get(intent, name);
if (value) {
printf("Extras[%s] = %s\n", name, value);
eina_stringshare_del(value);
}
- free(name);
+ eina_stringshare_del(name);
}
Eina_List* suggestions = ewk_intent_suggestions_get(intent);
EINA_LIST_FREE(suggestions, data) {
- printf("Have suggestion %s\n", static_cast<char*>(data));
- free(data);
+ const char* suggestion = static_cast<char*>(data);
+ printf("Have suggestion %s\n", suggestion);
+ eina_stringshare_del(suggestion);
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
