Title: [123732] trunk/Source/WebKit2
- Revision
- 123732
- Author
- [email protected]
- Date
- 2012-07-26 05:10:21 -0700 (Thu, 26 Jul 2012)
Log Message
[WK2] WebPage::handleEditingKeyboardEvent does not check whether the node allows editing.
https://bugs.webkit.org/show_bug.cgi?id=92364
Patch by Mikhail Pozdnyakov <[email protected]> on 2012-07-26
Reviewed by Kenneth Rohde Christiansen.
Added a check whether the input node allows editing. If editing is not allowed
text input event will not be emitted.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::handleEditingKeyboardEvent):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (123731 => 123732)
--- trunk/Source/WebKit2/ChangeLog 2012-07-26 12:01:37 UTC (rev 123731)
+++ trunk/Source/WebKit2/ChangeLog 2012-07-26 12:10:21 UTC (rev 123732)
@@ -1,3 +1,16 @@
+2012-07-26 Mikhail Pozdnyakov <[email protected]>
+
+ [WK2] WebPage::handleEditingKeyboardEvent does not check whether the node allows editing.
+ https://bugs.webkit.org/show_bug.cgi?id=92364
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Added a check whether the input node allows editing. If editing is not allowed
+ text input event will not be emitted.
+
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::handleEditingKeyboardEvent):
+
2012-07-26 Zoltan Nyul <[email protected]>
[EFL] EFL port should use XDG paths
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (123731 => 123732)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2012-07-26 12:01:37 UTC (rev 123731)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2012-07-26 12:10:21 UTC (rev 123732)
@@ -2145,6 +2145,10 @@
if (command.execute(evt))
return true;
+ // Don't allow text insertion for nodes that cannot edit.
+ if (!frame->editor()->canEdit())
+ return false;
+
// Don't insert null or control characters as they can result in unexpected behaviour
if (evt->charCode() < ' ')
return false;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes