Title: [123753] trunk/Source/WebCore
- Revision
- 123753
- Author
- commit-qu...@webkit.org
- Date
- 2012-07-26 09:12:32 -0700 (Thu, 26 Jul 2012)
Log Message
Web Inspector: ExtensionView constructor shouldn't take parent argument
https://bugs.webkit.org/show_bug.cgi?id=92326
Patch by Jan Keromnes <j...@linux.com> on 2012-07-26
Reviewed by Pavel Feldman.
ExtensionView's constructor took a parent element parameter and auto-
showed itself in the constructor. This didn't allow lazy showing and
was confusing because it didn't work like a classic View object. Fixed.
No new tests needed: Refactoring with no behavior changes.
* inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionPanel):
(WebInspector.ExtensionSidebarPane.prototype.setPage):
* inspector/front-end/ExtensionView.js:
(WebInspector.ExtensionView):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (123752 => 123753)
--- trunk/Source/WebCore/ChangeLog 2012-07-26 16:04:20 UTC (rev 123752)
+++ trunk/Source/WebCore/ChangeLog 2012-07-26 16:12:32 UTC (rev 123753)
@@ -1,3 +1,22 @@
+2012-07-26 Jan Keromnes <j...@linux.com>
+
+ Web Inspector: ExtensionView constructor shouldn't take parent argument
+ https://bugs.webkit.org/show_bug.cgi?id=92326
+
+ Reviewed by Pavel Feldman.
+
+ ExtensionView's constructor took a parent element parameter and auto-
+ showed itself in the constructor. This didn't allow lazy showing and
+ was confusing because it didn't work like a classic View object. Fixed.
+
+ No new tests needed: Refactoring with no behavior changes.
+
+ * inspector/front-end/ExtensionPanel.js:
+ (WebInspector.ExtensionPanel):
+ (WebInspector.ExtensionSidebarPane.prototype.setPage):
+ * inspector/front-end/ExtensionView.js:
+ (WebInspector.ExtensionView):
+
2012-07-26 Joshua Netterfield <jnetterfi...@rim.com>
[WebGL] ANGLEWebKitBridge should support ESSL platforms
Modified: trunk/Source/WebCore/inspector/front-end/ExtensionPanel.js (123752 => 123753)
--- trunk/Source/WebCore/inspector/front-end/ExtensionPanel.js 2012-07-26 16:04:20 UTC (rev 123752)
+++ trunk/Source/WebCore/inspector/front-end/ExtensionPanel.js 2012-07-26 16:12:32 UTC (rev 123753)
@@ -47,7 +47,8 @@
this._addStyleRule(".toolbar-item." + id + " .toolbar-icon", "background-image: url(" + iconURL + ");");
this._addStyleRule(".toolbar-small .toolbar-item." + id + " .toolbar-icon", "background-position-x: -32px;");
}
- new WebInspector.ExtensionView(id, this.element, pageURL, "extension panel");
+ var extensionView = new WebInspector.ExtensionView(id, pageURL, "extension panel");
+ extensionView.show(this.element);
}
WebInspector.ExtensionPanel.prototype = {
@@ -196,7 +197,9 @@
if (this._extensionView)
this._extensionView.detach(true);
- this._extensionView = new WebInspector.ExtensionView(this._id, this.bodyElement, url, "extension fill");
+ this._extensionView = new WebInspector.ExtensionView(this._id, url, "extension fill");
+ this._extensionView.show(this.bodyElement);
+
if (!this.bodyElement.style.height)
this.setHeight("150px");
},
Modified: trunk/Source/WebCore/inspector/front-end/ExtensionView.js (123752 => 123753)
--- trunk/Source/WebCore/inspector/front-end/ExtensionView.js 2012-07-26 16:04:20 UTC (rev 123752)
+++ trunk/Source/WebCore/inspector/front-end/ExtensionView.js 2012-07-26 16:12:32 UTC (rev 123753)
@@ -32,11 +32,10 @@
* @constructor
* @extends {WebInspector.View}
* @param {string} id
- * @param {Element} parent
* @param {string} src
* @param {string} className
*/
-WebInspector.ExtensionView = function(id, parent, src, className)
+WebInspector.ExtensionView = function(id, src, className)
{
WebInspector.View.call(this);
this.element.className = "fill";
@@ -48,7 +47,6 @@
this._iframe.className = className;
this.element.appendChild(this._iframe);
- this.show(parent);
}
WebInspector.ExtensionView.prototype = {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
