Title: [123883] trunk/Source/WebKit/efl
- Revision
- 123883
- Author
- [email protected]
- Date
- 2012-07-27 10:34:27 -0700 (Fri, 27 Jul 2012)
Log Message
[EFL] Regression(r123858): Default navigation policy decision was switched to "reject"
https://bugs.webkit.org/show_bug.cgi?id=92507
Patch by Christophe Dumez <[email protected]> on 2012-07-27
Reviewed by Kentaro Hara.
After r92466, the default navigation policy is to reject the request if the
client does not make a decision explicitly. The default policy should be
to accept. This broke ewk_view unit tests.
* ewk/ewk_view.cpp:
(ewk_view_navigation_policy_decision):
Modified Paths
Diff
Modified: trunk/Source/WebKit/efl/ChangeLog (123882 => 123883)
--- trunk/Source/WebKit/efl/ChangeLog 2012-07-27 17:24:49 UTC (rev 123882)
+++ trunk/Source/WebKit/efl/ChangeLog 2012-07-27 17:34:27 UTC (rev 123883)
@@ -1,3 +1,17 @@
+2012-07-27 Christophe Dumez <[email protected]>
+
+ [EFL] Regression(r123858): Default navigation policy decision was switched to "reject"
+ https://bugs.webkit.org/show_bug.cgi?id=92507
+
+ Reviewed by Kentaro Hara.
+
+ After r92466, the default navigation policy is to reject the request if the
+ client does not make a decision explicitly. The default policy should be
+ to accept. This broke ewk_view unit tests.
+
+ * ewk/ewk_view.cpp:
+ (ewk_view_navigation_policy_decision):
+
2012-07-27 Gyuyoung Kim <[email protected]>
[EFL] Fix wrong return value in EWK_VIEW_XXX macro.
Modified: trunk/Source/WebKit/efl/ewk/ewk_view.cpp (123882 => 123883)
--- trunk/Source/WebKit/efl/ewk/ewk_view.cpp 2012-07-27 17:24:49 UTC (rev 123882)
+++ trunk/Source/WebKit/efl/ewk/ewk_view.cpp 2012-07-27 17:34:27 UTC (rev 123883)
@@ -4018,15 +4018,17 @@
/**
* @internal
- * Reports a requeset will be loaded. It's client responsibility to decide if
- * request would be used. If @return is true, loader will try to load. Else,
- * Loader ignore action of request.
+ * Reports that a navigation policy decision should be taken. If @return
+ * is true, the navigation request will be accepted, otherwise it will be
+ * ignored.
*
* @param ewkView View to load
* @param request Request which contain url to navigate
* @param navigationType navigation type
*
- * @return true on success or false otherwise
+ * @return true if the client accepted the navigation request, false otherwise. If the
+ * client did not make a decision, we return true by default since the default policy
+ * is to accept.
*/
bool ewk_view_navigation_policy_decision(Evas_Object* ewkView, Ewk_Frame_Resource_Request* request, Ewk_Navigation_Type navigationType)
{
@@ -4034,7 +4036,7 @@
EINA_SAFETY_ON_NULL_RETURN_VAL(smartData->api, false);
if (!smartData->api->navigation_policy_decision)
- return false;
+ return true;
return smartData->api->navigation_policy_decision(smartData, request, navigationType);
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
