Title: [123888] trunk/Source
Revision
123888
Author
[email protected]
Date
2012-07-27 10:56:49 -0700 (Fri, 27 Jul 2012)

Log Message

[chromium] Calendar for input type=date should be larger on devices that support touch input.
https://bugs.webkit.org/show_bug.cgi?id=92424

Patch by Kevin Ellis <[email protected]> on 2012-07-27
Reviewed by Kent Tamura.

Source/WebCore:

Adds touch specific CSS rules to enlarge entries in the calendar on
screens that support touch input.

Manually tested with touch support enabled/disabled.

* Resources/calendarPicker.css:
(@media (pointer:coarse)):
* html/shadow/CalendarPickerElement.cpp:
(WebCore::CalendarPickerElement::contentSize):

Source/WebKit/chromium:

Plumbs the deviceSupportsTouch setting through to the popup page so
that the Calendar popup can be enlarged on screens that support touch
input.

* src/WebPagePopupImpl.cpp:
(WebKit::WebPagePopupImpl::initPage):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (123887 => 123888)


--- trunk/Source/WebCore/ChangeLog	2012-07-27 17:50:52 UTC (rev 123887)
+++ trunk/Source/WebCore/ChangeLog	2012-07-27 17:56:49 UTC (rev 123888)
@@ -1,3 +1,20 @@
+2012-07-27  Kevin Ellis  <[email protected]>
+
+        [chromium] Calendar for input type=date should be larger on devices that support touch input.
+        https://bugs.webkit.org/show_bug.cgi?id=92424
+
+        Reviewed by Kent Tamura.
+
+        Adds touch specific CSS rules to enlarge entries in the calendar on
+        screens that support touch input.
+
+        Manually tested with touch support enabled/disabled.
+
+        * Resources/calendarPicker.css:
+        (@media (pointer:coarse)):
+        * html/shadow/CalendarPickerElement.cpp:
+        (WebCore::CalendarPickerElement::contentSize):
+
 2012-07-28  Chris Fleizach  <[email protected]>
 
         WebKit should expose @title as label (AXTitle or AXDescription) sometimes instead of AXHelp, according to the ARIA text alt computation

Modified: trunk/Source/WebCore/Resources/calendarPicker.css (123887 => 123888)


--- trunk/Source/WebCore/Resources/calendarPicker.css	2012-07-27 17:50:52 UTC (rev 123887)
+++ trunk/Source/WebCore/Resources/calendarPicker.css	2012-07-27 17:56:49 UTC (rev 123888)
@@ -139,6 +139,13 @@
     -webkit-box-sizing: border-box;
 }
 
+@media (pointer:coarse) {
+    .day {
+        min-width: 28px;
+        line-height: 28px;
+    }
+}
+
 .available {
     cursor: default;
     font-weight: 700;

Modified: trunk/Source/WebKit/chromium/ChangeLog (123887 => 123888)


--- trunk/Source/WebKit/chromium/ChangeLog	2012-07-27 17:50:52 UTC (rev 123887)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-07-27 17:56:49 UTC (rev 123888)
@@ -1,3 +1,17 @@
+2012-07-27  Kevin Ellis  <[email protected]>
+
+        [chromium] Calendar for input type=date should be larger on devices that support touch input.
+        https://bugs.webkit.org/show_bug.cgi?id=92424
+
+        Reviewed by Kent Tamura.
+
+        Plumbs the deviceSupportsTouch setting through to the popup page so
+        that the Calendar popup can be enlarged on screens that support touch
+        input.
+
+        * src/WebPagePopupImpl.cpp:
+        (WebKit::WebPagePopupImpl::initPage):
+
 2012-07-27  Peter Beverloo  <[email protected]>
 
         Unreviewed.  Rolled DEPS.

Modified: trunk/Source/WebKit/chromium/src/WebPagePopupImpl.cpp (123887 => 123888)


--- trunk/Source/WebKit/chromium/src/WebPagePopupImpl.cpp	2012-07-27 17:50:52 UTC (rev 123887)
+++ trunk/Source/WebKit/chromium/src/WebPagePopupImpl.cpp	2012-07-27 17:56:49 UTC (rev 123888)
@@ -191,6 +191,7 @@
     m_page->settings()->setScriptEnabled(true);
     m_page->settings()->setAllowScriptsToCloseWindows(true);
     m_page->setDeviceScaleFactor(m_webView->deviceScaleFactor());
+    m_page->settings()->setDeviceSupportsTouch(m_webView->page()->settings()->deviceSupportsTouch());
 
     static ContextFeaturesClient* pagePopupFeaturesClient =  new PagePopupFeaturesClient();
     provideContextFeaturesTo(m_page.get(), pagePopupFeaturesClient);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to