Title: [123933] trunk/Source/WebKit2
- Revision
- 123933
- Author
- [email protected]
- Date
- 2012-07-27 16:12:33 -0700 (Fri, 27 Jul 2012)
Log Message
[EFL][WK2] Assertion hit in ewk_cookie_manager.cpp
https://bugs.webkit.org/show_bug.cgi?id=92544
Patch by Christophe Dumez <[email protected]> on 2012-07-27
Reviewed by Kenneth Rohde Christiansen.
Removed wrong assertion in ewk_cookie_manager.cpp
and replace it by an if check. The assertion was
sometimes hit by our unit tests.
* UIProcess/API/efl/ewk_cookie_manager.cpp:
(cookiesDidChange):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (123932 => 123933)
--- trunk/Source/WebKit2/ChangeLog 2012-07-27 23:02:03 UTC (rev 123932)
+++ trunk/Source/WebKit2/ChangeLog 2012-07-27 23:12:33 UTC (rev 123933)
@@ -1,3 +1,17 @@
+2012-07-27 Christophe Dumez <[email protected]>
+
+ [EFL][WK2] Assertion hit in ewk_cookie_manager.cpp
+ https://bugs.webkit.org/show_bug.cgi?id=92544
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Removed wrong assertion in ewk_cookie_manager.cpp
+ and replace it by an if check. The assertion was
+ sometimes hit by our unit tests.
+
+ * UIProcess/API/efl/ewk_cookie_manager.cpp:
+ (cookiesDidChange):
+
2012-07-27 Anders Carlsson <[email protected]>
Don't use an NSUserDefault for disabling the web process sandbox
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_cookie_manager.cpp (123932 => 123933)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_cookie_manager.cpp 2012-07-27 23:02:03 UTC (rev 123932)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_cookie_manager.cpp 2012-07-27 23:12:33 UTC (rev 123933)
@@ -107,7 +107,9 @@
{
Ewk_Cookie_Manager* manager = static_cast<Ewk_Cookie_Manager*>(const_cast<void*>(clientInfo));
- ASSERT(manager->changeHandler.callback);
+ if (!manager->changeHandler.callback)
+ return;
+
manager->changeHandler.callback(manager->changeHandler.userData);
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes