Title: [123939] trunk/Source/WebCore
- Revision
- 123939
- Author
- [email protected]
- Date
- 2012-07-27 17:30:31 -0700 (Fri, 27 Jul 2012)
Log Message
[EFL] Return 0 when network is offline
https://bugs.webkit.org/show_bug.cgi?id=92454
Patch by Gyuyoung Kim <[email protected]> on 2012-07-27
Reviewed by Kenneth Rohde Christiansen.
Network Info latest spec says 0 is returned when network is offline.
r123769 modified to return infinity value when network is offiline.
* platform/efl/NetworkInfoProviderEfl.cpp:
(WebCore::NetworkInfoProviderEfl::bandwidth):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (123938 => 123939)
--- trunk/Source/WebCore/ChangeLog 2012-07-28 00:08:44 UTC (rev 123938)
+++ trunk/Source/WebCore/ChangeLog 2012-07-28 00:30:31 UTC (rev 123939)
@@ -1,3 +1,16 @@
+2012-07-27 Gyuyoung Kim <[email protected]>
+
+ [EFL] Return 0 when network is offline
+ https://bugs.webkit.org/show_bug.cgi?id=92454
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Network Info latest spec says 0 is returned when network is offline.
+ r123769 modified to return infinity value when network is offiline.
+
+ * platform/efl/NetworkInfoProviderEfl.cpp:
+ (WebCore::NetworkInfoProviderEfl::bandwidth):
+
2012-07-27 Scott Graham <[email protected]>
Change navigator.webkitGamepads[] to navigator.webkitGetGamepads()
Modified: trunk/Source/WebCore/platform/efl/NetworkInfoProviderEfl.cpp (123938 => 123939)
--- trunk/Source/WebCore/platform/efl/NetworkInfoProviderEfl.cpp 2012-07-28 00:08:44 UTC (rev 123938)
+++ trunk/Source/WebCore/platform/efl/NetworkInfoProviderEfl.cpp 2012-07-28 00:30:31 UTC (rev 123939)
@@ -57,8 +57,9 @@
// FIXME : This function should consider cellular network as well. For example, 2G, 3G and 4G.
// See https://bugs.webkit.org/show_bug.cgi?id=89851 for detail.
Eeze_Net* ethNet = eeze_net_new(ethernetInterface);
+ // FIXME: Ethernet is only supported now. If ethNet is null, network is offline.
if (!ethNet)
- return std::numeric_limits<double>::infinity(); // Spec says we should return infinity if unknown
+ return 0; // If network is offline, return 0.
eeze_net_scan(ethNet);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes