Title: [123945] trunk/Source/WebCore
Revision
123945
Author
[email protected]
Date
2012-07-27 18:23:58 -0700 (Fri, 27 Jul 2012)

Log Message

Change constructor with explicit constructor in WebCore/Modules
https://bugs.webkit.org/show_bug.cgi?id=92529

Patch by Gyuyoung Kim <[email protected]> on 2012-07-27
Reviewed by Kentaro Hara.

As a step to let *explicit* keyword add to constructors which have a parameter,
*explicit* keyword is added to Source/WebCore/Modules in order to avoid implicit
type conversion.

No new tests. Covered by existing tests.

* Modules/filesystem/LocalFileSystem.h:
(WebCore::LocalFileSystem::LocalFileSystem):
* Modules/filesystem/Metadata.h:
(WebCore::Metadata::Metadata):
* Modules/filesystem/SyncCallbackHelper.h:
(WebCore::SyncCallbackHelper::SuccessCallbackImpl::SuccessCallbackImpl):
(WebCore::SyncCallbackHelper::ErrorCallbackImpl::ErrorCallbackImpl):
* Modules/mediastream/IceCandidate.h:
(IceCandidate):
* Modules/mediastream/NavigatorUserMediaError.h:
(WebCore::NavigatorUserMediaError::NavigatorUserMediaError):
* Modules/mediastream/SessionDescription.h:
(SessionDescription):
* Modules/mediastream/UserMediaController.h:
(UserMediaController):
* Modules/notifications/NotificationController.h:
(NotificationController):
* Modules/speech/SpeechRecognition.h:
(SpeechRecognition):
* Modules/speech/SpeechRecognitionController.h:
(SpeechRecognitionController):
* Modules/speech/SpeechRecognitionEvent.h:
(SpeechRecognitionEvent):
* Modules/speech/SpeechRecognitionResultList.h:
(SpeechRecognitionResultList):
* Modules/vibration/Vibration.h:
(Vibration):
* Modules/webaudio/AudioBuffer.h:
(AudioBuffer):
* Modules/webaudio/AudioContext.h:
(AudioContext):
* Modules/webaudio/AudioNodeInput.h:
(AudioNodeInput):
* Modules/webaudio/AudioSummingJunction.h:
(AudioSummingJunction):
* Modules/webaudio/BiquadDSPKernel.h:
(WebCore::BiquadDSPKernel::BiquadDSPKernel):
* Modules/webaudio/DefaultAudioDestinationNode.h:
(DefaultAudioDestinationNode):
* Modules/webaudio/DelayDSPKernel.h:
(DelayDSPKernel):
* Modules/webaudio/OfflineAudioCompletionEvent.h:
(OfflineAudioCompletionEvent):
* Modules/webaudio/WaveShaperDSPKernel.h:
(WebCore::WaveShaperDSPKernel::WaveShaperDSPKernel):
* Modules/webaudio/WaveShaperNode.h:
(WaveShaperNode):
* Modules/webaudio/WaveTable.h:
(WaveTable):
* Modules/webdatabase/DatabaseAuthorizer.h:
(DatabaseAuthorizer):
* Modules/webdatabase/DatabaseTask.h:
(Database::DatabaseTransactionTask):
* Modules/webdatabase/DatabaseTracker.h:
(DatabaseTracker):
* Modules/webdatabase/SQLCallbackWrapper.h:
(WebCore::SQLCallbackWrapper::SafeReleaseTask::SafeReleaseTask):
* Modules/webdatabase/SQLException.h:
(WebCore::SQLException::SQLException):
* Modules/websockets/WebSocket.h:
* Modules/websockets/WebSocketExtensionProcessor.h:
(WebCore::WebSocketExtensionProcessor::WebSocketExtensionProcessor):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (123944 => 123945)


--- trunk/Source/WebCore/ChangeLog	2012-07-28 01:21:15 UTC (rev 123944)
+++ trunk/Source/WebCore/ChangeLog	2012-07-28 01:23:58 UTC (rev 123945)
@@ -1,3 +1,79 @@
+2012-07-27  Gyuyoung Kim  <[email protected]>
+
+        Change constructor with explicit constructor in WebCore/Modules
+        https://bugs.webkit.org/show_bug.cgi?id=92529
+
+        Reviewed by Kentaro Hara.
+
+        As a step to let *explicit* keyword add to constructors which have a parameter,
+        *explicit* keyword is added to Source/WebCore/Modules in order to avoid implicit
+        type conversion.
+
+        No new tests. Covered by existing tests.
+
+        * Modules/filesystem/LocalFileSystem.h:
+        (WebCore::LocalFileSystem::LocalFileSystem):
+        * Modules/filesystem/Metadata.h:
+        (WebCore::Metadata::Metadata):
+        * Modules/filesystem/SyncCallbackHelper.h:
+        (WebCore::SyncCallbackHelper::SuccessCallbackImpl::SuccessCallbackImpl):
+        (WebCore::SyncCallbackHelper::ErrorCallbackImpl::ErrorCallbackImpl):
+        * Modules/mediastream/IceCandidate.h:
+        (IceCandidate):
+        * Modules/mediastream/NavigatorUserMediaError.h:
+        (WebCore::NavigatorUserMediaError::NavigatorUserMediaError):
+        * Modules/mediastream/SessionDescription.h:
+        (SessionDescription):
+        * Modules/mediastream/UserMediaController.h:
+        (UserMediaController):
+        * Modules/notifications/NotificationController.h:
+        (NotificationController):
+        * Modules/speech/SpeechRecognition.h:
+        (SpeechRecognition):
+        * Modules/speech/SpeechRecognitionController.h:
+        (SpeechRecognitionController):
+        * Modules/speech/SpeechRecognitionEvent.h:
+        (SpeechRecognitionEvent):
+        * Modules/speech/SpeechRecognitionResultList.h:
+        (SpeechRecognitionResultList):
+        * Modules/vibration/Vibration.h:
+        (Vibration):
+        * Modules/webaudio/AudioBuffer.h:
+        (AudioBuffer):
+        * Modules/webaudio/AudioContext.h:
+        (AudioContext):
+        * Modules/webaudio/AudioNodeInput.h:
+        (AudioNodeInput):
+        * Modules/webaudio/AudioSummingJunction.h:
+        (AudioSummingJunction):
+        * Modules/webaudio/BiquadDSPKernel.h:
+        (WebCore::BiquadDSPKernel::BiquadDSPKernel):
+        * Modules/webaudio/DefaultAudioDestinationNode.h:
+        (DefaultAudioDestinationNode):
+        * Modules/webaudio/DelayDSPKernel.h:
+        (DelayDSPKernel):
+        * Modules/webaudio/OfflineAudioCompletionEvent.h:
+        (OfflineAudioCompletionEvent):
+        * Modules/webaudio/WaveShaperDSPKernel.h:
+        (WebCore::WaveShaperDSPKernel::WaveShaperDSPKernel):
+        * Modules/webaudio/WaveShaperNode.h:
+        (WaveShaperNode):
+        * Modules/webaudio/WaveTable.h:
+        (WaveTable):
+        * Modules/webdatabase/DatabaseAuthorizer.h:
+        (DatabaseAuthorizer):
+        * Modules/webdatabase/DatabaseTask.h:
+        (Database::DatabaseTransactionTask):
+        * Modules/webdatabase/DatabaseTracker.h:
+        (DatabaseTracker):
+        * Modules/webdatabase/SQLCallbackWrapper.h:
+        (WebCore::SQLCallbackWrapper::SafeReleaseTask::SafeReleaseTask):
+        * Modules/webdatabase/SQLException.h:
+        (WebCore::SQLException::SQLException):
+        * Modules/websockets/WebSocket.h:
+        * Modules/websockets/WebSocketExtensionProcessor.h:
+        (WebCore::WebSocketExtensionProcessor::WebSocketExtensionProcessor):
+
 2012-07-27  Kentaro Hara  <[email protected]>
 
         [V8] Optimize Element::getAttributeNS() by replacing String with AtomicString

Modified: trunk/Source/WebCore/Modules/filesystem/LocalFileSystem.h (123944 => 123945)


--- trunk/Source/WebCore/Modules/filesystem/LocalFileSystem.h	2012-07-28 01:21:15 UTC (rev 123944)
+++ trunk/Source/WebCore/Modules/filesystem/LocalFileSystem.h	2012-07-28 01:23:58 UTC (rev 123945)
@@ -69,7 +69,7 @@
 #endif
 
 private:
-    LocalFileSystem(const String& basePath)
+    explicit LocalFileSystem(const String& basePath)
         : m_basePath(basePath)
     {
     }

Modified: trunk/Source/WebCore/Modules/filesystem/Metadata.h (123944 => 123945)


--- trunk/Source/WebCore/Modules/filesystem/Metadata.h	2012-07-28 01:21:15 UTC (rev 123944)
+++ trunk/Source/WebCore/Modules/filesystem/Metadata.h	2012-07-28 01:23:58 UTC (rev 123945)
@@ -55,7 +55,7 @@
     unsigned long long size() const { return static_cast<unsigned long long>(m_platformMetadata.length); }
 
 private:
-    Metadata(const FileMetadata& platformMetadata)
+    explicit Metadata(const FileMetadata& platformMetadata)
         : m_platformMetadata(platformMetadata)
     {
     }

Modified: trunk/Source/WebCore/Modules/filesystem/SyncCallbackHelper.h (123944 => 123945)


--- trunk/Source/WebCore/Modules/filesystem/SyncCallbackHelper.h	2012-07-28 01:21:15 UTC (rev 123944)
+++ trunk/Source/WebCore/Modules/filesystem/SyncCallbackHelper.h	2012-07-28 01:23:58 UTC (rev 123945)
@@ -109,7 +109,7 @@
         }
 
     private:
-        SuccessCallbackImpl(HelperType* helper)
+        explicit SuccessCallbackImpl(HelperType* helper)
             : m_helper(helper)
         {
         }
@@ -131,7 +131,7 @@
         }
 
     private:
-        ErrorCallbackImpl(HelperType* helper)
+        explicit ErrorCallbackImpl(HelperType* helper)
             : m_helper(helper)
         {
         }

Modified: trunk/Source/WebCore/Modules/mediastream/IceCandidate.h (123944 => 123945)


--- trunk/Source/WebCore/Modules/mediastream/IceCandidate.h	2012-07-28 01:21:15 UTC (rev 123944)
+++ trunk/Source/WebCore/Modules/mediastream/IceCandidate.h	2012-07-28 01:23:58 UTC (rev 123945)
@@ -56,7 +56,7 @@
     IceCandidateDescriptor* descriptor();
 
 private:
-    IceCandidate(PassRefPtr<IceCandidateDescriptor>);
+    explicit IceCandidate(PassRefPtr<IceCandidateDescriptor>);
 
     RefPtr<IceCandidateDescriptor> m_descriptor;
 };

Modified: trunk/Source/WebCore/Modules/mediastream/NavigatorUserMediaError.h (123944 => 123945)


--- trunk/Source/WebCore/Modules/mediastream/NavigatorUserMediaError.h	2012-07-28 01:21:15 UTC (rev 123944)
+++ trunk/Source/WebCore/Modules/mediastream/NavigatorUserMediaError.h	2012-07-28 01:23:58 UTC (rev 123945)
@@ -49,7 +49,7 @@
     ErrorCode code() const { return m_code; }
 
 private:
-    NavigatorUserMediaError(ErrorCode code) : m_code(code) { }
+    explicit NavigatorUserMediaError(ErrorCode code) : m_code(code) { }
 
     ErrorCode m_code;
 };

Modified: trunk/Source/WebCore/Modules/mediastream/SessionDescription.h (123944 => 123945)


--- trunk/Source/WebCore/Modules/mediastream/SessionDescription.h	2012-07-28 01:21:15 UTC (rev 123944)
+++ trunk/Source/WebCore/Modules/mediastream/SessionDescription.h	2012-07-28 01:23:58 UTC (rev 123945)
@@ -55,7 +55,7 @@
     SessionDescriptionDescriptor* descriptor();
 
 private:
-    SessionDescription(PassRefPtr<SessionDescriptionDescriptor>);
+    explicit SessionDescription(PassRefPtr<SessionDescriptionDescriptor>);
 
     RefPtr<SessionDescriptionDescriptor> m_descriptor;
 };

Modified: trunk/Source/WebCore/Modules/mediastream/UserMediaController.h (123944 => 123945)


--- trunk/Source/WebCore/Modules/mediastream/UserMediaController.h	2012-07-28 01:21:15 UTC (rev 123944)
+++ trunk/Source/WebCore/Modules/mediastream/UserMediaController.h	2012-07-28 01:23:58 UTC (rev 123945)
@@ -46,7 +46,7 @@
     static UserMediaController* from(Page* page) { return static_cast<UserMediaController*>(Supplement<Page>::from(page, supplementName())); }
 
 protected:
-    UserMediaController(UserMediaClient*);
+    explicit UserMediaController(UserMediaClient*);
 
 private:
     UserMediaClient* m_client;

Modified: trunk/Source/WebCore/Modules/notifications/NotificationController.h (123944 => 123945)


--- trunk/Source/WebCore/Modules/notifications/NotificationController.h	2012-07-28 01:21:15 UTC (rev 123944)
+++ trunk/Source/WebCore/Modules/notifications/NotificationController.h	2012-07-28 01:23:58 UTC (rev 123945)
@@ -49,7 +49,7 @@
     NotificationClient* client() { return m_client; }
     
 private:
-    NotificationController(NotificationClient*);
+    explicit NotificationController(NotificationClient*);
 
     NotificationClient* m_client;
 };

Modified: trunk/Source/WebCore/Modules/speech/SpeechRecognition.h (123944 => 123945)


--- trunk/Source/WebCore/Modules/speech/SpeechRecognition.h	2012-07-28 01:21:15 UTC (rev 123944)
+++ trunk/Source/WebCore/Modules/speech/SpeechRecognition.h	2012-07-28 01:23:58 UTC (rev 123945)
@@ -104,7 +104,7 @@
 private:
     friend class RefCounted<SpeechRecognition>;
 
-    SpeechRecognition(ScriptExecutionContext*);
+    explicit SpeechRecognition(ScriptExecutionContext*);
 
 
     // EventTarget

Modified: trunk/Source/WebCore/Modules/speech/SpeechRecognitionController.h (123944 => 123945)


--- trunk/Source/WebCore/Modules/speech/SpeechRecognitionController.h	2012-07-28 01:21:15 UTC (rev 123944)
+++ trunk/Source/WebCore/Modules/speech/SpeechRecognitionController.h	2012-07-28 01:23:58 UTC (rev 123945)
@@ -51,7 +51,7 @@
     static SpeechRecognitionController* from(Page* page) { return static_cast<SpeechRecognitionController*>(Supplement<Page>::from(page, supplementName())); }
 
 private:
-    SpeechRecognitionController(SpeechRecognitionClient*);
+    explicit SpeechRecognitionController(SpeechRecognitionClient*);
 
     SpeechRecognitionClient* m_client;
 };

Modified: trunk/Source/WebCore/Modules/speech/SpeechRecognitionEvent.h (123944 => 123945)


--- trunk/Source/WebCore/Modules/speech/SpeechRecognitionEvent.h	2012-07-28 01:21:15 UTC (rev 123944)
+++ trunk/Source/WebCore/Modules/speech/SpeechRecognitionEvent.h	2012-07-28 01:23:58 UTC (rev 123945)
@@ -68,7 +68,7 @@
     SpeechRecognitionEvent();
     SpeechRecognitionEvent(const AtomicString&, const SpeechRecognitionEventInit&);
     SpeechRecognitionEvent(const AtomicString& eventName, PassRefPtr<SpeechRecognitionResult>, short resultIndex, PassRefPtr<SpeechRecognitionResultList> resultHistory);
-    SpeechRecognitionEvent(PassRefPtr<SpeechRecognitionError>);
+    explicit SpeechRecognitionEvent(PassRefPtr<SpeechRecognitionError>);
 
     RefPtr<SpeechRecognitionResult> m_result;
     short m_resultIndex;

Modified: trunk/Source/WebCore/Modules/speech/SpeechRecognitionResultList.h (123944 => 123945)


--- trunk/Source/WebCore/Modules/speech/SpeechRecognitionResultList.h	2012-07-28 01:21:15 UTC (rev 123944)
+++ trunk/Source/WebCore/Modules/speech/SpeechRecognitionResultList.h	2012-07-28 01:23:58 UTC (rev 123945)
@@ -42,7 +42,7 @@
     SpeechRecognitionResult* item(unsigned long index);
 
 private:
-    SpeechRecognitionResultList(const Vector<RefPtr<SpeechRecognitionResult> >&);
+    explicit SpeechRecognitionResultList(const Vector<RefPtr<SpeechRecognitionResult> >&);
 
     Vector<RefPtr<SpeechRecognitionResult> > m_results;
 };

Modified: trunk/Source/WebCore/Modules/vibration/Vibration.h (123944 => 123945)


--- trunk/Source/WebCore/Modules/vibration/Vibration.h	2012-07-28 01:21:15 UTC (rev 123944)
+++ trunk/Source/WebCore/Modules/vibration/Vibration.h	2012-07-28 01:23:58 UTC (rev 123945)
@@ -36,7 +36,7 @@
 public:
     typedef Vector<unsigned long> VibrationPattern;
 
-    Vibration(VibrationClient*);
+    explicit Vibration(VibrationClient*);
     ~Vibration();
 
     static PassOwnPtr<Vibration> create(VibrationClient*);

Modified: trunk/Source/WebCore/Modules/webaudio/AudioBuffer.h (123944 => 123945)


--- trunk/Source/WebCore/Modules/webaudio/AudioBuffer.h	2012-07-28 01:21:15 UTC (rev 123944)
+++ trunk/Source/WebCore/Modules/webaudio/AudioBuffer.h	2012-07-28 01:23:58 UTC (rev 123945)
@@ -67,7 +67,7 @@
     
 protected:
     AudioBuffer(unsigned numberOfChannels, size_t numberOfFrames, float sampleRate);
-    AudioBuffer(AudioBus* bus);
+    explicit AudioBuffer(AudioBus*);
 
     double m_gain; // scalar gain
     float m_sampleRate;

Modified: trunk/Source/WebCore/Modules/webaudio/AudioContext.h (123944 => 123945)


--- trunk/Source/WebCore/Modules/webaudio/AudioContext.h	2012-07-28 01:21:15 UTC (rev 123944)
+++ trunk/Source/WebCore/Modules/webaudio/AudioContext.h	2012-07-28 01:23:58 UTC (rev 123945)
@@ -243,7 +243,7 @@
     static unsigned s_hardwareContextCount;
     
 private:
-    AudioContext(Document*);
+    explicit AudioContext(Document*);
     AudioContext(Document*, unsigned numberOfChannels, size_t numberOfFrames, float sampleRate);
     void constructCommon();
 

Modified: trunk/Source/WebCore/Modules/webaudio/AudioNodeInput.h (123944 => 123945)


--- trunk/Source/WebCore/Modules/webaudio/AudioNodeInput.h	2012-07-28 01:21:15 UTC (rev 123944)
+++ trunk/Source/WebCore/Modules/webaudio/AudioNodeInput.h	2012-07-28 01:23:58 UTC (rev 123945)
@@ -42,7 +42,7 @@
 
 class AudioNodeInput : public AudioSummingJunction {
 public:
-    AudioNodeInput(AudioNode*);
+    explicit AudioNodeInput(AudioNode*);
 
     // AudioSummingJunction
     virtual bool canUpdateState() OVERRIDE { return !node()->isMarkedForDeletion(); }

Modified: trunk/Source/WebCore/Modules/webaudio/AudioSummingJunction.h (123944 => 123945)


--- trunk/Source/WebCore/Modules/webaudio/AudioSummingJunction.h	2012-07-28 01:21:15 UTC (rev 123944)
+++ trunk/Source/WebCore/Modules/webaudio/AudioSummingJunction.h	2012-07-28 01:23:58 UTC (rev 123945)
@@ -38,7 +38,7 @@
 
 class AudioSummingJunction {
 public:
-    AudioSummingJunction(AudioContext*);
+    explicit AudioSummingJunction(AudioContext*);
     virtual ~AudioSummingJunction();
 
     // Can be called from any thread.

Modified: trunk/Source/WebCore/Modules/webaudio/BiquadDSPKernel.h (123944 => 123945)


--- trunk/Source/WebCore/Modules/webaudio/BiquadDSPKernel.h	2012-07-28 01:21:15 UTC (rev 123944)
+++ trunk/Source/WebCore/Modules/webaudio/BiquadDSPKernel.h	2012-07-28 01:23:58 UTC (rev 123945)
@@ -37,7 +37,7 @@
 
 class BiquadDSPKernel : public AudioDSPKernel {
 public:  
-    BiquadDSPKernel(BiquadProcessor* processor)
+    explicit BiquadDSPKernel(BiquadProcessor* processor)
     : AudioDSPKernel(processor)
     {
     }

Modified: trunk/Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.h (123944 => 123945)


--- trunk/Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.h	2012-07-28 01:21:15 UTC (rev 123944)
+++ trunk/Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.h	2012-07-28 01:23:58 UTC (rev 123945)
@@ -48,7 +48,7 @@
     virtual void startRendering();
     
 private:
-    DefaultAudioDestinationNode(AudioContext*);
+    explicit DefaultAudioDestinationNode(AudioContext*);
 
     OwnPtr<AudioDestination> m_destination;
 };

Modified: trunk/Source/WebCore/Modules/webaudio/DelayDSPKernel.h (123944 => 123945)


--- trunk/Source/WebCore/Modules/webaudio/DelayDSPKernel.h	2012-07-28 01:21:15 UTC (rev 123944)
+++ trunk/Source/WebCore/Modules/webaudio/DelayDSPKernel.h	2012-07-28 01:23:58 UTC (rev 123945)
@@ -35,7 +35,7 @@
     
 class DelayDSPKernel : public AudioDSPKernel {
 public:  
-    DelayDSPKernel(DelayProcessor*);
+    explicit DelayDSPKernel(DelayProcessor*);
     DelayDSPKernel(double maxDelayTime, float sampleRate);
     
     virtual void process(const float* source, float* destination, size_t framesToProcess);

Modified: trunk/Source/WebCore/Modules/webaudio/OfflineAudioCompletionEvent.h (123944 => 123945)


--- trunk/Source/WebCore/Modules/webaudio/OfflineAudioCompletionEvent.h	2012-07-28 01:21:15 UTC (rev 123944)
+++ trunk/Source/WebCore/Modules/webaudio/OfflineAudioCompletionEvent.h	2012-07-28 01:23:58 UTC (rev 123945)
@@ -47,7 +47,7 @@
 
 private:
     OfflineAudioCompletionEvent();
-    OfflineAudioCompletionEvent(PassRefPtr<AudioBuffer> renderedBuffer);
+    explicit OfflineAudioCompletionEvent(PassRefPtr<AudioBuffer> renderedBuffer);
 
     RefPtr<AudioBuffer> m_renderedBuffer;
 };

Modified: trunk/Source/WebCore/Modules/webaudio/WaveShaperDSPKernel.h (123944 => 123945)


--- trunk/Source/WebCore/Modules/webaudio/WaveShaperDSPKernel.h	2012-07-28 01:21:15 UTC (rev 123944)
+++ trunk/Source/WebCore/Modules/webaudio/WaveShaperDSPKernel.h	2012-07-28 01:23:58 UTC (rev 123945)
@@ -36,7 +36,7 @@
 
 class WaveShaperDSPKernel : public AudioDSPKernel {
 public:  
-    WaveShaperDSPKernel(WaveShaperProcessor* processor)
+    explicit WaveShaperDSPKernel(WaveShaperProcessor* processor)
     : AudioDSPKernel(processor)
     {
     }

Modified: trunk/Source/WebCore/Modules/webaudio/WaveShaperNode.h (123944 => 123945)


--- trunk/Source/WebCore/Modules/webaudio/WaveShaperNode.h	2012-07-28 01:21:15 UTC (rev 123944)
+++ trunk/Source/WebCore/Modules/webaudio/WaveShaperNode.h	2012-07-28 01:23:58 UTC (rev 123945)
@@ -44,7 +44,7 @@
     Float32Array* curve();
 
 private:    
-    WaveShaperNode(AudioContext*);    
+    explicit WaveShaperNode(AudioContext*);    
 
     WaveShaperProcessor* waveShaperProcessor() { return static_cast<WaveShaperProcessor*>(processor()); }
 };

Modified: trunk/Source/WebCore/Modules/webaudio/WaveTable.h (123944 => 123945)


--- trunk/Source/WebCore/Modules/webaudio/WaveTable.h	2012-07-28 01:21:15 UTC (rev 123944)
+++ trunk/Source/WebCore/Modules/webaudio/WaveTable.h	2012-07-28 01:23:58 UTC (rev 123945)
@@ -64,7 +64,7 @@
     float sampleRate() const { return m_sampleRate; }
 
 private:
-    WaveTable(float sampleRate);
+    explicit WaveTable(float sampleRate);
 
     void generateBasicWaveform(int);
 

Modified: trunk/Source/WebCore/Modules/webdatabase/DatabaseAuthorizer.h (123944 => 123945)


--- trunk/Source/WebCore/Modules/webdatabase/DatabaseAuthorizer.h	2012-07-28 01:21:15 UTC (rev 123944)
+++ trunk/Source/WebCore/Modules/webdatabase/DatabaseAuthorizer.h	2012-07-28 01:23:58 UTC (rev 123945)
@@ -104,7 +104,7 @@
     bool hadDeletes() const { return m_hadDeletes; }
 
 private:
-    DatabaseAuthorizer(const String& databaseInfoTableName);
+    explicit DatabaseAuthorizer(const String& databaseInfoTableName);
     void addWhitelistedFunctions();
     int denyBasedOnTableName(const String&) const;
     int updateDeletesBasedOnTableName(const String&);

Modified: trunk/Source/WebCore/Modules/webdatabase/DatabaseTask.h (123944 => 123945)


--- trunk/Source/WebCore/Modules/webdatabase/DatabaseTask.h	2012-07-28 01:21:15 UTC (rev 123944)
+++ trunk/Source/WebCore/Modules/webdatabase/DatabaseTask.h	2012-07-28 01:23:58 UTC (rev 123945)
@@ -146,7 +146,7 @@
     SQLTransaction* transaction() const { return m_transaction.get(); }
 
 private:
-    DatabaseTransactionTask(PassRefPtr<SQLTransaction>);
+    explicit DatabaseTransactionTask(PassRefPtr<SQLTransaction>);
 
     virtual void doPerformTask();
 #if !LOG_DISABLED

Modified: trunk/Source/WebCore/Modules/webdatabase/DatabaseTracker.h (123944 => 123945)


--- trunk/Source/WebCore/Modules/webdatabase/DatabaseTracker.h	2012-07-28 01:21:15 UTC (rev 123944)
+++ trunk/Source/WebCore/Modules/webdatabase/DatabaseTracker.h	2012-07-28 01:23:58 UTC (rev 123945)
@@ -82,7 +82,7 @@
     void interruptAllDatabasesForContext(const ScriptExecutionContext*);
 
 private:
-    DatabaseTracker(const String& databasePath);
+    explicit DatabaseTracker(const String& databasePath);
 
 #if !PLATFORM(CHROMIUM)
 public:

Modified: trunk/Source/WebCore/Modules/webdatabase/SQLCallbackWrapper.h (123944 => 123945)


--- trunk/Source/WebCore/Modules/webdatabase/SQLCallbackWrapper.h	2012-07-28 01:21:15 UTC (rev 123944)
+++ trunk/Source/WebCore/Modules/webdatabase/SQLCallbackWrapper.h	2012-07-28 01:23:58 UTC (rev 123945)
@@ -105,7 +105,7 @@
         virtual bool isCleanupTask() const { return true; }
 
     private:
-        SafeReleaseTask(T* callbackToRelease)
+        explicit SafeReleaseTask(T* callbackToRelease)
             : m_callbackToRelease(callbackToRelease)
         {
         }

Modified: trunk/Source/WebCore/Modules/webdatabase/SQLException.h (123944 => 123945)


--- trunk/Source/WebCore/Modules/webdatabase/SQLException.h	2012-07-28 01:21:15 UTC (rev 123944)
+++ trunk/Source/WebCore/Modules/webdatabase/SQLException.h	2012-07-28 01:23:58 UTC (rev 123945)
@@ -61,7 +61,7 @@
     static bool initializeDescription(ExceptionCode, ExceptionCodeDescription*);
 
 private:
-    SQLException(const ExceptionCodeDescription& description)
+    explicit SQLException(const ExceptionCodeDescription& description)
         : ExceptionBase(description)
     {
     }

Modified: trunk/Source/WebCore/Modules/websockets/WebSocket.h (123944 => 123945)


--- trunk/Source/WebCore/Modules/websockets/WebSocket.h	2012-07-28 01:21:15 UTC (rev 123944)
+++ trunk/Source/WebCore/Modules/websockets/WebSocket.h	2012-07-28 01:23:58 UTC (rev 123945)
@@ -113,7 +113,7 @@
     virtual void didClose(unsigned long unhandledBufferedAmount, ClosingHandshakeCompletionStatus, unsigned short code, const String& reason) OVERRIDE;
 
 private:
-    WebSocket(ScriptExecutionContext*);
+    explicit WebSocket(ScriptExecutionContext*);
 
     virtual void refEventTarget() { ref(); }
     virtual void derefEventTarget() { deref(); }

Modified: trunk/Source/WebCore/Modules/websockets/WebSocketExtensionProcessor.h (123944 => 123945)


--- trunk/Source/WebCore/Modules/websockets/WebSocketExtensionProcessor.h	2012-07-28 01:21:15 UTC (rev 123944)
+++ trunk/Source/WebCore/Modules/websockets/WebSocketExtensionProcessor.h	2012-07-28 01:23:58 UTC (rev 123945)
@@ -58,7 +58,7 @@
     virtual String failureReason() { return "Extension " + m_extensionToken + " failed"; }
 
 protected:
-    WebSocketExtensionProcessor(const String& extensionToken)
+    explicit WebSocketExtensionProcessor(const String& extensionToken)
         : m_extensionToken(extensionToken)
     {
     }
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to