Title: [124003] trunk
- Revision
- 124003
- Author
- [email protected]
- Date
- 2012-07-30 01:28:07 -0700 (Mon, 30 Jul 2012)
Log Message
REGRESSION (r123767): platform/gtk/accessibility/object-with-title.html failing on GTK
https://bugs.webkit.org/show_bug.cgi?id=92477
Reviewed by Chris Fleizach.
Source/WebCore:
Consider title and accessibilityDescription together with helpText to
decide whether an object should be exposed in the accessibility tree.
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
LayoutTests:
Remove passing test from TestExpectations.
* platform/gtk/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (124002 => 124003)
--- trunk/LayoutTests/ChangeLog 2012-07-30 08:18:07 UTC (rev 124002)
+++ trunk/LayoutTests/ChangeLog 2012-07-30 08:28:07 UTC (rev 124003)
@@ -1,3 +1,14 @@
+2012-07-30 Mario Sanchez Prada <[email protected]>
+
+ REGRESSION (r123767): platform/gtk/accessibility/object-with-title.html failing on GTK
+ https://bugs.webkit.org/show_bug.cgi?id=92477
+
+ Reviewed by Chris Fleizach.
+
+ Remove passing test from TestExpectations.
+
+ * platform/gtk/TestExpectations:
+
2012-07-29 Vsevolod Vlasov <[email protected]>
Web Inspector: Resource agent's reference to cached resources should be weak.
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (124002 => 124003)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2012-07-30 08:18:07 UTC (rev 124002)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2012-07-30 08:28:07 UTC (rev 124003)
@@ -1261,7 +1261,6 @@
// This test depends on subpixel layout.
BUGWK92352 : css3/flexbox/flex-rounding.html = TEXT
-BUGWK92477 : platform/gtk/accessibility/object-with-title.html = TEXT
//////////////////////////////////////////////////////////////////////////////////////////
// End of Tests failing
Modified: trunk/Source/WebCore/ChangeLog (124002 => 124003)
--- trunk/Source/WebCore/ChangeLog 2012-07-30 08:18:07 UTC (rev 124002)
+++ trunk/Source/WebCore/ChangeLog 2012-07-30 08:28:07 UTC (rev 124003)
@@ -1,3 +1,16 @@
+2012-07-30 Mario Sanchez Prada <[email protected]>
+
+ REGRESSION (r123767): platform/gtk/accessibility/object-with-title.html failing on GTK
+ https://bugs.webkit.org/show_bug.cgi?id=92477
+
+ Reviewed by Chris Fleizach.
+
+ Consider title and accessibilityDescription together with helpText to
+ decide whether an object should be exposed in the accessibility tree.
+
+ * accessibility/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
+
2012-07-29 Vsevolod Vlasov <[email protected]>
Web Inspector: Resource agent's reference to cached resources should be weak.
Modified: trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp (124002 => 124003)
--- trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2012-07-30 08:18:07 UTC (rev 124002)
+++ trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2012-07-30 08:28:07 UTC (rev 124003)
@@ -1996,9 +1996,11 @@
if (isWebArea() || m_renderer->isListMarker())
return false;
- // Using the help text to decide an element's visibility is not as definitive
- // as previous checks, so this should remain as one of the last.
- if (!helpText().isEmpty())
+ // Using the help text, title or accessibility description (so we
+ // check if there's some kind of accessible name for the element)
+ // to decide an element's visibility is not as definitive as
+ // previous checks, so this should remain as one of the last.
+ if (!helpText().isEmpty() || !title().isEmpty() || !accessibilityDescription().isEmpty())
return false;
// By default, objects should be ignored so that the AX hierarchy is not
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
