Title: [124162] trunk/Source/WebCore
Revision
124162
Author
[email protected]
Date
2012-07-30 20:15:20 -0700 (Mon, 30 Jul 2012)

Log Message

fillWithEmptyClients method should also initialize chromeClient with EmptyChromeClient
https://bugs.webkit.org/show_bug.cgi?id=92703

Patch by Vivek Galatage <[email protected]> on 2012-07-30
Reviewed by Kent Tamura.

fillWithEmptyClients should also intialize PageClients.chromeClient with EmptyChromeClient
as its required for creating a Empty page and to minimize the exported symbols.

No new tests as no change in functionality.

* loader/EmptyClients.cpp:
(WebCore::fillWithEmptyClients):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (124161 => 124162)


--- trunk/Source/WebCore/ChangeLog	2012-07-31 03:10:09 UTC (rev 124161)
+++ trunk/Source/WebCore/ChangeLog	2012-07-31 03:15:20 UTC (rev 124162)
@@ -1,3 +1,18 @@
+2012-07-30  Vivek Galatage  <[email protected]>
+
+        fillWithEmptyClients method should also initialize chromeClient with EmptyChromeClient
+        https://bugs.webkit.org/show_bug.cgi?id=92703
+
+        Reviewed by Kent Tamura.
+
+        fillWithEmptyClients should also intialize PageClients.chromeClient with EmptyChromeClient 
+        as its required for creating a Empty page and to minimize the exported symbols.
+
+        No new tests as no change in functionality.
+
+        * loader/EmptyClients.cpp:
+        (WebCore::fillWithEmptyClients):
+
 2012-07-30  Adrienne Walker  <[email protected]>
 
         [chromium] Wrap ScrollbarLayerChromium in WebScrollbarLayer

Modified: trunk/Source/WebCore/loader/EmptyClients.cpp (124161 => 124162)


--- trunk/Source/WebCore/loader/EmptyClients.cpp	2012-07-31 03:10:09 UTC (rev 124161)
+++ trunk/Source/WebCore/loader/EmptyClients.cpp	2012-07-31 03:15:20 UTC (rev 124162)
@@ -47,6 +47,9 @@
 
 void fillWithEmptyClients(Page::PageClients& pageClients)
 {
+    static ChromeClient* dummyChromeClient = adoptPtr(new EmptyChromeClient).leakPtr();
+    pageClients.chromeClient = dummyChromeClient;
+
 #if ENABLE(CONTEXT_MENUS)
     static ContextMenuClient* dummyContextMenuClient = adoptPtr(new EmptyContextMenuClient).leakPtr();
     pageClients.contextMenuClient = dummyContextMenuClient;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to