Title: [124177] trunk/Source/WebKit/gtk
- Revision
- 124177
- Author
- [email protected]
- Date
- 2012-07-30 23:52:49 -0700 (Mon, 30 Jul 2012)
Log Message
[GTK] New lines automatically and repeatedly added to list items in Etherpad
https://bugs.webkit.org/show_bug.cgi?id=89971
Patch by Martin Robinson <[email protected]> on 2012-07-30
Reviewed by Ryosuke Niwa.
Disable the deletion UI by default. This UI, which was enabled as a side-effect
of the addition of the private editing API, seems to expose a bug in Etherpad
which causes the continuous insertion of bullet points.
* WebCoreSupport/EditorClientGtk.cpp:
(WebKit::EditorClient::shouldShowDeleteInterface): Disable the deletion UI by default.
Modified Paths
Diff
Modified: trunk/Source/WebKit/gtk/ChangeLog (124176 => 124177)
--- trunk/Source/WebKit/gtk/ChangeLog 2012-07-31 06:27:00 UTC (rev 124176)
+++ trunk/Source/WebKit/gtk/ChangeLog 2012-07-31 06:52:49 UTC (rev 124177)
@@ -1,3 +1,17 @@
+2012-07-30 Martin Robinson <[email protected]>
+
+ [GTK] New lines automatically and repeatedly added to list items in Etherpad
+ https://bugs.webkit.org/show_bug.cgi?id=89971
+
+ Reviewed by Ryosuke Niwa.
+
+ Disable the deletion UI by default. This UI, which was enabled as a side-effect
+ of the addition of the private editing API, seems to expose a bug in Etherpad
+ which causes the continuous insertion of bullet points.
+
+ * WebCoreSupport/EditorClientGtk.cpp:
+ (WebKit::EditorClient::shouldShowDeleteInterface): Disable the deletion UI by default.
+
2012-07-30 Sheriff Bot <[email protected]>
Unreviewed, rolling out r123966 and r123967.
Modified: trunk/Source/WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp (124176 => 124177)
--- trunk/Source/WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp 2012-07-31 06:27:00 UTC (rev 124176)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp 2012-07-31 06:52:49 UTC (rev 124177)
@@ -96,7 +96,7 @@
bool EditorClient::shouldShowDeleteInterface(HTMLElement* element)
{
- gboolean accept = TRUE;
+ gboolean accept = FALSE;
GRefPtr<WebKitDOMHTMLElement> kitElement(adoptGRef(kit(element)));
g_signal_emit_by_name(m_webView, "should-show-delete-interface-for-element", kitElement.get(), &accept);
return accept;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
