Title: [124331] trunk/Source/WebKit/blackberry
- Revision
- 124331
- Author
- [email protected]
- Date
- 2012-08-01 06:39:45 -0700 (Wed, 01 Aug 2012)
Log Message
[BlackBerry] Disable tap highlight when transparent color is specified
https://bugs.webkit.org/show_bug.cgi?id=92849
Patch by Arvid Nilsson <[email protected]> on 2012-08-01
Reviewed by Antonio Gomes.
When the web page specifies -webkit-tap-highlight-color:rgba(0,0,0,0)
or any color with alpha value 0, we should disable the tap highlight.
* WebKitSupport/DefaultTapHighlight.cpp:
(BlackBerry::WebKit::DefaultTapHighlight::draw):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (124330 => 124331)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-08-01 13:29:59 UTC (rev 124330)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-08-01 13:39:45 UTC (rev 124331)
@@ -1,3 +1,16 @@
+2012-08-01 Arvid Nilsson <[email protected]>
+
+ [BlackBerry] Disable tap highlight when transparent color is specified
+ https://bugs.webkit.org/show_bug.cgi?id=92849
+
+ Reviewed by Antonio Gomes.
+
+ When the web page specifies -webkit-tap-highlight-color:rgba(0,0,0,0)
+ or any color with alpha value 0, we should disable the tap highlight.
+
+ * WebKitSupport/DefaultTapHighlight.cpp:
+ (BlackBerry::WebKit::DefaultTapHighlight::draw):
+
2012-07-31 Robin Cao <[email protected]>
[BlackBerry] Pass all file chooser settings to clients
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/DefaultTapHighlight.cpp (124330 => 124331)
--- trunk/Source/WebKit/blackberry/WebKitSupport/DefaultTapHighlight.cpp 2012-08-01 13:29:59 UTC (rev 124330)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/DefaultTapHighlight.cpp 2012-08-01 13:39:45 UTC (rev 124331)
@@ -61,6 +61,12 @@
if (rect.isEmpty())
return;
+ // Transparent color means disable the tap highlight.
+ if (!m_color.alpha()) {
+ hide();
+ return;
+ }
+
{
MutexLocker lock(m_mutex);
m_visible = true;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
