Diff
Modified: trunk/LayoutTests/ChangeLog (124357 => 124358)
--- trunk/LayoutTests/ChangeLog 2012-08-01 19:42:04 UTC (rev 124357)
+++ trunk/LayoutTests/ChangeLog 2012-08-01 19:51:04 UTC (rev 124358)
@@ -1,3 +1,15 @@
+2012-08-01 Kihong Kwon <[email protected]>
+
+ Dropping webkit prefix from Vibration API
+ https://bugs.webkit.org/show_bug.cgi?id=92840
+
+ Reviewed by Adam Barth.
+
+ Remove webkit prefix from navigator.webkitVibrate().
+
+ * fast/dom/navigator-vibration-expected.txt:
+ * fast/dom/navigator-vibration.html:
+
2012-08-01 Allan Sandfeld Jensen <[email protected]>
Clean-up touchadjustment tests.
Modified: trunk/LayoutTests/fast/dom/navigator-vibration-expected.txt (124357 => 124358)
--- trunk/LayoutTests/fast/dom/navigator-vibration-expected.txt 2012-08-01 19:42:04 UTC (rev 124357)
+++ trunk/LayoutTests/fast/dom/navigator-vibration-expected.txt 2012-08-01 19:51:04 UTC (rev 124358)
@@ -3,12 +3,12 @@
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-PASS navigator.webkitVibrate(0); is undefined
-PASS navigator.webkitVibrate([]); is undefined
-PASS navigator.webkitVibrate(1000); is undefined
-PASS navigator.webkitVibrate([1000, 300, 500]); is undefined
-PASS navigator.webkitVibrate(4294967295); is undefined
-PASS navigator.webkitVibrate(); threw exception TypeError: Type error.
+PASS navigator.vibrate(0); is undefined
+PASS navigator.vibrate([]); is undefined
+PASS navigator.vibrate(1000); is undefined
+PASS navigator.vibrate([1000, 300, 500]); is undefined
+PASS navigator.vibrate(4294967295); is undefined
+PASS navigator.vibrate(); threw exception TypeError: Type error.
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/fast/dom/navigator-vibration.html (124357 => 124358)
--- trunk/LayoutTests/fast/dom/navigator-vibration.html 2012-08-01 19:42:04 UTC (rev 124357)
+++ trunk/LayoutTests/fast/dom/navigator-vibration.html 2012-08-01 19:51:04 UTC (rev 124358)
@@ -6,12 +6,12 @@
<script>
description('Test for the Vibration API.');
-shouldBe("navigator.webkitVibrate(0);", "undefined");
-shouldBe("navigator.webkitVibrate([]);", "undefined");
-shouldBe("navigator.webkitVibrate(1000);", "undefined");
-shouldBe("navigator.webkitVibrate([1000, 300, 500]);", "undefined");
-shouldBe("navigator.webkitVibrate(4294967295);", "undefined");
-shouldThrow("navigator.webkitVibrate();");
+shouldBe("navigator.vibrate(0);", "undefined");
+shouldBe("navigator.vibrate([]);", "undefined");
+shouldBe("navigator.vibrate(1000);", "undefined");
+shouldBe("navigator.vibrate([1000, 300, 500]);", "undefined");
+shouldBe("navigator.vibrate(4294967295);", "undefined");
+shouldThrow("navigator.vibrate();");
</script>
<script src=""
</body>
Modified: trunk/Source/WebCore/ChangeLog (124357 => 124358)
--- trunk/Source/WebCore/ChangeLog 2012-08-01 19:42:04 UTC (rev 124357)
+++ trunk/Source/WebCore/ChangeLog 2012-08-01 19:51:04 UTC (rev 124358)
@@ -1,3 +1,22 @@
+2012-08-01 Kihong Kwon <[email protected]>
+
+ Dropping webkit prefix from Vibration API
+ https://bugs.webkit.org/show_bug.cgi?id=92840
+
+ Reviewed by Adam Barth.
+
+ Remove webkit prefix from navigator.webkitVibrate().
+ - Vibration API have been entered CR already.
+ - Firefox already implements Vibration API.
+
+ No new tests. Covered by fast/dom/navigator-vibration.html
+
+ * Modules/vibration/NavigatorVibration.cpp:
+ (WebCore::NavigatorVibration::vibrate):
+ * Modules/vibration/NavigatorVibration.h:
+ (NavigatorVibration):
+ * Modules/vibration/NavigatorVibration.idl:
+
2012-08-01 Kwang Yul Seo <[email protected]>
Read tag names and attributes from the saved tokens in HTMLFormattingElementList::closestElementInScopeWithName(const AtomicString&)
Modified: trunk/Source/WebCore/Modules/vibration/NavigatorVibration.cpp (124357 => 124358)
--- trunk/Source/WebCore/Modules/vibration/NavigatorVibration.cpp 2012-08-01 19:42:04 UTC (rev 124357)
+++ trunk/Source/WebCore/Modules/vibration/NavigatorVibration.cpp 2012-08-01 19:51:04 UTC (rev 124358)
@@ -39,7 +39,7 @@
{
}
-void NavigatorVibration::webkitVibrate(Navigator* navigator, unsigned long time, ExceptionCode& ec)
+void NavigatorVibration::vibrate(Navigator* navigator, unsigned long time, ExceptionCode& ec)
{
if (!navigator->frame()->page())
return;
@@ -57,7 +57,7 @@
Vibration::from(navigator->frame()->page())->vibrate(time);
}
-void NavigatorVibration::webkitVibrate(Navigator* navigator, const VibrationPattern& pattern, ExceptionCode& ec)
+void NavigatorVibration::vibrate(Navigator* navigator, const VibrationPattern& pattern, ExceptionCode& ec)
{
if (!navigator->frame()->page())
return;
Modified: trunk/Source/WebCore/Modules/vibration/NavigatorVibration.h (124357 => 124358)
--- trunk/Source/WebCore/Modules/vibration/NavigatorVibration.h 2012-08-01 19:42:04 UTC (rev 124357)
+++ trunk/Source/WebCore/Modules/vibration/NavigatorVibration.h 2012-08-01 19:51:04 UTC (rev 124358)
@@ -34,8 +34,8 @@
public:
typedef Vector<unsigned long> VibrationPattern;
- static void webkitVibrate(Navigator*, unsigned long time, ExceptionCode&);
- static void webkitVibrate(Navigator*, const VibrationPattern&, ExceptionCode&);
+ static void vibrate(Navigator*, unsigned long time, ExceptionCode&);
+ static void vibrate(Navigator*, const VibrationPattern&, ExceptionCode&);
private:
NavigatorVibration();
Modified: trunk/Source/WebCore/Modules/vibration/NavigatorVibration.idl (124357 => 124358)
--- trunk/Source/WebCore/Modules/vibration/NavigatorVibration.idl 2012-08-01 19:42:04 UTC (rev 124357)
+++ trunk/Source/WebCore/Modules/vibration/NavigatorVibration.idl 2012-08-01 19:51:04 UTC (rev 124358)
@@ -23,8 +23,8 @@
Conditional=VIBRATION,
Supplemental=Navigator
] NavigatorVibration {
- void webkitVibrate(in sequence<unsigned long> pattern) raises(DOMException);
- void webkitVibrate(in unsigned long time) raises(DOMException);
+ void vibrate(in sequence<unsigned long> pattern) raises(DOMException);
+ void vibrate(in unsigned long time) raises(DOMException);
};
}
