Title: [124360] trunk/Source/WebKit/mac
- Revision
- 124360
- Author
- [email protected]
- Date
- 2012-08-01 13:14:01 -0700 (Wed, 01 Aug 2012)
Log Message
Assertion failure in inspector/profiler/heap-snapshot-containment-show-all.html on Lion bot
https://bugs.webkit.org/show_bug.cgi?id=92888
Reviewed by Andreas Kling.
Protect the WebInspectorWindowController so it doesn't get destroyed during [WebView close] and cause
unsafe [WebView dealloc].
* WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController destroyInspectorView:]):
Modified Paths
Diff
Modified: trunk/Source/WebKit/mac/ChangeLog (124359 => 124360)
--- trunk/Source/WebKit/mac/ChangeLog 2012-08-01 20:10:18 UTC (rev 124359)
+++ trunk/Source/WebKit/mac/ChangeLog 2012-08-01 20:14:01 UTC (rev 124360)
@@ -1,3 +1,16 @@
+2012-08-01 Antti Koivisto <[email protected]>
+
+ Assertion failure in inspector/profiler/heap-snapshot-containment-show-all.html on Lion bot
+ https://bugs.webkit.org/show_bug.cgi?id=92888
+
+ Reviewed by Andreas Kling.
+
+ Protect the WebInspectorWindowController so it doesn't get destroyed during [WebView close] and cause
+ unsafe [WebView dealloc].
+
+ * WebCoreSupport/WebInspectorClient.mm:
+ (-[WebInspectorWindowController destroyInspectorView:]):
+
2012-07-29 Rik Cabanier <[email protected]>
Add ENABLE_CSS_COMPOSITING flag
Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm (124359 => 124360)
--- trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm 2012-08-01 20:10:18 UTC (rev 124359)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm 2012-08-01 20:14:01 UTC (rev 124360)
@@ -511,6 +511,7 @@
inspectedPage->inspectorController()->disconnectFrontend();
}
+ RetainPtr<WebInspectorWindowController> protect(self);
[_webView close];
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
