Title: [124417] trunk/Source/WebCore
- Revision
- 124417
- Author
- [email protected]
- Date
- 2012-08-02 00:48:29 -0700 (Thu, 02 Aug 2012)
Log Message
[EFL] Browser crashes when non-progress element with -webkit-appearance:progress-bar is rendered
https://bugs.webkit.org/show_bug.cgi?id=92747
Patch by Alexander Shalamov <[email protected]> on 2012-08-02
Reviewed by Hajime Morita.
When https://bugs.webkit.org/show_bug.cgi?id=40158 was fixed, all ports
were fixed except EFL port. This patch fixes assert that is hit when
non-progress element is rendered with -webkit-appearance:progress-bar style.
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::paintProgressBar):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (124416 => 124417)
--- trunk/Source/WebCore/ChangeLog 2012-08-02 07:14:49 UTC (rev 124416)
+++ trunk/Source/WebCore/ChangeLog 2012-08-02 07:48:29 UTC (rev 124417)
@@ -1,3 +1,17 @@
+2012-08-02 Alexander Shalamov <[email protected]>
+
+ [EFL] Browser crashes when non-progress element with -webkit-appearance:progress-bar is rendered
+ https://bugs.webkit.org/show_bug.cgi?id=92747
+
+ Reviewed by Hajime Morita.
+
+ When https://bugs.webkit.org/show_bug.cgi?id=40158 was fixed, all ports
+ were fixed except EFL port. This patch fixes assert that is hit when
+ non-progress element is rendered with -webkit-appearance:progress-bar style.
+
+ * platform/efl/RenderThemeEfl.cpp:
+ (WebCore::RenderThemeEfl::paintProgressBar):
+
2012-08-02 Yoshifumi Inoue <[email protected]>
REGRESSION(r102741): [Forms] In selects, when disabled, browser skips first option if not in optgroup, then selects first option in optgroup
Modified: trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp (124416 => 124417)
--- trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp 2012-08-02 07:14:49 UTC (rev 124416)
+++ trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp 2012-08-02 07:48:29 UTC (rev 124417)
@@ -1055,6 +1055,9 @@
bool RenderThemeEfl::paintProgressBar(RenderObject* object, const PaintInfo& info, const IntRect& rect)
{
+ if (!object->isProgress())
+ return true;
+
return paintThemePart(object, ProgressBar, info, rect);
}
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
