Title: [124450] trunk/Source/WebCore
Revision
124450
Author
[email protected]
Date
2012-08-02 06:45:41 -0700 (Thu, 02 Aug 2012)

Log Message

[EFL] Change return value of battey level
https://bugs.webkit.org/show_bug.cgi?id=92964

Patch by Kihong Kwon <[email protected]> on 2012-08-02
Reviewed by Simon Hausmann.

Change return value of navigator.webkitBattery.level from 0~100 to 0~1.0.
Battery level have to returns 0~1.0 by Battery Status API spec.

* platform/efl/BatteryProviderEfl.cpp:
(WebCore::BatteryProviderEfl::setBatteryClient):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (124449 => 124450)


--- trunk/Source/WebCore/ChangeLog	2012-08-02 13:45:07 UTC (rev 124449)
+++ trunk/Source/WebCore/ChangeLog	2012-08-02 13:45:41 UTC (rev 124450)
@@ -1,3 +1,16 @@
+2012-08-02  Kihong Kwon  <[email protected]>
+
+        [EFL] Change return value of battey level
+        https://bugs.webkit.org/show_bug.cgi?id=92964
+
+        Reviewed by Simon Hausmann.
+
+        Change return value of navigator.webkitBattery.level from 0~100 to 0~1.0.
+        Battery level have to returns 0~1.0 by Battery Status API spec.
+
+        * platform/efl/BatteryProviderEfl.cpp:
+        (WebCore::BatteryProviderEfl::setBatteryClient):
+
 2012-08-02  Yury Semikhatsky  <[email protected]>
 
         Web Inspector: remove extraObjectSize parameter from MemoryClassInfo constructor

Modified: trunk/Source/WebCore/platform/efl/BatteryProviderEfl.cpp (124449 => 124450)


--- trunk/Source/WebCore/platform/efl/BatteryProviderEfl.cpp	2012-08-02 13:45:07 UTC (rev 124449)
+++ trunk/Source/WebCore/platform/efl/BatteryProviderEfl.cpp	2012-08-02 13:45:41 UTC (rev 124450)
@@ -152,15 +152,14 @@
         dischargingTime = property->val.x;
     }
 
-    double level = 0;
+    double level = property->val.d / 100;
     bool levelChanged = false;
 
     property = static_cast<E_Ukit_Property*>(eina_hash_find(eukitPropertyNames->properties, "Percentage"));
     if (!property)
         return;
-    if (!clientBatteryStatus || clientBatteryStatus->level() != property->val.d)
+    if (!clientBatteryStatus || clientBatteryStatus->level() != level)
         levelChanged = true;
-    level = property->val.d;
 
     WTF::RefPtr<BatteryStatus> batteryStatus = BatteryStatus::create(charging, chargingTime, dischargingTime, level);
     if (chargingChanged)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to