Title: [124458] trunk/Source/WebCore
- Revision
- 124458
- Author
- [email protected]
- Date
- 2012-08-02 08:19:20 -0700 (Thu, 02 Aug 2012)
Log Message
Web Inspector: Move DOM breakpoints-related context menu items into a submenu
https://bugs.webkit.org/show_bug.cgi?id=92989
Reviewed by Vsevolod Vlasov.
A "Break on..." submenu is added to the element context menu, to host all DOM breakpoint items.
* English.lproj/localizedStrings.js:
* inspector/front-end/DOMBreakpointsSidebarPane.js:
(WebInspector.DOMBreakpointsSidebarPane):
(WebInspector.DOMBreakpointsSidebarPane.prototype.populateNodeContextMenu):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (124457 => 124458)
--- trunk/Source/WebCore/ChangeLog 2012-08-02 15:09:11 UTC (rev 124457)
+++ trunk/Source/WebCore/ChangeLog 2012-08-02 15:19:20 UTC (rev 124458)
@@ -1,3 +1,17 @@
+2012-08-02 Alexander Pavlov <[email protected]>
+
+ Web Inspector: Move DOM breakpoints-related context menu items into a submenu
+ https://bugs.webkit.org/show_bug.cgi?id=92989
+
+ Reviewed by Vsevolod Vlasov.
+
+ A "Break on..." submenu is added to the element context menu, to host all DOM breakpoint items.
+
+ * English.lproj/localizedStrings.js:
+ * inspector/front-end/DOMBreakpointsSidebarPane.js:
+ (WebInspector.DOMBreakpointsSidebarPane):
+ (WebInspector.DOMBreakpointsSidebarPane.prototype.populateNodeContextMenu):
+
2012-08-02 Dominik Röttsches <[email protected]>
[Cairo] Add complex font drawing using HarfbuzzNG
Modified: trunk/Source/WebCore/English.lproj/localizedStrings.js (124457 => 124458)
--- trunk/Source/WebCore/English.lproj/localizedStrings.js 2012-08-02 15:09:11 UTC (rev 124457)
+++ trunk/Source/WebCore/English.lproj/localizedStrings.js 2012-08-02 15:19:20 UTC (rev 124458)
@@ -90,6 +90,7 @@
localizedStrings["Audits"] = "Audits";
localizedStrings["Average"] = "Average";
localizedStrings["Blocking"] = "Blocking";
+localizedStrings["Break on..."] = "Break on...";
localizedStrings["Breakpoints"] = "Breakpoints";
localizedStrings["Cookies"] = "Cookies";
localizedStrings["COUNTERS"] = "COUNTERS";
@@ -473,12 +474,12 @@
localizedStrings["view decoded"] = "view decoded";
localizedStrings["view parsed"] = "view parsed";
localizedStrings["view source"] = "view source";
-localizedStrings["Break on Attributes Modifications"] = "Break on Attributes Modifications";
-localizedStrings["Break on attributes modifications"] = "Break on attributes modifications";
-localizedStrings["Break on Node Removal"] = "Break on Node Removal";
-localizedStrings["Break on node removal"] = "Break on node removal";
-localizedStrings["Break on Subtree Modifications"] = "Break on Subtree Modifications";
-localizedStrings["Break on subtree modifications"] = "Break on subtree modifications";
+localizedStrings["Attributes Modifications"] = "Attributes Modifications";
+localizedStrings["Attributes modifications"] = "Attributes modifications";
+localizedStrings["Node Removal"] = "Node Removal";
+localizedStrings["Node removal"] = "Node removal";
+localizedStrings["Subtree Modifications"] = "Subtree Modifications";
+localizedStrings["Subtree modifications"] = "Subtree modifications";
localizedStrings["<node>"] = "<node>";
localizedStrings["Paused on a \"%s\" breakpoint set on %s, because a new child was added to its descendant %s."] = "Paused on a \"%s\" breakpoint set on %s, because a new child was added to its descendant %s.";
localizedStrings["Paused on a \"%s\" breakpoint set on %s, because a new child was added to that node."] = "Paused on a \"%s\" breakpoint set on %s, because a new child was added to that node.";
Modified: trunk/Source/WebCore/inspector/front-end/DOMBreakpointsSidebarPane.js (124457 => 124458)
--- trunk/Source/WebCore/inspector/front-end/DOMBreakpointsSidebarPane.js 2012-08-02 15:09:11 UTC (rev 124457)
+++ trunk/Source/WebCore/inspector/front-end/DOMBreakpointsSidebarPane.js 2012-08-02 15:19:20 UTC (rev 124458)
@@ -49,9 +49,9 @@
this._breakpointTypeLabels[this._breakpointTypes.NodeRemoved] = WebInspector.UIString("Node Removed");
this._contextMenuLabels = {};
- this._contextMenuLabels[this._breakpointTypes.SubtreeModified] = WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? "Break on subtree modifications" : "Break on Subtree Modifications");
- this._contextMenuLabels[this._breakpointTypes.AttributeModified] = WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? "Break on attributes modifications" : "Break on Attributes Modifications");
- this._contextMenuLabels[this._breakpointTypes.NodeRemoved] = WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? "Break on node removal" : "Break on Node Removal");
+ this._contextMenuLabels[this._breakpointTypes.SubtreeModified] = WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? "Subtree modifications" : "Subtree Modifications");
+ this._contextMenuLabels[this._breakpointTypes.AttributeModified] = WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? "Attributes modifications" : "Attributes Modifications");
+ this._contextMenuLabels[this._breakpointTypes.NodeRemoved] = WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? "Node removal" : "Node Removal");
WebInspector.resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.InspectedURLChanged, this._inspectedURLChanged, this);
WebInspector.domAgent.addEventListener(WebInspector.DOMAgent.Events.NodeRemoved, this._nodeRemoved, this);
@@ -84,10 +84,11 @@
this._saveBreakpoints();
}
+ var breakPointSubMenu = contextMenu.appendSubMenuItem(WebInspector.UIString("Break on..."));
for (var key in this._breakpointTypes) {
var type = this._breakpointTypes[key];
var label = this._contextMenuLabels[type];
- contextMenu.appendCheckboxItem(label, toggleBreakpoint.bind(this, type), nodeBreakpoints[type]);
+ breakPointSubMenu.appendCheckboxItem(label, toggleBreakpoint.bind(this, type), nodeBreakpoints[type]);
}
},
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
