Diff
Modified: trunk/LayoutTests/ChangeLog (124481 => 124482)
--- trunk/LayoutTests/ChangeLog 2012-08-02 18:46:24 UTC (rev 124481)
+++ trunk/LayoutTests/ChangeLog 2012-08-02 18:53:16 UTC (rev 124482)
@@ -1,3 +1,17 @@
+2012-08-02 Chris Fleizach <[email protected]>
+
+ AXEnabled = false for AXIncrementors inside text fields
+ https://bugs.webkit.org/show_bug.cgi?id=93008
+
+ Reviewed by Anders Carlsson.
+
+ Update tests to reflect that mock objects should be enabled by default.
+
+ * platform/mac/accessibility/html5-input-number-expected.txt:
+ * platform/mac/accessibility/html5-input-number.html:
+ * platform/mac/accessibility/table-attributes-expected.txt:
+ * platform/mac/accessibility/table-sections-expected.txt:
+
2012-08-02 Roger Fong <[email protected]>
Layout Test: compositing/backface-visibility/backface-visibility-webgl.html is not supported on Windows.
Modified: trunk/LayoutTests/platform/mac/accessibility/html5-input-number-expected.txt (124481 => 124482)
--- trunk/LayoutTests/platform/mac/accessibility/html5-input-number-expected.txt 2012-08-02 18:46:24 UTC (rev 124481)
+++ trunk/LayoutTests/platform/mac/accessibility/html5-input-number-expected.txt 2012-08-02 18:53:16 UTC (rev 124482)
@@ -13,11 +13,13 @@
PASS incrementor.childAtIndex(0).subrole is 'AXSubrole: AXIncrementArrow'
PASS incrementor.childAtIndex(0).width > 0 is true
PASS incrementor.childAtIndex(0).height > 0 is true
+PASS incrementor.childAtIndex(0).isEnabled is true
PASS textfield.stringValue is 'AXValue: 1'
PASS incrementor.childAtIndex(1).role is 'AXRole: AXButton'
PASS incrementor.childAtIndex(1).subrole is 'AXSubrole: AXDecrementArrow'
PASS incrementor.childAtIndex(1).width > 0 is true
PASS incrementor.childAtIndex(1).height > 0 is true
+PASS incrementor.childAtIndex(1).isEnabled is true
PASS textfield.stringValue is 'AXValue: 0'
PASS successfullyParsed is true
Modified: trunk/LayoutTests/platform/mac/accessibility/html5-input-number.html (124481 => 124482)
--- trunk/LayoutTests/platform/mac/accessibility/html5-input-number.html 2012-08-02 18:46:24 UTC (rev 124481)
+++ trunk/LayoutTests/platform/mac/accessibility/html5-input-number.html 2012-08-02 18:53:16 UTC (rev 124482)
@@ -35,6 +35,7 @@
shouldBe("incrementor.childAtIndex(0).subrole", "'AXSubrole: AXIncrementArrow'");
shouldBeTrue("incrementor.childAtIndex(0).width > 0");
shouldBeTrue("incrementor.childAtIndex(0).height > 0");
+ shouldBeTrue("incrementor.childAtIndex(0).isEnabled");
// Increment.
incrementor.childAtIndex(0).press();
@@ -44,6 +45,7 @@
shouldBe("incrementor.childAtIndex(1).subrole", "'AXSubrole: AXDecrementArrow'");
shouldBeTrue("incrementor.childAtIndex(1).width > 0");
shouldBeTrue("incrementor.childAtIndex(1).height > 0");
+ shouldBeTrue("incrementor.childAtIndex(1).isEnabled");
// Decrement.
incrementor.childAtIndex(1).press();
Modified: trunk/LayoutTests/platform/mac/accessibility/table-attributes-expected.txt (124481 => 124482)
--- trunk/LayoutTests/platform/mac/accessibility/table-attributes-expected.txt 2012-08-02 18:46:24 UTC (rev 124481)
+++ trunk/LayoutTests/platform/mac/accessibility/table-attributes-expected.txt 2012-08-02 18:53:16 UTC (rev 124482)
@@ -252,7 +252,7 @@
AXDescription:
AXValue:
AXFocused: 0
-AXEnabled: 0
+AXEnabled: 1
AXWindow: <AXColumn>
AXSelectedTextMarkerRange: (null)
AXStartTextMarker: (null)
@@ -279,7 +279,7 @@
AXDescription:
AXValue:
AXFocused: 0
-AXEnabled: 0
+AXEnabled: 1
AXWindow: <AXColumn>
AXSelectedTextMarkerRange: (null)
AXStartTextMarker: (null)
@@ -306,7 +306,7 @@
AXDescription:
AXValue:
AXFocused: 0
-AXEnabled: 0
+AXEnabled: 1
AXWindow: <AXColumn>
AXSelectedTextMarkerRange: (null)
AXStartTextMarker: (null)
@@ -333,7 +333,7 @@
AXDescription:
AXValue:
AXFocused: 0
-AXEnabled: 0
+AXEnabled: 1
AXWindow: <AXColumn>
AXSelectedTextMarkerRange: (null)
AXStartTextMarker: (null)
@@ -360,7 +360,7 @@
AXDescription:
AXValue:
AXFocused: 0
-AXEnabled: 0
+AXEnabled: 1
AXWindow: <AXColumn>
AXSelectedTextMarkerRange: (null)
AXStartTextMarker: (null)
@@ -845,7 +845,7 @@
AXDescription:
AXValue:
AXFocused: 0
-AXEnabled: 0
+AXEnabled: 1
AXWindow: <AXGroup>
AXSelectedTextMarkerRange: (null)
AXStartTextMarker: (null)
Modified: trunk/LayoutTests/platform/mac/accessibility/table-sections-expected.txt (124481 => 124482)
--- trunk/LayoutTests/platform/mac/accessibility/table-sections-expected.txt 2012-08-02 18:46:24 UTC (rev 124481)
+++ trunk/LayoutTests/platform/mac/accessibility/table-sections-expected.txt 2012-08-02 18:53:16 UTC (rev 124482)
@@ -186,7 +186,7 @@
AXDescription:
AXValue:
AXFocused: 0
-AXEnabled: 0
+AXEnabled: 1
AXWindow: <AXColumn>
AXSelectedTextMarkerRange: (null)
AXStartTextMarker: (null)
@@ -213,7 +213,7 @@
AXDescription:
AXValue:
AXFocused: 0
-AXEnabled: 0
+AXEnabled: 1
AXWindow: <AXColumn>
AXSelectedTextMarkerRange: (null)
AXStartTextMarker: (null)
@@ -240,7 +240,7 @@
AXDescription:
AXValue:
AXFocused: 0
-AXEnabled: 0
+AXEnabled: 1
AXWindow: <AXColumn>
AXSelectedTextMarkerRange: (null)
AXStartTextMarker: (null)
@@ -675,7 +675,7 @@
AXDescription:
AXValue:
AXFocused: 0
-AXEnabled: 0
+AXEnabled: 1
AXWindow: <AXGroup>
AXSelectedTextMarkerRange: (null)
AXStartTextMarker: (null)
@@ -864,7 +864,7 @@
AXDescription:
AXValue:
AXFocused: 0
-AXEnabled: 0
+AXEnabled: 1
AXWindow: <AXColumn>
AXSelectedTextMarkerRange: (null)
AXStartTextMarker: (null)
@@ -891,7 +891,7 @@
AXDescription:
AXValue:
AXFocused: 0
-AXEnabled: 0
+AXEnabled: 1
AXWindow: <AXColumn>
AXSelectedTextMarkerRange: (null)
AXStartTextMarker: (null)
@@ -918,7 +918,7 @@
AXDescription:
AXValue:
AXFocused: 0
-AXEnabled: 0
+AXEnabled: 1
AXWindow: <AXColumn>
AXSelectedTextMarkerRange: (null)
AXStartTextMarker: (null)
@@ -1353,7 +1353,7 @@
AXDescription:
AXValue:
AXFocused: 0
-AXEnabled: 0
+AXEnabled: 1
AXWindow: <AXGroup>
AXSelectedTextMarkerRange: (null)
AXStartTextMarker: (null)
Modified: trunk/Source/WebCore/ChangeLog (124481 => 124482)
--- trunk/Source/WebCore/ChangeLog 2012-08-02 18:46:24 UTC (rev 124481)
+++ trunk/Source/WebCore/ChangeLog 2012-08-02 18:53:16 UTC (rev 124482)
@@ -1,3 +1,16 @@
+2012-08-02 Chris Fleizach <[email protected]>
+
+ AXEnabled = false for AXIncrementors inside text fields
+ https://bugs.webkit.org/show_bug.cgi?id=93008
+
+ Reviewed by Anders Carlsson.
+
+ Mock objects should return "enabled" by default, since they are valid objects.
+
+ * accessibility/AccessibilityMockObject.h:
+ (WebCore::AccessibilityMockObject::isEnabled):
+ (AccessibilityMockObject):
+
2012-08-02 Eric Seidel <[email protected]>
Add back ASSERT(!needsLayout) to RenderTableSection which is now valid
Modified: trunk/Source/WebCore/accessibility/AccessibilityMockObject.h (124481 => 124482)
--- trunk/Source/WebCore/accessibility/AccessibilityMockObject.h 2012-08-02 18:46:24 UTC (rev 124481)
+++ trunk/Source/WebCore/accessibility/AccessibilityMockObject.h 2012-08-02 18:53:16 UTC (rev 124482)
@@ -39,7 +39,8 @@
virtual AccessibilityObject* parentObject() const { return m_parent; }
virtual void setParent(AccessibilityObject* parent) { m_parent = parent; };
-
+ virtual bool isEnabled() const { return true; }
+
protected:
AccessibilityObject* m_parent;
