Title: [124496] trunk/Source/WebCore
- Revision
- 124496
- Author
- [email protected]
- Date
- 2012-08-02 14:06:06 -0700 (Thu, 02 Aug 2012)
Log Message
Add back ASSERT(!needsLayout) to RenderTableSection which is now valid
https://bugs.webkit.org/show_bug.cgi?id=92954
Unreviewed, follow-up per Mitz's request.
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::paint):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (124495 => 124496)
--- trunk/Source/WebCore/ChangeLog 2012-08-02 21:00:39 UTC (rev 124495)
+++ trunk/Source/WebCore/ChangeLog 2012-08-02 21:06:06 UTC (rev 124496)
@@ -1,3 +1,13 @@
+2012-08-02 Eric Seidel <[email protected]>
+
+ Add back ASSERT(!needsLayout) to RenderTableSection which is now valid
+ https://bugs.webkit.org/show_bug.cgi?id=92954
+
+ Unreviewed, follow-up per Mitz's request.
+
+ * rendering/RenderTableSection.cpp:
+ (WebCore::RenderTableSection::paint):
+
2012-08-02 James Robinson <[email protected]>
[chromium] Remove unused includes from compositor code
Modified: trunk/Source/WebCore/rendering/RenderTableSection.cpp (124495 => 124496)
--- trunk/Source/WebCore/rendering/RenderTableSection.cpp 2012-08-02 21:00:39 UTC (rev 124495)
+++ trunk/Source/WebCore/rendering/RenderTableSection.cpp 2012-08-02 21:06:06 UTC (rev 124496)
@@ -968,6 +968,11 @@
void RenderTableSection::paint(PaintInfo& paintInfo, const LayoutPoint& paintOffset)
{
ASSERT(!needsLayout());
+ // Tables are special, in that they hold local pointers to other renderers.
+ // If we aren't up-to-date on layout m_grid could have stale pointers.
+ // Out of an abundance of caution, we early return here in release builds.
+ if (needsLayout())
+ return;
unsigned totalRows = m_grid.size();
unsigned totalCols = table()->columns().size();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
