Title: [124498] trunk/Source/WebCore
- Revision
- 124498
- Author
- [email protected]
- Date
- 2012-08-02 14:25:37 -0700 (Thu, 02 Aug 2012)
Log Message
[V8] Handle case where Error.prototype returns an empty object
https://bugs.webkit.org/show_bug.cgi?id=91792
Reviewed by Kentaro Hara.
In some edge cases we get an empty object back from Error.prototype.
No new tests. I cannot reproduce this.
* bindings/v8/V8BindingPerContextData.cpp:
(WebCore::V8BindingPerContextData::constructorForTypeSlowCase):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (124497 => 124498)
--- trunk/Source/WebCore/ChangeLog 2012-08-02 21:10:43 UTC (rev 124497)
+++ trunk/Source/WebCore/ChangeLog 2012-08-02 21:25:37 UTC (rev 124498)
@@ -1,3 +1,17 @@
+2012-08-02 Erik Arvidsson <[email protected]>
+
+ [V8] Handle case where Error.prototype returns an empty object
+ https://bugs.webkit.org/show_bug.cgi?id=91792
+
+ Reviewed by Kentaro Hara.
+
+ In some edge cases we get an empty object back from Error.prototype.
+
+ No new tests. I cannot reproduce this.
+
+ * bindings/v8/V8BindingPerContextData.cpp:
+ (WebCore::V8BindingPerContextData::constructorForTypeSlowCase):
+
2012-08-02 Eric Seidel <[email protected]>
Add back ASSERT(!needsLayout) to RenderTableSection which is now valid
Modified: trunk/Source/WebCore/bindings/v8/V8BindingPerContextData.cpp (124497 => 124498)
--- trunk/Source/WebCore/bindings/v8/V8BindingPerContextData.cpp 2012-08-02 21:10:43 UTC (rev 124497)
+++ trunk/Source/WebCore/bindings/v8/V8BindingPerContextData.cpp 2012-08-02 21:25:37 UTC (rev 124498)
@@ -117,7 +117,7 @@
if (type->wrapperTypePrototype == WrapperTypeErrorPrototype) {
v8::Local<v8::Value> prototypeValue = function->Get(v8::String::NewSymbol("prototype"));
- if (prototypeValue->IsObject())
+ if (!prototypeValue.IsEmpty() && prototypeValue->IsObject())
v8::Local<v8::Object>::Cast(prototypeValue)->SetPrototype(m_errorPrototype.get());
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
