Title: [124609] trunk/Source/WebCore
- Revision
- 124609
- Author
- [email protected]
- Date
- 2012-08-03 07:14:01 -0700 (Fri, 03 Aug 2012)
Log Message
[BlackBerry] Add a null check for media implementation to fix a crash.
https://bugs.webkit.org/show_bug.cgi?id=93107
Reviewed by Rob Buis.
Fixes media/video-size.html.
* platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::paintMediaSliderTrack): Add null check.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (124608 => 124609)
--- trunk/Source/WebCore/ChangeLog 2012-08-03 14:11:03 UTC (rev 124608)
+++ trunk/Source/WebCore/ChangeLog 2012-08-03 14:14:01 UTC (rev 124609)
@@ -1,3 +1,15 @@
+2012-08-03 George Staikos <[email protected]>
+
+ [BlackBerry] Add a null check for media implementation to fix a crash.
+ https://bugs.webkit.org/show_bug.cgi?id=93107
+
+ Reviewed by Rob Buis.
+
+ Fixes media/video-size.html.
+
+ * platform/blackberry/RenderThemeBlackBerry.cpp:
+ (WebCore::RenderThemeBlackBerry::paintMediaSliderTrack): Add null check.
+
2012-08-03 Yury Semikhatsky <[email protected]>
Unreviewed. Fixed WinCE compilation after r124589.
Modified: trunk/Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp (124608 => 124609)
--- trunk/Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp 2012-08-03 14:11:03 UTC (rev 124608)
+++ trunk/Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp 2012-08-03 14:14:01 UTC (rev 124609)
@@ -899,7 +899,7 @@
// FIXME: replace loaded with commented out one when buffer bug is fixed (see comment in
// MediaPlayerPrivateMMrenderer::percentLoaded).
// loaded = mediaElement->percentLoaded();
- if (mediaElement->player())
+ if (mediaElement->player() && mediaElement->player()->implementation())
loaded = static_cast<MediaPlayerPrivate *>(mediaElement->player()->implementation())->percentLoaded();
float position = mediaElement->duration() > 0 ? (mediaElement->currentTime() / mediaElement->duration()) : 0;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes