Title: [124635] trunk/Tools
- Revision
- 124635
- Author
- [email protected]
- Date
- 2012-08-03 12:00:13 -0700 (Fri, 03 Aug 2012)
Log Message
Limited the number of queried cached build infos in URLs used by Garden-o-matic.
https://bugs.webkit.org/show_bug.cgi?id=92992.
Patch by Ádám Kallai <[email protected]> on 2012-08-03
Reviewed by Adam Barth.
I added a limit to the cached builds that are included in the URL to avoid too long URLs in Garden-o-matic.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
(.):
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js (124634 => 124635)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js 2012-08-03 18:54:07 UTC (rev 124634)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js 2012-08-03 19:00:13 UTC (rev 124635)
@@ -126,8 +126,8 @@
var builderInfoURL = urlForBuilderInfo(platform, builderName);
net.get(builderInfoURL, function(builderInfo) {
var selectURL = urlForBuilderInfo(platform, builderName) + 'builds';
- // // FIXME: limit to some reasonable number?
- var selectParams = { select : builderInfo.cachedBuilds };
+ var start = Math.max(0, builderInfo.cachedBuilds.length - config.kBuildNumberLimit);
+ var selectParams = { select : builderInfo.cachedBuilds.slice(start) };
var traditionalEncoding = true;
selectURL += '?' + $.param(selectParams, traditionalEncoding);
net.get(selectURL, callback);
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js (124634 => 124635)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js 2012-08-03 18:54:07 UTC (rev 124634)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js 2012-08-03 19:00:13 UTC (rev 124635)
@@ -27,6 +27,8 @@
(function() {
+config.kBuildNumberLimit = 20;
+
config.kPlatforms = {
'apple' : {
label : 'Apple',
Modified: trunk/Tools/ChangeLog (124634 => 124635)
--- trunk/Tools/ChangeLog 2012-08-03 18:54:07 UTC (rev 124634)
+++ trunk/Tools/ChangeLog 2012-08-03 19:00:13 UTC (rev 124635)
@@ -1,3 +1,16 @@
+2012-08-03 Ádám Kallai <[email protected]>
+
+ Limited the number of queried cached build infos in URLs used by Garden-o-matic.
+ https://bugs.webkit.org/show_bug.cgi?id=92992.
+
+ Reviewed by Adam Barth.
+
+ I added a limit to the cached builds that are included in the URL to avoid too long URLs in Garden-o-matic.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
+ (.):
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
+
2012-08-03 Tommy Widenflycht <[email protected]>
[chromium] MediaStream API: Add MockWebRTCPeerConnectionHandler
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
