Title: [124641] trunk/Source/WebCore
- Revision
- 124641
- Author
- [email protected]
- Date
- 2012-08-03 12:47:08 -0700 (Fri, 03 Aug 2012)
Log Message
Unreviewed, rolling out r124475 and r124496.
http://trac.webkit.org/changeset/124475
http://trac.webkit.org/changeset/124496
https://bugs.webkit.org/show_bug.cgi?id=93151
Causing assertion failures in table-section-node-at-point-
crash.html (Requested by inferno-sec on #webkit).
Patch by Sheriff Bot <[email protected]> on 2012-08-03
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::paint):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (124640 => 124641)
--- trunk/Source/WebCore/ChangeLog 2012-08-03 19:45:43 UTC (rev 124640)
+++ trunk/Source/WebCore/ChangeLog 2012-08-03 19:47:08 UTC (rev 124641)
@@ -1,3 +1,16 @@
+2012-08-03 Sheriff Bot <[email protected]>
+
+ Unreviewed, rolling out r124475 and r124496.
+ http://trac.webkit.org/changeset/124475
+ http://trac.webkit.org/changeset/124496
+ https://bugs.webkit.org/show_bug.cgi?id=93151
+
+ Causing assertion failures in table-section-node-at-point-
+ crash.html (Requested by inferno-sec on #webkit).
+
+ * rendering/RenderTableSection.cpp:
+ (WebCore::RenderTableSection::paint):
+
2012-08-03 Jan Keromnes <[email protected]>
Web Inspector: Create and interface for TextEditor
Modified: trunk/Source/WebCore/rendering/RenderTableSection.cpp (124640 => 124641)
--- trunk/Source/WebCore/rendering/RenderTableSection.cpp 2012-08-03 19:45:43 UTC (rev 124640)
+++ trunk/Source/WebCore/rendering/RenderTableSection.cpp 2012-08-03 19:47:08 UTC (rev 124641)
@@ -967,13 +967,12 @@
void RenderTableSection::paint(PaintInfo& paintInfo, const LayoutPoint& paintOffset)
{
- ASSERT(!needsLayout());
- // Tables are special, in that they hold local pointers to other renderers.
- // If we aren't up-to-date on layout m_grid could have stale pointers.
- // Out of an abundance of caution, we early return here in release builds.
+ // put this back in when all layout tests can handle it
+ // ASSERT(!needsLayout());
+ // avoid crashing on bugs that cause us to paint with dirty layout
if (needsLayout())
return;
-
+
unsigned totalRows = m_grid.size();
unsigned totalCols = table()->columns().size();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
