Title: [124646] trunk/Source/WebKit/chromium
- Revision
- 124646
- Author
- [email protected]
- Date
- 2012-08-03 13:23:50 -0700 (Fri, 03 Aug 2012)
Log Message
Unreviewed, rolling out r124632.
http://trac.webkit.org/changeset/124632
https://bugs.webkit.org/show_bug.cgi?id=93154
Added new WebFrameTest.SelectRange which fails on bots
(Requested by dimich on #webkit).
Patch by Sheriff Bot <[email protected]> on 2012-08-03
* tests/WebFrameTest.cpp:
* tests/data/select_range_basic.html: Removed.
* tests/data/select_range_iframe.html: Removed.
* tests/data/select_range_scroll.html: Removed.
Modified Paths
Removed Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (124645 => 124646)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-08-03 20:08:53 UTC (rev 124645)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-08-03 20:23:50 UTC (rev 124646)
@@ -1,3 +1,17 @@
+2012-08-03 Sheriff Bot <[email protected]>
+
+ Unreviewed, rolling out r124632.
+ http://trac.webkit.org/changeset/124632
+ https://bugs.webkit.org/show_bug.cgi?id=93154
+
+ Added new WebFrameTest.SelectRange which fails on bots
+ (Requested by dimich on #webkit).
+
+ * tests/WebFrameTest.cpp:
+ * tests/data/select_range_basic.html: Removed.
+ * tests/data/select_range_iframe.html: Removed.
+ * tests/data/select_range_scroll.html: Removed.
+
2012-08-03 Terry Anderson <[email protected]>
Apply target fuzzing when sending a context menu event
Modified: trunk/Source/WebKit/chromium/tests/WebFrameTest.cpp (124645 => 124646)
--- trunk/Source/WebKit/chromium/tests/WebFrameTest.cpp 2012-08-03 20:08:53 UTC (rev 124645)
+++ trunk/Source/WebKit/chromium/tests/WebFrameTest.cpp 2012-08-03 20:23:50 UTC (rev 124646)
@@ -804,38 +804,4 @@
EXPECT_TRUE(selectionHtml.isEmpty());
}
-TEST_F(WebFrameTest, SelectRange)
-{
- registerMockedHttpURLLoad("select_range_basic.html");
- WebView* webView = FrameTestHelpers::createWebViewAndLoad(m_baseURL + "select_range_basic.html", true);
- WebFrame* frame = webView->mainFrame();
- WebRect startWebRect;
- WebRect endWebRect;
- webView->selectionBounds(startWebRect, endWebRect);
- frame->executeCommand(WebString::fromUTF8("Unselect"));
- EXPECT_EQ("", std::string(frame->selectionAsText().utf8().data()));
- frame->selectRange(WebPoint(startWebRect.x, startWebRect.y), WebPoint(endWebRect.x + endWebRect.width, endWebRect.y + endWebRect.height));
- EXPECT_EQ("some test text for testing", std::string(frame->selectionAsText().utf8().data()));
-
- registerMockedHttpURLLoad("select_range_scroll.html");
- webView = FrameTestHelpers::createWebViewAndLoad(m_baseURL + "select_range_scroll.html", true);
- frame = webView->mainFrame();
- webView->selectionBounds(startWebRect, endWebRect);
- frame->executeCommand(WebString::fromUTF8("Unselect"));
- EXPECT_EQ("", std::string(frame->selectionAsText().utf8().data()));
- frame->selectRange(WebPoint(startWebRect.x, startWebRect.y), WebPoint(endWebRect.x + endWebRect.width, endWebRect.y + endWebRect.height));
- EXPECT_EQ("some offscreen test text for testing", std::string(frame->selectionAsText().utf8().data()));
-
- registerMockedHttpURLLoad("select_range_iframe.html");
- webView = FrameTestHelpers::createWebViewAndLoad(m_baseURL + "select_range_iframe.html", true);
- frame = webView->mainFrame();
- WebFrame* subframe = frame->findChildByExpression(WebString::fromUTF8("/html/body/iframe"));
- webView->selectionBounds(startWebRect, endWebRect);
- EXPECT_EQ("some test text for testing", std::string(subframe->selectionAsText().utf8().data()));
- subframe->executeCommand(WebString::fromUTF8("Unselect"));
- EXPECT_EQ("", std::string(subframe->selectionAsText().utf8().data()));
- subframe->selectRange(WebPoint(startWebRect.x, startWebRect.y), WebPoint(endWebRect.x + endWebRect.width, endWebRect.y + endWebRect.height));
- EXPECT_EQ("some test text for testing", std::string(subframe->selectionAsText().utf8().data()));
-}
-
} // namespace
Deleted: trunk/Source/WebKit/chromium/tests/data/select_range_basic.html (124645 => 124646)
--- trunk/Source/WebKit/chromium/tests/data/select_range_basic.html 2012-08-03 20:08:53 UTC (rev 124645)
+++ trunk/Source/WebKit/chromium/tests/data/select_range_basic.html 2012-08-03 20:23:50 UTC (rev 124646)
@@ -1,9 +0,0 @@
-<span id='target'>some test text for testing</span>
-<script>
- function select() {
- var range = document.createRange();
- range.selectNode(document.getElementById('target'));
- window.getSelection().addRange(range);
- }
- window._onload_ = select;
-</script>
Deleted: trunk/Source/WebKit/chromium/tests/data/select_range_iframe.html (124645 => 124646)
--- trunk/Source/WebKit/chromium/tests/data/select_range_iframe.html 2012-08-03 20:08:53 UTC (rev 124645)
+++ trunk/Source/WebKit/chromium/tests/data/select_range_iframe.html 2012-08-03 20:23:50 UTC (rev 124646)
@@ -1,9 +0,0 @@
-<html>
- <body>
- This is a test case for selecting a range within an iframe.
- <iframe width=400 height=200 id="iframe" src=""
- </body>
-</html>
-<script>
- document.getElementById('iframe').contentWindow.focus();
-</script>
Deleted: trunk/Source/WebKit/chromium/tests/data/select_range_scroll.html (124645 => 124646)
--- trunk/Source/WebKit/chromium/tests/data/select_range_scroll.html 2012-08-03 20:08:53 UTC (rev 124645)
+++ trunk/Source/WebKit/chromium/tests/data/select_range_scroll.html 2012-08-03 20:23:50 UTC (rev 124646)
@@ -1,9 +0,0 @@
-<div style='height:3000px'>
- <span id="target">some offscreen test text for testing</span>
-</div>
-<script>
- var range = document.createRange();
- range.selectNode(document.getElementById('target'));
- window.getSelection().addRange(range);
- window.scrollBy(0,500);
-</script>
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
