Title: [124677] trunk/Source/WebCore
Revision
124677
Author
[email protected]
Date
2012-08-03 17:40:01 -0700 (Fri, 03 Aug 2012)

Log Message

[chromium] Fix Renderer4.CompositorThreadImplDrawDelay histogram.
https://bugs.webkit.org/show_bug.cgi?id=93159

Patch by Dave Tu <[email protected]> on 2012-08-03
Reviewed by Adrienne Walker.

The histogram is using the frame number instead of the frame time by mistake.

* platform/graphics/chromium/cc/CCFrameRateCounter.cpp:
(WebCore::CCFrameRateCounter::markBeginningOfFrame):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (124676 => 124677)


--- trunk/Source/WebCore/ChangeLog	2012-08-04 00:31:32 UTC (rev 124676)
+++ trunk/Source/WebCore/ChangeLog	2012-08-04 00:40:01 UTC (rev 124677)
@@ -1,3 +1,15 @@
+2012-08-03  Dave Tu  <[email protected]>
+
+        [chromium] Fix Renderer4.CompositorThreadImplDrawDelay histogram.
+        https://bugs.webkit.org/show_bug.cgi?id=93159
+
+        Reviewed by Adrienne Walker.
+
+        The histogram is using the frame number instead of the frame time by mistake.
+
+        * platform/graphics/chromium/cc/CCFrameRateCounter.cpp:
+        (WebCore::CCFrameRateCounter::markBeginningOfFrame):
+
 2012-08-03  David Grogan  <[email protected]>
 
         IndexedDB: Core upgradeneeded logic

Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCFrameRateCounter.cpp (124676 => 124677)


--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCFrameRateCounter.cpp	2012-08-04 00:31:32 UTC (rev 124676)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCFrameRateCounter.cpp	2012-08-04 00:40:01 UTC (rev 124677)
@@ -66,17 +66,15 @@
 
 void CCFrameRateCounter::markBeginningOfFrame(double timestamp)
 {
-    if (CCProxy::hasImplThread() && m_currentFrameNumber > 0) {
-        double lastFrameTimestamp = frameIndex(m_currentFrameNumber - 1);
-        double drawDelaySeconds = timestamp - lastFrameTimestamp;
-        double drawDelayMs = drawDelaySeconds * 1000.0;
+    m_timeStampHistory[frameIndex(m_currentFrameNumber)] = timestamp;
+    double frameIntervalSeconds = frameInterval(m_currentFrameNumber);
 
+    if (CCProxy::hasImplThread() && m_currentFrameNumber > 0) {
+        double drawDelayMs = frameIntervalSeconds * 1000.0;
         WebKit::Platform::current()->histogramCustomCounts("Renderer4.CompositorThreadImplDrawDelay", static_cast<int>(drawDelayMs), 1, 120, 60);
     }
 
-    m_timeStampHistory[frameIndex(m_currentFrameNumber)] = timestamp;
-    double delta = frameInterval(m_currentFrameNumber);
-    if (!isBadFrameInterval(delta) && delta > kDroppedFrameTime)
+    if (!isBadFrameInterval(frameIntervalSeconds) && frameIntervalSeconds > kDroppedFrameTime)
         ++m_droppedFrameCount;
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to