Title: [124719] trunk/Source/WebKit/win
- Revision
- 124719
- Author
- [email protected]
- Date
- 2012-08-05 13:55:48 -0700 (Sun, 05 Aug 2012)
Log Message
[WIN] Use sizeof() for cbWndExtra values
https://bugs.webkit.org/show_bug.cgi?id=93179
Reviewed by Eric Carlson.
Using sizof() instead of hardcoding the pointer size of
the 32bit platform allows us to use the code on 64bit too.
* FullscreenVideoController.cpp:
(FullscreenVideoController::registerHUDWindowClass):
* WebView.cpp:
(WebView::registerWebViewWindowClass):
Modified Paths
Diff
Modified: trunk/Source/WebKit/win/ChangeLog (124718 => 124719)
--- trunk/Source/WebKit/win/ChangeLog 2012-08-05 18:40:23 UTC (rev 124718)
+++ trunk/Source/WebKit/win/ChangeLog 2012-08-05 20:55:48 UTC (rev 124719)
@@ -1,3 +1,18 @@
+2012-08-05 Patrick Gansterer <[email protected]>
+
+ [WIN] Use sizeof() for cbWndExtra values
+ https://bugs.webkit.org/show_bug.cgi?id=93179
+
+ Reviewed by Eric Carlson.
+
+ Using sizof() instead of hardcoding the pointer size of
+ the 32bit platform allows us to use the code on 64bit too.
+
+ * FullscreenVideoController.cpp:
+ (FullscreenVideoController::registerHUDWindowClass):
+ * WebView.cpp:
+ (WebView::registerWebViewWindowClass):
+
2012-07-26 Gyuyoung Kim <[email protected]>
[Mac] Fix build break on Apple win bot after r123711
Modified: trunk/Source/WebKit/win/FullscreenVideoController.cpp (124718 => 124719)
--- trunk/Source/WebKit/win/FullscreenVideoController.cpp 2012-08-05 18:40:23 UTC (rev 124718)
+++ trunk/Source/WebKit/win/FullscreenVideoController.cpp 2012-08-05 20:55:48 UTC (rev 124719)
@@ -422,7 +422,7 @@
wcex.style = CS_HREDRAW | CS_VREDRAW;
wcex.lpfnWndProc = hudWndProc;
wcex.cbClsExtra = 0;
- wcex.cbWndExtra = 4;
+ wcex.cbWndExtra = sizeof(FullscreenVideoController*);
wcex.hInstance = gInstance;
wcex.hIcon = 0;
wcex.hCursor = LoadCursor(0, IDC_ARROW);
Modified: trunk/Source/WebKit/win/WebView.cpp (124718 => 124719)
--- trunk/Source/WebKit/win/WebView.cpp 2012-08-05 18:40:23 UTC (rev 124718)
+++ trunk/Source/WebKit/win/WebView.cpp 2012-08-05 20:55:48 UTC (rev 124719)
@@ -2105,7 +2105,7 @@
wcex.style = CS_DBLCLKS;
wcex.lpfnWndProc = WebViewWndProc;
wcex.cbClsExtra = 0;
- wcex.cbWndExtra = 4; // 4 bytes for the IWebView pointer
+ wcex.cbWndExtra = sizeof(WebView*);
wcex.hInstance = gInstance;
wcex.hIcon = 0;
wcex.hCursor = ::LoadCursor(0, IDC_ARROW);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
