Title: [124842] trunk/Source/WebCore
- Revision
- 124842
- Author
- [email protected]
- Date
- 2012-08-06 20:40:29 -0700 (Mon, 06 Aug 2012)
Log Message
IndexedDB: Remove IDBRequest::finishCursor() and plumbing
https://bugs.webkit.org/show_bug.cgi?id=93274
Reviewed by Tony Chang.
Delete an unused flag and code for setting it, rendered obsolete in r123275.
No new tests - no functional changes.
* Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::close):
* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::IDBRequest):
* Modules/indexeddb/IDBRequest.h:
(IDBRequest):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (124841 => 124842)
--- trunk/Source/WebCore/ChangeLog 2012-08-07 03:37:24 UTC (rev 124841)
+++ trunk/Source/WebCore/ChangeLog 2012-08-07 03:40:29 UTC (rev 124842)
@@ -1,3 +1,21 @@
+2012-08-06 Joshua Bell <[email protected]>
+
+ IndexedDB: Remove IDBRequest::finishCursor() and plumbing
+ https://bugs.webkit.org/show_bug.cgi?id=93274
+
+ Reviewed by Tony Chang.
+
+ Delete an unused flag and code for setting it, rendered obsolete in r123275.
+
+ No new tests - no functional changes.
+
+ * Modules/indexeddb/IDBCursor.cpp:
+ (WebCore::IDBCursor::close):
+ * Modules/indexeddb/IDBRequest.cpp:
+ (WebCore::IDBRequest::IDBRequest):
+ * Modules/indexeddb/IDBRequest.h:
+ (IDBRequest):
+
2012-08-06 James Robinson <[email protected]>
[chromium] Remove lingering unwrap<>() calls in GraphicsLayerChromium.cpp
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBCursor.cpp (124841 => 124842)
--- trunk/Source/WebCore/Modules/indexeddb/IDBCursor.cpp 2012-08-07 03:37:24 UTC (rev 124841)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBCursor.cpp 2012-08-07 03:40:29 UTC (rev 124842)
@@ -262,7 +262,6 @@
void IDBCursor::close()
{
ASSERT(m_request);
- m_request->finishCursor();
m_request.clear();
}
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBRequest.cpp (124841 => 124842)
--- trunk/Source/WebCore/Modules/indexeddb/IDBRequest.cpp 2012-08-07 03:37:24 UTC (rev 124841)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBRequest.cpp 2012-08-07 03:40:29 UTC (rev 124842)
@@ -58,7 +58,6 @@
, m_transaction(transaction)
, m_readyState(PENDING)
, m_requestAborted(false)
- , m_cursorFinished(false)
, m_contextStopped(false)
, m_cursorType(IDBCursorBackendInterface::InvalidCursorType)
, m_cursorDirection(IDBCursor::NEXT)
@@ -211,12 +210,6 @@
m_result = IDBAny::create(IDBCursorWithValue::fromCursor(prpCursor));
}
-void IDBRequest::finishCursor()
-{
- ASSERT(m_readyState == PENDING || m_readyState == DONE);
- m_cursorFinished = true;
-}
-
void IDBRequest::onError(PassRefPtr<IDBDatabaseError> error)
{
ASSERT(m_readyState == PENDING || m_readyState == DONE);
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBRequest.h (124841 => 124842)
--- trunk/Source/WebCore/Modules/indexeddb/IDBRequest.h 2012-08-07 03:37:24 UTC (rev 124841)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBRequest.h 2012-08-07 03:40:29 UTC (rev 124842)
@@ -76,7 +76,6 @@
void markEarlyDeath();
void setCursorDetails(IDBCursorBackendInterface::CursorType, IDBCursor::Direction);
void setPendingCursor(PassRefPtr<IDBCursor>);
- void finishCursor();
void abort();
// IDBCallbacks
@@ -129,7 +128,6 @@
ReadyState m_readyState;
bool m_requestAborted; // May be aborted by transaction then receive async onsuccess; ignore vs. assert.
- bool m_cursorFinished;
bool m_contextStopped;
Vector<RefPtr<Event> > m_enqueuedEvents;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
